gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
32,686 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Marcel de Rooy 4febf0656c Bug 17776: (QA follow-up) Remove shibboleth package variables 
This is about $shib and $shib_login.
We move in the right direction by calling get_login_shib in
get_template_and_user and checkauth. In the same line we can do the
shib_ok check at that time (just checking cached values). This paves
the way for the third subroutine using the two package vars: checkpw.
Note that checkpw is also called outside Auth.pm. So I would be more
comfortable if we do the same calls like in checkauth and remove both
variables from the package level (especially under Plack of course).

The former changes actually justify a 'use C4::Auth_with_shibboleth'
instead of the current require and import.

Note: When calling checkpw from checkauth, we are calling get_login_shib
twice now. But the time involved for doing so is around zero (cache), so
not really an argument for extra parameters and complexer code.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
 		2018-10-09 15:02:50 +00:00
C4 Bug 17776: (QA follow-up) Remove shibboleth package variables 2018-10-09 15:02:50 +00:00
Koha Bug 20548: Remove copyright clearance for staff 2018-10-09 15:02:46 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 20151: always use current language for stemming 2018-10-09 15:02:47 +00:00
admin Bug 21417: EDI ordering fails when basket and EAN libraries do not match 2018-10-09 11:54:08 +00:00
api/v1 Bug 20944: OpenAPI spec for /patrons/{patron_id}/account/credits 2018-08-31 12:46:59 +00:00
authorities Bug 21455: Authority search options get shuffled around when you click on 'Search' 2018-10-09 11:54:08 +00:00
basket Bug 16575: Irregular behaviour using window.print() followed by window.location.href 2018-07-19 16:12:56 +00:00
catalogue Bug 21248: Fix COinS carp in MARC details page on unknown record 2018-09-14 17:28:49 +00:00
cataloguing Bug 20151: always use current language for stemming 2018-10-09 15:02:47 +00:00
circ Bug 19383: (QA follow-up) Remove unused name variable 2018-08-30 19:52:49 +00:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 20467: (QA follow-up) Display error if no or invalid course id is passed 2018-07-02 12:55:38 +00:00
debian Bug 21426: Handle USE_MEMCACHED=no in koha-create 2018-10-09 15:02:48 +00:00
docs Bug 7143: Update about page for new dev - Cori Lynn Arnold` 2018-10-03 17:56:22 +00:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 14302: (QA follow-up) Remove remaining file 2018-08-31 11:24:21 +00:00
ill Bug 21289: Fix "isa" bug during partner request 2018-10-01 11:03:48 +00:00
installer Bug 21417: DBRev 18.06.00.038 2018-10-09 12:57:29 +00:00
koha-tmpl Bug 21493: Compiled CSS 2018-10-09 15:02:48 +00:00
labels Bug 20765: Fix search for items by acqdate in label batch 2018-09-15 21:20:19 +00:00
members Bug 21167: Fix price formatting on printed fee invoice and receipt 2018-09-28 19:41:36 +00:00
misc Bug 21481: (QA follow-up) Remove last reference to text-extract2 2018-10-05 15:03:18 +00:00
offline_circ Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl 2018-09-14 17:27:29 +00:00
opac Bug 20548: Remove copyright clearance for staff 2018-10-09 15:02:46 +00:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 8604: Patron cards made for patrons which don't have patron images use preceding card's image 2018-07-23 15:08:57 +00:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 9188: Remove 'debug' information from patron statistics 2018-10-01 13:56:37 +00:00
reserve Bug 19469: (QA follow-up) Use hold item's itemtype if available, fix priority changing 2018-09-14 17:50:19 +00:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 20241: Fix display of publication year in subscription record search for MARC21 2018-09-28 19:35:15 +00:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-08 20:58:23 +00:00
svc Bug 16424: (QA follow-up) Use Modern::Perl 2018-09-28 19:01:51 +00:00
t Bug 20548: (follow-up) Fix unit tests 2018-10-09 15:02:46 +00:00
tags Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 15971: Add biblioitems to available fields for serial claim notices and fix notices editor display 2018-10-01 13:56:34 +00:00
virtualshelves Bug 19039: (follow-up) Results of virtual shelves (lists) not sortable by date 2018-08-24 16:23:27 +00:00
xt Bug 21393: Move missing filters code to a module 2018-10-01 13:56:32 +00:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 21417: DBRev 18.06.00.038 2018-10-09 12:57:29 +00:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 19817: Remove local help files + edit help feature 2018-09-06 17:32:27 +00:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
changelanguage.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 17698: Do not send pending_checkout_notes from all circ scripts 2018-07-23 15:23:44 +00:00
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
rewrite-config.PL Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo