Koha-clms/C4/SIP/ILS/Transaction
Kyle Hall a0484a9075
Bug 33216: Catch and handle RegisterRequired exceptions for SIP fee paid messages
If registers are being used in Koha, they are required. If a SIP account has no register and a fee paid message is sent, the SIP server crashes and the client never gets a response. It would be much better if Koha would response with 38 response where "payment accepted" is N, and an AF field stating that the SIP account needs to be associated with a register.

Test Plan:
1) Enable UseCashRegisters, set RequireCashRegister to "always require a
   cash register". Do *not* set a cash register for the SIP account you
   will be testing with.
2) Using the SIP cli tester, send a fee paid message for a patron owing
   fees.
3) Note the lack of a SIP response
4) Apply this patch
5) Restart the SIP server
6) Repeat step 2, you should now get a SIP response with the error
   message in it!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0411bf0573)
Signed-off-by: Jacob O'Mara <jacobomara901@gmail.com>
(cherry picked from commit c6610d5ed9)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 175dd2871c)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
2023-05-23 20:43:31 +02:00
..
Checkin.pm Bug 30118: (QA follow-up) Fix Perl Critic issues 2022-04-15 07:12:24 -04:00
Checkout.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
FeePayment.pm Bug 33216: Catch and handle RegisterRequired exceptions for SIP fee paid messages 2023-05-23 20:43:31 +02:00
Hold.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Renew.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
RenewAll.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00