gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/opac
History
Tomas Cohen Arazi aacb4e6bb9 Bug 22739: Test SelfCheckInTimeout <> 0, not just defined 
On sci-main.pl the preference value is tested for 'defined'. This patch
tests it is different than empty string too. This was causing a
JavaScript syntax error, that made it display a wrong message.

To test:
1 - Blank the syspref SelfCheckInTimeout
2 - Attempt to checkin something via sci
=> FAIL: The 'Your request included no check-ins.' message is printed.
3 - Apply this patch, reload the sci-main.pl page
4 - Attempt to checkin something via sci
=> SUCCESS: The UI correctly stacks the scanned barcodes
5 - Sign off :-D

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit c1949cda9b)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 1269f7d6c7)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
 		2019-05-13 20:34:43 +00:00
..
clubs Bug 22542: Force back button to display personal data 2019-04-29 01:05:37 +00:00
errors Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
external/overdrive bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron 2017-02-21 19:58:20 +00:00
rss
…
sci Bug 22739: Test SelfCheckInTimeout <> 0, not just defined 2019-05-13 20:34:43 +00:00
sco Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
svc Bug 22542: Force back button to display personal data 2019-04-29 01:05:37 +00:00
ilsdi.pl Bug 21719: Fix typos 2018-11-16 12:59:57 +00:00
maintenance.pl Bug 17989: Include full path logic in _get_template_file 2017-11-01 13:10:17 -03:00
oai.pl Bug 14939: Modularize OAI Server existing classes 2015-12-31 15:15:05 +00:00
opac-ISBDdetail.pl Bug 22735: Resolve internal server error on missing item type 2019-05-13 08:10:59 +00:00
opac-MARCdetail.pl Bug 22735: Resolve internal server error on missing item type 2019-05-13 08:10:59 +00:00
opac-account-pay-paypal-return.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-account-pay-return.pl Bug 19173: Make OPAC online payments pluggable 2017-09-19 14:15:52 -03:00
opac-account-pay.pl Bug 22542: Force back button to display personal data 2019-04-29 01:05:37 +00:00
opac-account.pl Bug 12001: Move GetMemberAccountRecords to the Koha namespace 2018-02-23 10:57:30 -03:00
opac-addbybiblionumber.pl Bug 22542: Force back button to display personal data 2019-04-29 01:05:37 +00:00
opac-alert-subscribe.pl Bug 22542: Force back button to display personal data 2019-04-29 01:05:37 +00:00
opac-article-request-cancel.pl Bug 22068: (QA follow-up) Return meaningful error codes 2019-04-15 18:08:57 +00:00
opac-authorities-home.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-authoritiesdetail.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-basket.pl Bug 19708: Improve code for printing the cart in OPAC 2018-03-26 17:31:16 -03:00
opac-blocked.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
opac-browser.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-changelanguage.pl Bug 18946 [QA Followup] - code cleanup 2017-09-01 13:02:26 -03:00
opac-course-details.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-course-reserves.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-detail.pl Bug 22360: (rm follow-up) reverting accidental commit 2019-03-11 22:10:26 +00:00
opac-discharge.pl Bug 20953: Prevent several discharge requests on OPAC 2018-07-15 20:01:34 +01:00
opac-downloadcart.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-downloadshelf.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-export.pl Bug 22075: Fix encoding problem with RIS export in OPAC 2019-04-16 20:45:17 +00:00
opac-ics.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-idref.pl Bug 19640: fix OPAC IdRef webservice display 2017-12-07 09:37:09 -03:00
opac-illrequests.pl Bug 22542: Force back button to display personal data 2019-04-29 01:05:37 +00:00
opac-image.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-imageviewer.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-issue-note.pl Bug 18915: Fix checkout note email message 2018-01-15 12:14:00 -03:00
opac-main.pl Bug 19892: Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC 2018-04-02 18:08:07 -03:00
opac-memberentry.pl Bug 21192: Do not pick SelfRegistration hidden fields for SelfModification 2019-02-01 17:09:41 +00:00
opac-messaging.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-modrequest-suspend.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-modrequest.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-mymessages.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-news-rss.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
opac-overdrive-search.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-passwd.pl Bug 21719: Fix typos 2018-11-16 12:59:57 +00:00
opac-password-recovery.pl Bug 21771: (follow-up) Revert the shift statement 2018-11-16 12:37:51 +00:00
opac-patron-image.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-privacy.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-ratings-ajax.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-ratings.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-readingrecord.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-registration-verify.pl Bug 19579: Do not confirm the registration if email already used - PatronSelfRegistrationEmailMustBeUnique 2018-05-11 10:52:46 -03:00
opac-renew.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-request-article.pl Bug 22542: Force back button to display personal data 2019-04-29 01:05:37 +00:00
opac-reserve.pl Bug 22542: Force back button to display personal data 2019-04-29 01:05:37 +00:00
opac-restrictedpage.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
opac-retrieve-file.pl Bug 17501: Move getCategories and httpheaders from Upload.pm 2017-01-20 14:20:05 +00:00
opac-review.pl Bug 22395: reverting 21986 2019-02-28 00:12:41 +00:00
opac-routing-lists.pl Bug 20666: Correct permissions on opac-routing-lists.pl 2018-05-03 13:26:48 -03:00
opac-search-history.pl Bug 12497: Fix OPAC search history reachable by URL even when disabled 2017-12-07 10:09:52 -03:00
opac-search.pl Bug 21719: Fix typos 2018-11-16 12:59:57 +00:00
opac-sendbasket.pl Bug 22542: Force back button to display personal data 2019-04-29 01:05:37 +00:00
opac-sendshelf.pl Bug 22542: Force back button to display personal data 2019-04-29 01:05:37 +00:00
opac-serial-issues.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-shareshelf.pl Bug 22542: Force back button to display personal data 2019-04-29 01:05:37 +00:00
opac-shelves.pl Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean 2019-04-29 01:49:01 +00:00
opac-showmarc.pl Bug 20083: (follow-up) use same logic in opac-showmarc 2018-04-04 15:45:34 -03:00
opac-showreviews.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-suggestions.pl Bug 22542: Force back button to display personal data 2019-04-29 01:05:37 +00:00
opac-tags.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-tags_subject.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-topissues.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00
opac-user.pl Bug 19991: Remove warning from opac-user 2018-09-05 11:20:48 +01:00
tracklinks.pl Bug 21018: Allow uris defined in the item 2018-08-09 11:08:29 +01:00
unapi Bug 19991: use Modern::Perl in OPAC perl scripts 2018-09-05 11:14:29 +01:00