gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/t/db_dependent
History
Kyle M Hall 7d15ff3404
Bug 23727: Editing course reserve items is broken 
Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged".

This patch set adds two new sets of columns to the course_items table.

The first set determines if the specified column should be swapped or
not. The was previously 'implied' by the column being set to undef which
has been the root problem with that way of knowing if a column should
swap or not.

The second set of new columns are for storing the item field values
while the item is on course reserve. Previously, the column values
were swapped between the items table and the course_items table,
which leaves ambiguity as to what each value is. Now, the original
columns *always* store the value when the item is on course reserve,
and the new storage columns store the original item value while the
item is on reserve, and are NULL when an item is *not* on reserve.

Test Plan:
1) Apply this patch
2) Add and edit course items, not the new checkboxes for enabling fields
3) Everything should function as before

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
 		2020-04-17 13:45:56 +01:00
..
Acquisition Bug 20728: Replace the calls by their Koha::Acq::Orders->search equivalent 2020-04-14 16:39:06 +01:00
Auth
…
Authority
…
Biblio Bug 24715: Cache repeatable subfield in TransformKohaToMarc 2020-04-17 09:25:06 +01:00
Circulation Bug 24380: (QA follow-up) Do not use compare float with precision 2020-04-15 12:28:45 +01:00
CourseReserves Bug 23727: Editing course reserve items is broken 2020-04-17 13:45:56 +01:00
Creators
…
Exporter
…
Holds Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Illrequest Bug 23173: Add unit tests 2020-04-06 11:04:36 +01:00
Items Bug 23463: Move DelItem.t and Items_DelItemCheck.t tests to a Koha/Item.t subtest 2020-03-23 09:26:33 +00:00
Koha Bug 25131: Regression tests 2020-04-16 19:21:06 +01:00
LDAP
…
Labels Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
Letters Bug 21901: (RM follow-up) Use TestBuilder to fix tests 2020-04-17 13:37:33 +01:00
Members Bug 20443: Remove extended_attributes_code_value_arrayref AND C4::Members::Attributes 2020-03-23 13:49:22 +00:00
OAI Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Patron Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Record
…
Reports Bug 22001: Make the DBD error regex less strict 2020-03-31 17:46:21 +01:00
Reserves Bug 14711: Change prototype for AddReserve - pass a hashref 2020-02-11 14:32:47 +00:00
SIP Bug 24966: Add unit tests 2020-04-14 08:27:14 +01:00
Search
…
Serials Bug 7046: Implemented subscription renewal dropdown sub length element 2020-04-08 11:48:03 +01:00
Template/Plugin Bug 21503: Restore existing ternary operator logic 2020-03-24 11:30:08 +00:00
Utils Bug 25046: Add test 2020-04-08 11:51:48 +01:00
api/v1 Bug 22001: Make the DBD error regex less strict 2020-03-31 17:46:21 +01:00
cronjobs Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
data
…
selenium Bug 24801: (follow-up) Display all the libraries - Selenium fix 2020-04-08 08:16:13 +01:00
www Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
00-strict.t
…
01-test_dbic.t
…
Accounts.t Bug 24818: (RM follow-up) Update tests for DATE -> TIMESTAMP change 2020-03-19 13:05:58 +00:00
Acquisition.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Amazon.t
…
ArticleRequests.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
AudioAlerts.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Auth.t
…
Auth_with_cas.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Auth_with_ldap.t Bug 20443: Remove UpdateBorrowerAttribute and SetBorrowerAttributes 2020-03-23 13:44:16 +00:00
AuthorisedValues.t
…
AuthoritiesMarc.t
…
BackgroundJob.t Bug 24760: (follow-up) Add a neighboring test messsage 2020-03-06 14:58:47 +00:00
Barcodes.t
…
Barcodes_ValueBuilder.t
…
Biblio.t Bug 21901: Add FK on subscription and serial tables 2020-04-17 09:39:00 +01:00
Bookseller.t Bug 18177: remove aqbooksellers.currency 2020-03-27 12:15:55 +00:00
Breeding.t Bug 24052: Fix Koha/XSLT/Base.t 2020-03-24 10:42:23 +00:00
Budgets.t
…
Cache.t
…
Calendar.t Bug 23974: Add test descriptions 2020-01-10 08:23:50 +00:00
Charset.t
…
Circulation.t Bug 24620: Fix test, remove replaced code, use dt_from_string 2020-04-14 17:24:41 +01:00
Clubs.t
…
ColumnsSettings.t
…
Context.t
…
Contract.t
…
CourseReserves.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
DecreaseLoanHighHolds.t Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Filter_MARC_ViewPolicy.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Fines.t Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules 2020-02-04 09:56:24 +00:00
FrameworkPlugin.t
…
Heading.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Heading_MARC21.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Hold.t Bug 21684: Fix Hold.t 2020-01-07 16:33:04 +00:00
Holds.t Bug 23463: Fix tests 2020-03-23 09:26:34 +00:00
HoldsQueue.t Bug 14711: Change prototype for AddReserve - pass a hashref 2020-02-11 14:32:47 +00:00
Holidays.t Bug 19475: Clear the caches at the end of the tests 2020-04-03 14:26:33 +01:00
ILSDI_Services.t Bug 20443: (follow-up) Move GetBorrowerAttributes to Koha::Patron - ILSDI 2020-03-23 13:49:22 +00:00
Illcomments.t
…
Illrequestattributes.t
…
Illrequests.t Bug 22001: Make the DBD error regex less strict 2020-03-31 17:46:21 +01:00
ImportBatch.t Bug 20415: Remove UseKohaPlugins system preference 2020-03-26 11:42:02 +00:00
ImportExportFramework.t
…
Installer.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Items.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Koha.t Bug 22302: Unit tests 2020-02-05 12:35:24 +00:00
Koha_Authority.t
…
Koha_Database.t
…
Koha_Elasticsearch.t
…
Koha_ExternalContent_OverDrive.t
…
Koha_ExternalContent_RecordedBooks.t
…
Koha_Misc_Files.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Languages.t
…
Letters.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
LibraryGroups.t Bug 22284: New methods in Koha::Library::Groups and Koha::Library 2020-01-03 12:58:03 +00:00
Linker_Default.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Linker_FirstMatch.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Log.t Bug 21190: Add tests for authentication success and failure 2020-04-14 16:13:39 +01:00
MarcModificationTemplates.t Bug 24900: Checks in MARC mod templates for when from field does not equal conditional field 2020-04-03 14:26:31 +01:00
Members.t
…
MungeMarcPrice.t
…
NewsChannels.t
…
Overdues.t Bug 24408: Do not compare floats with precision in tests 2020-01-13 13:42:45 +00:00
Passwordrecovery.t Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
PatronLists.t
…
Patroncards.t
…
Patrons.t
…
Record.t
…
RecordProcessor_EmbedSeeFromHeadings.t
…
RefundLostItemFeeRule.t Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules 2020-02-04 09:56:24 +00:00
Reports.t
…
Reserves.t Bug 24468: Remove unused C4::Reserves::_get_itype subroutine 2020-03-24 10:57:13 +00:00
RotatingCollections.t Bug 23463: Replace AddItem calls with Koha::Item->store 2020-03-23 09:26:26 +00:00
Search.t Bug 24735: Remove more code from tests 2020-03-02 11:13:11 +00:00
Serials.t Bug 21901: (RM follow-up) Use TestBuilder to fix tests 2020-04-17 13:37:33 +01:00
Serials_2.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Service.t
…
ShelfBrowser.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Sitemapper.t Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Stats.t
…
StockRotationItems.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationRotas.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationStages.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SuggestionEngine_ExplodedTerms.t
…
Suggestions.t Bug 22778: Add unit test 2020-04-14 08:19:34 +01:00
Tags.t
…
Templates.t
…
TestBuilder.t Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules 2020-02-04 09:56:24 +00:00
Upload.t Bug 21684: Fix UploadedFile[s]->delete 2020-01-07 16:32:53 +00:00
UsageStats.t Bug 25147: (RM follow-up) Update pref references. 2020-04-17 09:03:47 +01:00
Virtualshelves.t Bug 21684: Adjust some tests 2020-01-03 10:58:51 +00:00
XISBN.t Bug 23274: Mock simple_search_compat to cover both search engines 2020-01-10 10:48:53 +00:00
XSLT.t Bug 23463: Fix XSLT.t 2020-03-23 09:26:34 +00:00
check_kohastructure.t
…
check_sysprefs.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
db_structure.t
…
rollingloans.t
…
sysprefs.t Bug 22880: (follow-up) Loose ends: Better DB update, global inclusion, etc. 2020-02-24 13:24:25 +00:00
zebra_config.pl Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00