gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
36,354 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Blou 489cfb4b19 Bug 21270: "Not finding what you're looking for" displaying uselessly 
When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled.

Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user.

Just taunting them...

TEST:
0) Set IllModule to true, AnonSuggestions to false.
1) Without login, just to an OPAC search.  At the bottom will be a nice string laughing at your failed search
2) Apply the patch.
3) Problem at 1) is fixed.
4) Login to validate that ILL link now appear.
5) Modify combination of IllModule and AnonSuggestions to validate links appearing.

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
 		2019-12-31 17:32:38 +00:00
C4 Bug 24175: Take advantage of Koha::Item->holds 2019-12-23 15:37:24 +00:00
Koha Bug 24191: Make objects.search pass to_model to dbic_merge_sorting 2019-12-20 15:46:12 +00:00
OpenILS
…
acqui Bug 23721: Use basketgroup's name to name the CSV export file 2019-11-21 11:33:49 +00:00
admin Bug 24170: Fix sysprefs search result order 2019-12-19 22:10:33 +00:00
api/v1 Bug 23859: Make POST add the Location header on cities endpoint 2019-11-01 08:48:18 +00:00
authorities Bug 19994: Used Modern::Perl in Authorities perl scripts 2019-01-28 14:58:23 +00:00
basket Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
catalogue Bug 20948: Simplify existing code 2019-12-31 17:01:36 +00:00
cataloguing Bug 23851: Add the homebranch prefix to the barcode when adding multiple copies of an items 2019-11-08 12:56:20 +00:00
circ Bug 24106: In returns.pl, don't search for item if no barcode is provided 2019-12-19 22:06:59 +00:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 21003: Removed warning and changed wording on add_items-step2.tt 2019-03-23 09:51:36 +00:00
debian Bug 22857: (QA follow-up) Cosmetic changes: typo, whitespace 2019-11-08 12:53:55 +00:00
docs Corrections to teams for 20.05 cycle 2019-11-29 12:10:34 +00:00
errors Bug 23329: Move error page to its own subroutine 2019-11-27 11:30:19 +00:00
etc Bug 22857: (QA follow-up) Cosmetic changes: typo, whitespace 2019-11-08 12:53:55 +00:00
ill Bug 21460: (follow-up) Fix bugs found in QA 2019-04-25 10:46:56 +00:00
installer Increment version for 19.11.01 release 2019-12-23 20:04:35 +00:00
koha-tmpl Bug 21270: "Not finding what you're looking for" displaying uselessly 2019-12-31 17:32:38 +00:00
labels Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
members Bug 24113: guarantor info lost when a duplicate is found 2019-11-27 07:51:04 +00:00
misc Update release notes for 19.11.01 release 2019-12-23 20:14:56 +00:00
offline_circ Bug 22600: Add 'interface' to accountlines 2019-04-10 19:43:11 +00:00
opac Bug 24243: Do not explode if invalid metadata when searching catalogue 2019-12-23 15:36:39 +00:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins Bug 21073: (QA follow-up) Avoid unnecessary unless/else construct 2019-06-18 17:30:44 +01:00
reports Bug 24177: (QA follow-up) Fix warning 2019-12-19 21:39:58 +00:00
reserve Bug 24168: (bug 23116 follow-up) AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold 2019-12-10 19:52:20 +00:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 23435: Add multiple copies of an item when receiving in serials 2019-10-17 14:59:40 +01:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel
…
suggestion Bug 23854: Fix failure on dates when editing a suggestion 2019-11-13 17:16:24 +00:00
svc Bug 23427: Simplify sort logic 2019-11-07 13:25:10 +00:00
t Bug 24175: Simplify tests 2019-12-23 15:37:36 +00:00
tags Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
tmp/modified_authorities
…
tools Bug 23800: (QA follow-up) Remove useless line 2019-12-20 16:18:43 +00:00
virtualshelves Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig
…
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Increment version for 19.11.01 release 2019-12-23 20:04:35 +00:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 23834: (RM follow-up) Add new file to Makefile.PL 2019-11-04 10:10:04 +00:00
README
…
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 23655: Restore debian Jessie support 2019-10-26 12:07:49 +01:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display 2019-02-04 14:13:35 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 21907: Fix article requests count for non-superlibrarians 2019-02-04 14:50:40 +00:00
package.json Bug 23025: security vulnerability detected in fstream < 1.0.12 defined in yarn.lock 2019-11-27 11:30:17 +00:00
rewrite-config.PL Bug 17851: Add elasticsearch config to koha-conf.xml 2019-10-07 14:09:10 +01:00
yarn.lock Bug 23025: Update yarn.lock 2019-11-27 11:30:17 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo