Koha-clms/t/Koha
Julian Maurice 3302ad1461
Bug 24902: Join different mc- limits with AND (elasticsearch)
In the advanced search form, you can enable several limits using syspref
AdvancedSearchTypes (namely itemtypes, shelving locations, collections)
When used, the resulting query parts end up being joined with OR, even
if the field is different. That means that if you pick "Book" under
itemtypes tab, and "Fiction" under collection tab, it will search
"itype:BOOK OR ccode:FIC". It should be AND.

For instance, if you select:
    Itemtypes:
        ✓ Book
        ✓ DVD
    Location:
        ✓ Child
        ✓ Adult

it should search:
    itype:(Book OR DVD) AND location:(Child OR Adult)

Test plan:
0. Do not apply the patch yet
1. Enable elasticsearch
2. Set syspref AdvancedSearchTypes = 'itemtypes|loc|ccode'
3. Create a new itemtype and a new authorised value for categories LOC
   and CCODE
4. Create a biblio with the new itemtype, another biblio with the new
   location, another biblio with the new collection, and again another
   biblio with the new itemtype, location and collection
5. Verify that you can find these new biblio records using only the
   "advanced search types" in the advanced search form
6. In the advanced search form, pick all 3 limits (itemtype, location,
   collection) and verify that it returns the 4 records.
7. Apply the patch
8. Repeat step 6, it should now return only the biblio that satisfies
   all criteria
9. Verify that if you select more than one
   {itemtype|location|collection} it still returns results that
   satisfies any selected criteria
10. prove t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-03-24 08:00:26 +00:00
..
Authority Bug 14769: (QA follow-up) Remove global var $cached_indicators 2018-04-12 10:50:36 -03:00
I18N/po/xx_XX/LC_MESSAGES Bug 15395: Allow correct handling of plural translation 2018-11-08 15:55:50 +00:00
Middleware Bug 24739: Perform IPv6 tests only if Net::Netmask is correct version 2020-02-28 15:06:44 +00:00
Plugins Bug 23050: (QA follow-up) Add Koha::Plugins::Tab class 2019-11-05 08:13:59 +00:00
REST/Plugin Bug 24830: Add tests 2020-03-20 15:18:33 +00:00
SearchEngine Bug 24902: Join different mc- limits with AND (elasticsearch) 2020-03-24 08:00:26 +00:00
Util Bug 21560: Unit test for Koha::Util::OpenDocument 2019-03-15 12:02:46 +00:00
Config.t Bug 19760: Fix Config.t test 2017-12-22 14:04:52 -03:00
Exceptions.t Bug 23425: (QA follow-up) Keep it generic 2019-09-23 10:41:58 +01:00
I18N.t Bug 15395: Allow correct handling of plural translation 2018-11-08 15:55:50 +00:00
ItemType.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
RDF.t Bug 18586: Create module to mint RDF subject URIs 2018-08-09 12:11:16 +00:00
Script.t Bug 17845: Remove some missed references to branchprinter 2020-03-10 15:18:28 +00:00
Script_cron.t Bug 17845: Remove some missed references to branchprinter 2020-03-10 15:18:28 +00:00
Z3950responder.t Bug 13937: Fix issues found in QA 2019-10-08 14:39:50 +01:00