gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/Koha
History
Kyle M Hall 081539110b Bug 30541 - Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims 
Basically, if MarkLostItemsAsReturned is set for return claims, the code will crash while trying to pull the checkout so it can update the lost status of the item. This is because the code assumes there must be a checkout and never checks the old_checkouts table.

This bug appears to only exist in 21.05 at this time. It was fixed by a combination of bugs 29495 and 28588.

Test Plan:
1) Set MarkLostItemsAsReturned for return claims
2) Mark a checkout as claims returned
3) Verify the checkout is no longer on the patron record
4) Resolve the claim
5) Note the attempt "hangs" but refreshing the page shows it worked
6) Apply this patch, restart all the things!
7) Repeat steps 2-4
8) It works!

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Christine Lee <chlee@pascolibraries.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
 		2022-04-25 18:26:16 +00:00
..
Account Bug 29139: Add exceptions to relation accessors 2021-10-08 09:51:58 -04:00
Acquisition Bug 23971: Rename pref with AcquisitionLog 2021-04-23 11:58:49 +02:00
App Bug 20582: Reset CGI::PARAM_UTF8 to 1 before each CGI request 2020-10-06 14:34:17 +02:00
ArticleRequest Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Authority Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
BackgroundJob Bug 22417: Remove $dbh in Koha::BackgroundJob::* 2020-10-05 15:23:08 +02:00
Biblio Bug 26171: Show biblionumber in Koha::Exceptions::Metadata::Invalid 2021-01-04 13:29:50 +01:00
BiblioUtils Bug 24827: Specify UTF-8 as encoding in new_from_xml() 2020-03-16 14:45:47 +00:00
Cache Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Cash Bug 26274: (QA follow-up) Fix the order of summary groups 2021-02-17 16:21:22 +01:00
Charges Bug 23830: Adapt callers 2021-02-08 17:09:34 +01:00
Checkouts Bug 30541 - Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims 2022-04-25 18:26:16 +00:00
Club Bug 28272: Fix many things... 2021-05-11 09:04:13 +02:00
Config Bug 27154: Remove Koha::Util::SystemPreferences 2021-02-08 14:56:00 +01:00
Course Bug 23727: Editing course reserve items is broken 2020-04-17 13:45:56 +01:00
Edifact Bug 29670: Fix EDI for AcqCreateItem = 'placing on order' 2022-02-10 15:43:26 +00:00
Exceptions Bug 26312: (follow-up) Fix passing of exception messages 2021-04-16 11:48:31 +02:00
Exporter Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls 2019-07-15 11:28:08 +01:00
ExternalContent Bug 29686: Adapt Koha to use new fulfillment API for OverDrive 2022-02-21 15:00:52 +00:00
Filter/MARC Bug 29764: Fix incorrect EmbedItems RecordProcessor filter POD 2022-02-16 20:40:33 +00:00
Illrequest Bug 22818: Add generation and sending of notices 2020-11-11 08:35:10 +01:00
Indexer Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Item Bug 28520: Revert "Bug 12362: Reverse transfer upon cancellation" 2021-06-18 10:46:41 -04:00
Library Bug 29702: Fetch group libraries in a single call 2022-01-25 18:01:41 +00:00
List Bug 19524: Share patron lists between staff 2018-07-18 16:49:29 +00:00
MetadataRecord Bug 28268: Improve memory usage when indexing authorities in Elasticsearch 2021-05-17 12:34:33 +02:00
Middleware Bug 25950: Remove <client> in X-Forwarded-For from proxy tests 2020-07-20 12:37:29 +02:00
Misc
…
Notice Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Number Bug 26239: Do not format large negative numbers 2020-08-19 08:22:02 +02:00
OAI/Server Bug 29484: Make ListSets return noSetHierarchy when no sets defined 2021-12-17 19:53:46 +00:00
Object Bug 26555: (QA follow-up) Add a 'payload' attribute for carrying useful things 2020-10-15 14:50:06 +02:00
Objects Bug 23271: Prevent crash if called without parameters 2021-04-21 15:25:07 +02:00
Old Bug 28272: Fix note_seen, desk_id, cancellation_reason 2021-05-10 17:55:30 +02:00
Patron Bug 28581: Use from_email_address in the codebase 2021-07-09 09:05:48 -04:00
Patrons Bug 28616: (bug 28220 follow-up) Replace Data::Printer with simple warn 2021-06-23 09:29:49 -04:00
Plugins Bug 28228: Supress plugin related error message 2021-10-01 13:44:19 -04:00
REST Bug 22993: Handle default messaging preferences during patron creation from API 2022-03-24 17:44:48 +00:00
RecordProcessor
…
SMS Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SMTP Bug 29427: Make SMTP transport set debug mode correctly 2021-12-17 13:08:27 +00:00
Schema Bug 29495: Update relationship methods 2022-02-17 19:47:03 +00:00
SearchEngine Bug 27770: ES: Deprecated aggregation order key [_term] used, replaced by [_key] 2022-03-20 14:17:12 +00:00
Serial Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Sitemapper Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Subscription Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SuggestionEngine Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Tags Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Template/Plugin Bug 29807: Make Branches plugin handle empty pickup locations list 2022-02-16 17:44:04 +00:00
Util Bug 27461: Move hardcoded value to module 2021-10-08 07:57:55 -04:00
XSLT Bug 23290: (RM follow-up) Correction to copyright statement 2020-02-25 14:35:39 +00:00
Z3950Responder Bug 27673: Replace YAML with YAML::XS 2021-02-16 14:54:50 +01:00
pdfformat Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Account.pm Bug 29785: Rename Koha::Object->message with ->object_messages 2022-02-21 16:35:20 +00:00
ActionLog.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ActionLogs.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
AdditionalField.pm Bug 15774: Add POD and license notices 2019-03-07 20:37:05 +00:00
AdditionalFieldValue.pm Bug 22934: Add missing use statement 2019-05-23 14:43:16 +00:00
AdditionalFieldValues.pm Bug 15774: (follow-up) Address QA issues 2019-03-07 20:37:05 +00:00
AdditionalFields.pm Bug 15774: Add POD and license notices 2019-03-07 20:37:05 +00:00
AdvancedEditorMacro.pm Bug 17268: (follow-up) Fix translatability 2020-05-04 08:26:22 +01:00
AdvancedEditorMacros.pm Bug 17268: (follow-up) Fix translatability 2020-05-04 08:26:22 +01:00
ApiKey.pm Bug 28772: Make validate_secret return 1|0 2021-09-15 10:47:12 -04:00
ApiKeys.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ArticleRequest.pm Bug 28582: Fix hashref in a warning message 2021-07-02 09:07:56 -04:00
ArticleRequests.pm Bug 23384: Fix use statement order for ArticleRequest::Status 2020-03-06 15:00:25 +00:00
AudioAlert.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
AudioAlerts.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
AuthUtils.pm Bug 28772: Add a warning about hash_password usage in updatedatabase.pl 2021-09-15 10:47:11 -04:00
AuthorisedValue.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
AuthorisedValueCategories.pm Bug 17355: (QA follow-up) Fix used package name 2020-05-07 19:10:29 -03:00
AuthorisedValueCategory.pm Bug 17355: (QA follow-up) Fix used package name 2020-05-07 19:10:29 -03:00
AuthorisedValues.pm Bug 28554: In Koha::AuthorisedValues sort by description 2021-09-03 10:47:08 -04:00
Authorities.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Authority.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
BackgroundJob.pm Bug 30172: Enqueue the job even if rabbitmq is not reachable 2022-04-22 14:30:32 +00:00
BackgroundJobs.pm Bug 22417: Add missing POD and html filters 2020-10-05 15:23:08 +02:00
Biblio.pm Bug 29172: Make CustomCoverImagesURL compatible with control fields 2021-10-22 09:51:37 -04:00
BiblioFramework.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
BiblioFrameworks.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
BiblioUtils.pm Bug 29625: Fix var name in Koha::BiblioUtils get_all_biblios_iterator 2022-03-07 20:54:13 +00:00
Biblioitem.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Biblioitems.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Biblios.pm Bug 28273: Add Koha::Biblios->pickup_locations 2021-05-20 08:43:34 +02:00
Cache.pm Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-10 10:28:04 +02:00
Caches.pm Bug 17935: Adjust some POD lines, fix a few typos 2017-02-14 14:12:50 +00:00
Calendar.pm Bug 25802: Change addDate to addDuration 2021-01-22 14:59:27 +01:00
Checkout.pm Bug 28272: Fix note_seen, desk_id, cancellation_reason 2021-05-10 17:55:30 +02:00
Checkouts.pm Bug 23207: Automatic checkin items should never be overdue 2021-04-22 14:37:14 +02:00
CirculationRule.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
CirculationRules.pm Bug 28774: Don't store blank values for rental discount 2021-09-03 11:15:53 -04:00
Cities.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
City.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSortRule.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSortRules.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSource.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSources.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSplitRule.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSplitRules.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Club.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Clubs.pm Bug 29736: Restore searching 2022-01-25 17:53:41 +00:00
Config.pm Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-10 10:28:04 +02:00
Course.pm Bug 23727: Add Koha Object(s) related to course reserves 2020-04-17 13:45:51 +01:00
Courses.pm Bug 23727: Add Koha Object(s) related to course reserves 2020-04-17 13:45:51 +01:00
CoverImage.pm Bug 26145: Refactoring - Move C4::Images to Koha::CoverImages 2020-10-12 11:28:41 +02:00
CoverImages.pm Bug 26145: Refactoring - Move C4::Images to Koha::CoverImages 2020-10-12 11:28:41 +02:00
CsvProfile.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
CsvProfiles.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Database.pm Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-10 10:28:04 +02:00
DateUtils.pm Bug 25617: (bug 25133 follow-up) 12 PM is not 24 but 0 2020-05-29 11:30:02 +02:00
Desk.pm Bug 13881: Add desk management 2020-03-25 09:19:15 +00:00
Desks.pm Bug 13881: Add desk management 2020-03-25 09:19:15 +00:00
EDI.pm Bug 28960: Explicitly call get_column 2021-10-01 13:29:31 -04:00
Edifact.pm
…
Email.pm Bug 29330: Add Koha::Email->new_from_string 2021-11-22 13:15:26 -05:00
Exceptions.pm Bug 26518: Raise exception if the insert failed 2020-11-25 15:18:17 +01:00
ExternalContent.pm Bug 25527: Add logger to Koha::ExternalContent 2020-05-18 15:25:03 +01:00
FrameworkPlugin.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Hold.pm Bug 30072: Add missing hold actions plugin hooks 2022-03-07 19:56:30 +00:00
Holds.pm Bug 29786: Select only specific items for item level holds 2022-02-10 20:40:46 +00:00
I18N.pm Bug 25517: Look in all possible places for MO files 2020-05-23 08:31:21 +01:00
Illcomment.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Illcomments.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Illrequest.pm Bug 28932: Fix duplicate next_action & prev_action 2022-02-10 16:56:43 +00:00
Illrequestattribute.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Illrequestattributes.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Illrequests.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ImportBatch.pm Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages 2020-11-11 15:55:49 +01:00
ImportBatchProfile.pm Bug 23019: (follow-up) Fix other things 2020-11-11 15:55:49 +01:00
ImportBatchProfiles.pm Bug 23019: (follow-up) Fix other things 2020-11-11 15:55:49 +01:00
ImportBatches.pm Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages 2020-11-11 15:55:49 +01:00
Item.pm Bug 28520: Revert "Bug 12362: (QA follow-up) Fix ModItemTransfer cancellation handling" 2021-06-18 10:46:41 -04:00
ItemType.pm Bug 21946: Display parent-child relationship on smart-rules.pl 2020-08-13 10:13:14 +02:00
ItemTypes.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Items.pm Bug 3142: Handle biblio level item type 2022-02-10 17:15:24 +00:00
KeyboardShortcut.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
KeyboardShortcuts.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Libraries.pm Bug 24368: Remove Koha::Libraries->pickup_locations 2020-05-13 10:30:41 +01:00
Library.pm Bug 28581: Add 'from_email_address' method and use in Koha::Patron 2021-07-09 09:05:48 -04:00
Linktracker.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Localization.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Localizations.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Logger.pm Bug 25172: Remove _recheck_logfile 2020-04-22 13:43:58 +01:00
Manual.pm Bug 26944: Point help link to automatic item mod in manual 2020-11-18 12:03:03 +01:00
MarcSubfieldStructure.pm Bug 8976: (QA follow-up) Trivial POD fixes 2021-03-01 15:14:22 +01:00
MarcSubfieldStructures.pm Bug 8976: (QA follow-up) Trivial POD fixes 2021-03-01 15:14:22 +01:00
MessageAttribute.pm Bug 22818: (QA follow-up) Licence and POD fixes 2020-11-11 08:35:10 +01:00
MessageAttributes.pm Bug 22818: Fix TestBuilder.t 2020-11-11 18:03:17 +01:00
MetaSearcher.pm Bug 17515: Order Z3950 server by rank and preserve ordering 2020-11-02 11:03:09 +01:00
MetadataIterator.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
MetadataRecord.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
MoreUtils.pm Bug 19069: (follow-up) Remove perlcritic error 2017-10-27 14:58:16 -03:00
News.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
NewsItem.pm Bug 27714: Prevent Koha::NewsItem->author to explode 2021-02-23 13:12:56 +01:00
OAuth.pm Bug 28772: Make secret validation use the new method 2021-09-15 10:47:11 -04:00
OAuthAccessToken.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
OAuthAccessTokens.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Object.pm Bug 29785: Rename Koha::Object->message with ->object_messages 2022-02-21 16:35:20 +00:00
Objects.pm Bug 21549: Make filter_by_last_update returns a Koha::Objects-based object 2021-04-14 15:34:27 +02:00
Patron.pm Bug 28973: Improve Koha::Patron::can_see_patron_infos efficiency 2021-11-05 14:09:57 -04:00
Patrons.pm Bug 21549: Rename filter_by_dateexpiry with filter_by_expiration_date 2021-04-14 15:34:27 +02:00
Plugins.pm Bug 25549: Add error reporting to plugins-home 2020-10-22 10:04:30 +02:00
ProblemReport.pm Bug 4461: Update license statements 2020-04-06 11:18:39 +01:00
ProblemReports.pm Bug 4461: Update license statements 2020-04-06 11:18:39 +01:00
PseudonymizedTransaction.pm Bug 24151: Rename the config key with 'bcrypt_settings' 2020-07-20 15:17:42 +02:00
PseudonymizedTransactions.pm Bug 24151: (QA follow-up) Fix POD warnings from QA tools 2020-07-20 15:17:42 +02:00
Quote.pm Bug 27251: Rewrite QOTD with the Koha REST API 2021-01-29 09:03:45 +01:00
Quotes.pm Bug 16371: Fix inconsistencies with timestamp 2020-08-13 10:15:34 +02:00
RDF.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Rating.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Ratings.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
RecordProcessor.pm Bug 25008: Overload Koha::RecordProcessor->options to update filters 2020-04-14 08:31:37 +01:00
Report.pm Bug 24695: (QA follow-up) Fix POD 2021-04-12 15:27:50 +02:00
Reports.pm Bug 24695: Move to Koha::Report->is_sql_valid 2021-04-12 15:27:50 +02:00
Review.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Reviews.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Schema.pm
…
Script.pm Bug 23571: (QA follow-up) Remove perlcritic warning 2020-04-14 17:24:35 +01:00
SearchEngine.pm Bug 24000: Some modules do not return 1 2021-04-06 15:56:30 +02:00
SearchField.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SearchFields.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SearchMarcMap.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SearchMarcMaps.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Serial.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Serials.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SharedContent.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SimpleMARC.pm Bug 26894: Handle subfield 0 and delete empty fields 2021-01-12 16:02:35 +01:00
Sitemapper.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Statistic.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Statistics.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationItem.pm Bug 29809: Rename item relation accessor from itemnumber 2022-02-21 15:43:21 +00:00
StockRotationItems.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationRota.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationRotas.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationStage.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationStages.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Subscription.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Subscriptions.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Suggestion.pm Bug 17314: Implement /suggestions routes 2021-11-02 08:42:22 -04:00
SuggestionEngine.pm
…
Suggestions.pm Bug 29886: Add Koha::Suggestions->search_limited 2022-03-20 15:33:46 +00:00
Tag.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Tags.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Token.pm Bug 29812: Add missing use C4::Context in Koha::Token 2022-02-11 18:14:14 +00:00
UploadedFile.pm Bug 29156: File missing warning in Koha::UploadedFile for permanent files only 2022-02-21 14:43:21 +00:00
UploadedFiles.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Uploader.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelf.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelfcontent.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelfcontents.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelfshare.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelfshares.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelves.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Z3950Responder.pm Bug 25292: Flushing L1 on every Z3950 server search 2021-01-11 10:27:37 +01:00
Z3950Server.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Z3950Servers.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00