gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
42,806 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Nick Clemens 4755db8a1d Bug 28627: Calculate unitprice if not set 
On bug 23376 the developer was too clever by half. Instead of passing
values to the template we moved to simply passing the order object.

The calculations that populated the unitprice, however, were simply dropped.

This patch restores the behaviour of setting unitprice to the estimated cost
by default. We do this conditionally in the template

To test:
 1 - Create a basket and adding items to it. Set the 'Vendor price' to
    '20', do not add an 'Actual cost'
 2 - Close the basket
 3 - Select 'Receive shipment'
 4 - Set a value for vendor invoice
 5 - Receive the order you created
 6 - Observe 'Actual cost' is = 0.00
 7 - Apply patch
 8 - Refresh the order receival page, and confirm the 'Actual cost' =
    20.00
 9 - Cancel receipt - reopen basket - edit order - add an actual cost - close
10 - Receive the order again
11 - Confirm the actual price is used
12 - Repeat this whole plan, but ensure the vendor has a different value for
     Invoice prices: Include tax

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
 		2021-11-19 11:28:12 -05:00
C4 Bug 29264: SIP config allows use of non-branchcode institution ids causes workers to die without responding 2021-11-19 10:50:24 -05:00
Koha Bug 28870: Use Email::Address->parse 2021-11-15 07:21:49 -05:00
acqui Bug 29283: (QA follow-up) Remove code duplication 2021-11-05 08:37:06 -04:00
admin Bug 29298: Add 'Managing library' column to table settings for histsearch 2021-10-22 11:41:28 -04:00
api Bug 17314: OpenAPI spec 2021-11-02 08:42:22 -04:00
authorities Bug 28160: Values from 150$a aren't prefilled in z39.50 search form from an existing authority record 2021-05-10 15:52:53 +02:00
basket Bug 27268: (QA follow-up) Add Koha::Biblios to basket scripts 2021-03-09 17:20:47 +01:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
catalogue Bug 29284: (follow-up) Fix code that I copied from too 2021-10-29 09:37:53 -04:00
cataloguing Bug 29319: Use Business::ISBN to check ISBNs on addbooks.pl/cataloging search 2021-11-05 10:30:07 -04:00
circ Bug 28581: Use 'from_email_address' where appropriate 2021-07-09 09:05:48 -04:00
clubs Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
course_reserves Bug 25898: Fix new occurrences 2020-10-15 13:56:41 +02:00
debian Bug 28749: Restore the database name to Koha dumps 2021-08-06 07:46:44 -04:00
docs Bug 28904: Fix typo and display 2021-11-05 11:59:36 -04:00
errors Bug 26048: Use ErrorDocument middleware for Plack HTTP errors 2021-01-27 10:30:43 +01:00
etc Bug 28620: Remove trailing space when logging with log4perl 2021-07-30 10:32:28 -04:00
ill Bug 22818: Add generation and sending of notices 2020-11-11 08:35:10 +01:00
installer DBRev 21.05.05.004 2021-11-11 07:16:34 -05:00
koha-tmpl Bug 28627: Calculate unitprice if not set 2021-11-19 11:28:12 -05:00
labels Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
lib/CGI/Session/Serialize Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-18 11:23:42 -04:00
members Bug 28870: Move email address validation to a specific class method 2021-11-15 07:21:49 -05:00
misc Bug 28994: Fix logical errors with amount vs amoutoutstanding 2021-11-19 10:47:59 -05:00
offline_circ Bug 29255: Built-in offline circulation broken with SQL error 2021-11-19 10:51:05 -05:00
opac Bug 28870: Move email address validation to a specific class method 2021-11-15 07:21:49 -05:00
patron_lists Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
patroncards Bug 23271: Replace search_limited with search_with_library_limits 2021-04-21 15:25:07 +02:00
plugins Bug 24633: Add support for gitlab searching of plugins 2020-11-06 15:55:17 +01:00
pos Bug 28368: Add fallback language for anonymous payment receipts 2021-05-27 14:12:24 +02:00
reports Bug 29204: (QA follow-up) Fix variable name 2021-11-19 10:49:58 -05:00
reserve Bug 28748: Prepare pickup locations for overridden holds 2021-10-22 09:43:21 -04:00
reviews Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
rotating_collections Bug 26618: (QA follow-up) Fix unit test for TranferCollection change 2021-03-03 15:36:13 +01:00
serials Bug 23243: Adjust previous patch 2021-04-21 15:25:07 +02:00
services Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
skel
…
suggestion Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl 2021-10-01 13:26:38 -04:00
svc Bug 29056: Remove the demo functionality leftovers 2021-10-08 08:01:56 -04:00
t Bug 28870: non-FQDN addresses are valid 2021-11-15 07:21:50 -05:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
tmp/modified_authorities
…
tools Bug 28835: Fix ability to pass list contents to batch record modification 2021-08-13 07:37:06 -04:00
virtualshelves Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
xt Bug 28370: Rewrite tests 2021-05-25 09:28:18 +02:00
.editorconfig
…
.eslintrc.json
…
.gitignore
…
.htaccess
…
.mailmap Bug 28386: Disambiguate Tomas and Blou 2021-05-26 12:30:59 +02:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.scss-lint.yml
…
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm DBRev 21.05.05.003 2021-11-01 08:46:09 -04:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-18 11:23:42 -04:00
README
…
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
…
about.pl Bug 28870: Move email address validation to a specific class method 2021-11-15 07:21:49 -05:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 28870: Remove traces of Email::Valid 2021-11-15 07:21:49 -05:00
fix-perl-path.PL
…
gulpfile.js Bug 27072: Don't process staff interface CSS with rtlcss 2020-11-24 21:27:59 +01:00
help.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
koha_perl_deps.pl
…
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
mainpage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-18 11:23:42 -04:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo