Koha-clms/t/db_dependent
Tomás Cohen Arazi 4753b73285
Bug 40850: Add `Koha::ILL::Request->add_or_update_attributes`
Currently, ILL backends and plugins must implement custom logic to update
existing extended attributes on ILL requests, as the core extended_attributes()
method only supports adding new attributes and throws duplicate key errors when
attempting to update existing ones. This has led to code duplication across
multiple ILL plugins (Rapido, INNReach, SLNP) that all implement identical
add_or_update_attributes() methods, and forces the Standard backend to use
error-prone patterns when managing request metadata.

This patch adds add_or_update_attributes() method to Koha::ILL::Request that
provides a safe, efficient way to add new attributes or update existing ones
in a single operation, eliminating duplicate key errors and reducing code
duplication.

The method:
- Accepts a hashref of attribute type => value pairs
- Updates existing attributes only when values actually change
- Creates new attributes when they don't exist
- Skips undefined or empty values to avoid constraint errors
- Uses transactions for atomicity
- Returns the request object for method chaining

Test plan:
1. Apply patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/ILL/Request.t
=> SUCCESS: Tests pass! New method works correctly
3. Test adding new attributes works
4. Test updating existing attributes works
5. Test mixed add/update operations work
6. Test empty/undefined values are skipped
7. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-09-23 16:21:32 -06:00
..
Acquisition Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
Auth Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
AuthoritiesMarc Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Authority Bug 40119: Unit tests 2025-06-13 13:21:37 -06:00
Biblio Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Budgets Bug 38944: Manual changes 2025-03-13 17:25:04 +01:00
Circulation Bug 40708: Fix Circulation/Returns.t 2025-09-19 08:42:44 -06:00
CourseReserves Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Creators Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Exporter Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Holds Bug 40058: Adjust existing tests 2025-08-14 16:06:00 -06:00
HoldsQueue Bug 40377: Remove warnings from HoldsQueue/TransportCostOptimizations.t 2025-07-18 11:10:02 -06:00
Items Bug 23010: Add tests for AutomaticItemModificationByAge 2025-06-24 16:10:21 -06:00
Koha Bug 40850: Add `Koha::ILL::Request->add_or_update_attributes` 2025-09-23 16:21:32 -06:00
LDAP Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
Labels Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Letters Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Members Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
OAI Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
Patron Bug 20644: (QA follow-up) Remove duplicate variable 2025-08-20 13:43:06 -06:00
Record Bug 39834: Replace some tabs with spaces 2025-06-02 15:26:17 -06:00
Reports Bug 37784: Do not show forbidden columns in reports dictionary 2025-04-14 08:51:23 +02:00
Reserves Bug 40636: Regression tests 2025-09-05 08:02:31 -06:00
SIP Bug 39820: Add cancellation reason and clean up cancellation request 2025-09-05 08:02:29 -06:00
Search Bug 38944: Manual changes 2025-03-13 17:25:04 +01:00
Serials Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Template/Plugin Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Utils Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
api/v1 Bug 39190: (follow-up) Two QA fixes 2025-09-19 13:23:26 -06:00
cronjobs Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
data Bug 39345: (QA follow-up): Add exception handling for unsupported counter release 2025-09-05 15:10:31 -06:00
misc/translator Bug 40444: Add a test to ensure all Perl test files use Test::NoWarnings 2025-07-28 16:26:36 -06:00
mojo Bug 39980: Add Test::NoWarnings 2025-09-18 13:52:07 -06:00
selenium Bug 36095: Fix Selenium tests 2025-09-19 11:04:53 -06:00
www Bug 40379: Remove warnings from t/db_dependent/www 2025-07-21 14:01:30 -06:00
00-strict.t Bug 38944: Manual changes 2025-03-13 17:25:04 +01:00
Accounts.t Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Acquisition.t Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Amazon.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
ArticleRequests.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
AudioAlerts.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Auth.t Bug 40401: Implement Koha::Patron->is_anonymous 2025-07-21 14:01:31 -06:00
AuthUtils.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Auth_with_cas.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Auth_with_ldap.t Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Auth_with_shibboleth.t Bug 40317: Remove warnings from Auth_with_shibboleth.t output 2025-07-08 15:42:04 -06:00
AuthorisedValues.t Bug 40444: Add a test to ensure all Perl test files use Test::NoWarnings 2025-07-28 16:26:36 -06:00
AuthoritiesMarc.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
AuthoritiesMarc_GetTagsLabels.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Barcodes.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Barcodes_ValueBuilder.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Biblio.t Bug 40390: Remove warnings from t/db_dependent/Biblio.t 2025-07-18 11:09:52 -06:00
Biblio_holdsqueue.t Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
Breeding.t Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
Breeding_Auth.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Budgets.t Bug 40371: Remove warnings from Budgets.t output 2025-07-23 16:36:30 -06:00
Cache.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Calendar.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Charset.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Circulation.t Bug 40665: (RM follow-up) Adjust number of tests in t/db_dependent/Circulation.t 2025-09-05 15:10:38 -06:00
Circulation_holdsqueue.t Bug 40403: Remove warning from Circulation_holdsqueue.t 2025-07-18 11:09:48 -06:00
ClassSources.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Clubs.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Context.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Contract.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
CourseReserves.t Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
DecreaseLoanHighHolds.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Filter_MARC_ViewPolicy.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Fines.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
FrameworkPlugin.t Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Heading.t Bug 39503: Unit tests 2025-05-13 18:46:59 +02:00
Heading_MARC21.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Hold.t Bug 40671: Update method calls from revert_waiting to revert_found 2025-08-29 10:43:26 -06:00
Holds.t Bug 37651: (follow-up) Still skip future holds for renewals 2025-08-29 10:43:33 -06:00
HoldsQueue.t Bug 20747: (follow-up) Fix hold queue to work with LocalHoldPriority Group options 2025-05-15 08:34:20 +02:00
Holidays.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
ILSDI_Services.t Bug 37651: (follow-up) Add GetAvailability test case for future hold 2025-08-29 10:43:34 -06:00
ImportBatch.t Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
ImportExportFramework.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Installer.t Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Items.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Koha.t Bug 40277: Add a test 2025-07-07 10:20:27 -06:00
Koha_Database.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Koha_Elasticsearch.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Koha_ExternalContent_OverDrive.t Bug 38944: Manual changes 2025-03-13 17:25:04 +01:00
Koha_MetadataRecord_Authority.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Koha_Misc_Files.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Languages.t Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
Letters.t Bug 40410: Remove warning from Letters. 2025-07-18 11:09:59 -06:00
LibraryGroups.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Linker_Default.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Linker_FirstMatch.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Log.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
MarcModificationTemplates.t Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Matcher.t Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Members.t Bug 37418: (follow-up) Add unit tests for GetBorrowersToExpunge() 2025-04-25 08:46:52 +02:00
Message.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
MungeMarcPrice.t Bug 38944: Manual changes 2025-03-13 17:25:04 +01:00
Overdues.t Bug 40409: Remove warnings from t/db_dependent/Overdues.t 2025-07-18 11:10:00 -06:00
Passwordrecovery.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
PatronLists.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Patroncards.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Patrons.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Prices.t Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Record.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
RecordProcessor_EmbedSeeFromHeadings.t Bug 38944: Manual changes 2025-03-13 17:25:04 +01:00
Reports.t Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Reserves.t Bug 37651: (QA follow-up) Fix current_holds tests in Reserves.t 2025-08-29 10:43:35 -06:00
RotatingCollections.t Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Search.t Bug 37883: (follow-up) Add a test 2025-07-23 16:36:46 -06:00
Search_FacetSorting.t Bug 36947: (QA follow-up) Add skippable unit test for fi_FI locale 2025-07-11 15:26:58 -06:00
Serials.t Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
Serials_2.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Service.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
ShelfBrowser.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Sitemapper.t Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
SocialData.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
StockRotationItems.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
StockRotationRotas.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
StockRotationStages.t Bug 39717: Use numeric comparison for stock rotation stages 2025-04-24 19:53:15 +02:00
SuggestionEngine_ExplodedTerms.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Suggestions.t Bug 39883: (follow-up) Retrieve messages by letter_code 2025-08-15 09:52:30 -06:00
TablesSettings.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Tags.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Templates.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
TestBuilder.t Bug 39488: Use introspection in TestBuilder tests 2025-09-19 13:23:13 -06:00
Upload.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
UsageStats.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
Virtualshelves.t Bug 39427: (follow-up) Adjust number of tests 2025-08-01 13:22:39 -06:00
XISBN.t Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
XSLT.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
check_kohastructure.t Bug 38944: Fix tidiness t/db_dependent/check_kohastructure.t 2025-03-17 11:59:48 +01:00
check_sysprefs.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
db_structure.t Bug 38944: Manual changes 2025-03-13 17:25:04 +01:00
rollingloans.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
sysprefs.t Bug 38944: Add Test::NoWarnings to tests no producing warnings 2025-03-13 17:25:03 +01:00
yaml.t Bug 38944: Manual changes 2025-03-13 17:25:04 +01:00
zebra_config.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00