Koha-clms/t/db_dependent
Andrew Isherwood 7413de82f2 Bug 21063: Add "Columns settings" for ILL
This patch adds the "Columns settings" values for the illrequests table

Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Bug 21063: Add ability to show / hide columns

This patch adds the "Column visibility" functionality to the main ILL
request list table.

To test:
- Ensure ILL is enabled and you have some requests
- Apply patch
- From the "Koha administration screen, select "Configure columns"
- In the "Columns settings" page:
  => TEST: Ensure an "Interlibrary loans" category exists
  - Upon expanding the category:
  => TEST: Ensure a table is displayed showing columns
  => TEST: Ensure the "action" column has "Cannot be toggled"
  pre-selected
  => TEST: Change values for columns and ensure they're saved
- From the main staff menu, select "ILL requests"
- In the table:
  => TEST: Click the "Column visibility" button and ensure a modal
  containing all columns (except "Action")  is displayed
  => TEST: Select various columns and ensure they are shown and hidden

Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Bug 21063: (follow-up) Add user ID to column list

As originally specified in bug 20883, there is a requirement for some
users to be able to display the user ID (borrowernumber) in the UI.

This patch adds that ability to this bug, 20883 will be marked as a
duplicate of this one.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Bug 21063: (follow-up) Amendments for rebase

Modify to add the additional changes required now we're rebasing on top
of the dependency tree. Includes adding additional columns (and changing
indexes for search/filter where appropriate)

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Bug 21063: (follow-up) Add comments to column list

Since this bug is now dependent on Bug 18591 (Allow an arbitrary number
of comments on ILLs) we need to add the comments column to this table
and the list of selectable columns. This patch does this.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Bug 21063: (follow-up) Sanitize datatable data

This mitigates bug 22268 by sanitizing data prior to display using the
built in $.fn.dataTable.render.text() helper provided by Datatables.

The patch was added here, rather that in 22268 since this is the bug
that introduced the problem by increasing the number of fields that are
displayed in the table, some of which could contain user provided
malicious data

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-03-15 19:33:36 +00:00
..
Acquisition Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
Auth Bug 22483: Restore undef behaviour 2019-03-08 15:53:10 -03:00
Authority
…
Biblio
…
Circulation Bug 14591: (QA follow-up) Fix AddReturn call in Circulation/issue.t 2019-03-15 12:14:03 +00:00
CourseReserves
…
Creators
…
Exporter Bug 22155: Adapt uses of biblio_metadata.marcflavour to schema 2019-01-30 11:35:34 +00:00
Holds Bug 18925: Update new occurrences 2019-03-05 20:42:22 +00:00
Illrequest Bug 20750: Add unit tests 2019-03-15 19:07:08 +00:00
Items Bug 22219: Add tests 2019-03-15 12:36:11 +00:00
Koha Bug 21846: Add Koha::Tags::Approval(s) and Koha::Tags::Index(es) 2019-03-15 12:27:44 +00:00
LDAP
…
Labels Bug 21798: replace gimme_a_biblio with build_sample_biblio 2019-01-28 18:53:28 +00:00
Letters Bug 21999: Update Tests to reflect new return value of AddIssue 2019-01-11 13:05:52 +00:00
Members Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
OAI Bug 22155: Adapt uses of biblio_metadata.marcflavour to schema 2019-01-30 11:35:34 +00:00
Patron Bug 13515: Add unit tests 2019-02-15 13:12:22 +00:00
Record Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Reports
…
Reserves Bug 21765: Regression tests 2019-02-27 09:14:21 -05:00
SIP Bug 22043: (QA follow-up) Add parameter to control behavior 2019-03-15 12:10:46 +00:00
Search Bug 22048: Use set_password in tests 2019-01-25 20:15:31 +00:00
Serials Bug 17047: SQL reports management with Mana-KB 2019-01-23 14:39:26 +00:00
Template/Plugin Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
Utils Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
XSLT_Handler
…
api/v1 Bug 21063: Add "Columns settings" for ILL 2019-03-15 19:33:36 +00:00
data Bug 21749: (QA follow-up) Add more tests for ImportFramework 2018-11-15 12:47:36 +00:00
selenium Bug 18925: (QA follow-up) Fix basic_workflow.t 2019-03-05 20:42:22 +00:00
www
…
00-strict.t
…
01-test_dbic.t
…
Accounts.t Bug 21722: Tidy up tests and increase coverage 2019-03-04 19:08:25 +00:00
Acquisition.t Bug 15774: (follow-up) Address QA issues 2019-03-07 20:37:05 +00:00
Amazon.t
…
ArticleRequests.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
AudioAlerts.t
…
Auth.t Bug 22048: Use set_password in tests 2019-01-25 20:15:31 +00:00
Auth_with_cas.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Auth_with_ldap.t
…
AuthorisedValues.t
…
AuthoritiesMarc.t
…
BackgroundJob.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Barcodes.t
…
Barcodes_ValueBuilder.t
…
Biblio.t Bug 21826: Add tests 2019-01-25 20:13:39 +00:00
Bookseller.t Bug 21817: Fix 2 failing tests 2019-01-02 20:18:30 +00:00
Breeding.t
…
Budgets.t Bug 22296: Add Invoice Adjustments to GetBudgetHierarchy 2019-03-15 11:33:39 +00:00
Calendar.t
…
Charset.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Circulation.t Bug 14591: Update unit tests 2019-03-15 12:14:03 +00:00
Clubs.t
…
ColumnsSettings.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Context.t
…
Contract.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
CourseReserves.t
…
DecreaseLoanHighHolds.t Bug 22493: Clean up DecreaseLoanHighHolds.t 2019-03-15 12:17:59 +00:00
Filter_MARC_ViewPolicy.t
…
Fines.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
FrameworkPlugin.t
…
Heading.t Bug 21826: Move Heading tests to db_dependent since they require database connection 2019-01-25 20:13:39 +00:00
Heading_MARC21.t
…
Hold.t Bug 21478: (QA follow-up) Make sure tests don't fail randomly 2019-01-28 16:06:26 +00:00
Holds.t Bug 21798: replace gimme_a_biblio with build_sample_biblio 2019-01-28 18:53:28 +00:00
HoldsQueue.t
…
Holidays.t
…
ILSDI_Services.t Bug 21738: unit tests for HoldTitle 2019-02-08 20:44:07 +00:00
Illcomments.t
…
Illrequestattributes.t
…
Illrequests.t Bug 20750: Add unit tests 2019-03-15 19:07:08 +00:00
Images.t Bug 21987: (RM follow-up) Add text for simple tests 2019-03-15 12:22:32 +00:00
ImportBatch.t
…
ImportExportFramework.t Bug 21749: (QA follow-up) Add more tests for ImportFramework 2018-11-15 12:47:36 +00:00
Installer.t
…
Items.t Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
Items_DelItemCheck.t Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
KitchenSinkPlugin.kpz
…
Koha.t
…
Koha_Authority.t
…
Koha_Database.t
…
Koha_ExternalContent_OverDrive.t Bug 21567: Move Koha_ExternalContent_OverDrive.t to db_dependent 2018-11-16 13:04:57 +00:00
Koha_ExternalContent_RecordedBooks.t
…
Koha_Misc_Files.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Languages.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Letters.t Bug 21829: (QA follow-up) - Update the number of unit tests 2019-02-11 18:32:40 +00:00
LibraryGroups.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Linker_FirstMatch.t
…
Log.t
…
MarcModificationTemplates.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
Members.t Bug 22052: Unit tests 2019-01-08 14:02:42 +00:00
MungeMarcPrice.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
NewsChannels.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Overdues.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Passwordrecovery.t
…
PatronLists.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
Patrons.t
…
Plugins.t Bug 22084: Regression tests 2019-02-27 09:14:21 -05:00
QueryParser.t
…
Record.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
RecordProcessor_EmbedSeeFromHeadings.t
…
RefundLostItemFeeRule.t
…
Reports.t
…
Reserves.t Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules 2019-03-05 20:41:42 +00:00
RotatingCollections.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Search.t Bug 22416: (bug 22140 follow-up) Remove warnings in Search.t 2019-03-07 20:53:44 +00:00
Serials.t Bug 21798: replace gimme_a_biblio with build_sample_biblio 2019-01-28 18:53:28 +00:00
Serials_2.t
…
Service.t
…
ShelfBrowser.t
…
Sitemapper.t
…
Stats.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
StockRotationItems.t
…
StockRotationRotas.t
…
StockRotationStages.t
…
SuggestionEngine_ExplodedTerms.t
…
Suggestions.t Bug 21241: (follow-up) Syspref to control fallback to SMS when no email is defined 2019-01-28 11:42:31 +00:00
Tags.t Bug 21846: Simplify ugly double for loops 2019-03-15 12:27:44 +00:00
Templates.t
…
TestBuilder.t Bug 15774: (follow-up) Fix TestBuilder.t so it doesn't catch wrong classes 2019-03-09 05:41:45 -03:00
Upload.t
…
UsageStats.t
…
Virtualshelves.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
XISBN.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
XSLT_Handler.t
…
check_kohastructure.t
…
check_sysprefs.t
…
db_structure.t
…
default_search_class.pl
…
rollingloans.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
sysprefs.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
zebra_config.pl
…