Koha-clms/installer
Tomas Cohen Arazi 44c7010fc1 Bug 31274: Make sure OPACSuggestionAutoFill is handled as a boolean everywhere
The YAML preference definition defines it as a string ('yes' or 'no' the
possible values). And the opac-suggestions.tt template has one occurence
of the variable being compared to a string.

This patch does:
- fix the template
- fixes opac.pref for 0|1
- adds an atomicupdate that takes care of moving 'yes' and 'no' to their
  respective boolean values.

To test:
1. Change the syspref value to enable/disable
2. Check on the DB that the value is wrong:
   $ koha-mysql kohadev
   > SELECT value FROM systempreferences WHERE variable='OPACSuggestionAutoFill';
=> FAIL: It is either 'yes' or 'no' depending on what you choose.
3. Apply this patch
4. Run:
   $ updatedatabase
5. Repeat 2
=> SUCCESS: Values are now 0 or 1
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 1c0b7bf01f)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2022-09-29 16:03:53 +00:00
..
data/mysql Bug 31274: Make sure OPACSuggestionAutoFill is handled as a boolean everywhere 2022-09-29 16:03:53 +00:00
externalmodules.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
install.pl Bug 19821: Use database_test entry if exists 2021-10-25 11:27:40 +02:00
onboarding.pl Bug 29012: Add default values for blank circulation rules that weren't saved to the database 2022-09-29 14:27:30 +00:00