Go to file
Owen Leonard 43b0ef8f53
Bug 23328: Some check-in messages should be dismissable
There are several cases where the check-in process displays a modal
asking for confirmation. There are several cases where confirming or
dismissing the modal unnecessarily reloads the page. In cases where no
server-side action is necessary, the modal should be dismissed without
submitting a form.

To test, apply the patch and go to Circulation -> Check in

With AutomaticItemReturn enabled and AllowReturnToBranch set to "any
library,"

 - Check in an item which belongs at another library and is not already
   in-transit. In the confirmation modal which appears, clicking the
   "OK" button should close the modal without reloading the page.
 - Check in another item from anther branch. In the confirmation modal
   clicking the "Print slip" button should trigger a pop-up window for
   printing a slip but the modal should be dismissed without reloading
   the page.
 - Check in an item which is already in-transit to another branch. In
   the confirmation modal, clicking either the "OK" or "Print transfer
   slip" buttons should dismiss the modal without reloading the page.
   - Clicking the "Cancel transfer" button should work as before: The
     page reloads and the transfer is canceled.

With AutomaticItemReturn disabled,

 - Check in an item belonging to another library. The confirmation modal
   should ask you whether you want to "Transfer now?" Clicking "No"
   should dismiss the modal without reloading the page. The other
   options should reload the page and initiate the transfer.

With AllowReturnToBranch set to "only the library the item is from,"

 - Check in an item belonging to another library. You should see a
   "Cannot check in" modal. Clicking the "OK" button should close the
   modal without reloading the page.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2019-08-05 15:44:10 +01:00
C4 Bug 11529: (follow-up) Fix QA issues 2019-08-05 15:03:19 +01:00
Koha Bug 11529: DBRev 19.06.00.018 2019-08-05 15:03:20 +01:00
OpenILS
…
acqui Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
admin Bug 11529: Remove field mapping table and admin page 2019-08-05 15:03:18 +01:00
api/v1 Bug 17003: (follow-up) Update definitions according to voted RFC 2019-07-01 16:10:15 +01:00
authorities Bug 19994: Used Modern::Perl in Authorities perl scripts 2019-01-28 14:58:23 +00:00
basket Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
catalogue Bug 11529: (follow-up) Fix QA issues 2019-08-05 15:03:19 +01:00
cataloguing Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
circ Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
clubs
…
course_reserves Bug 21003: Removed warning and changed wording on add_items-step2.tt 2019-03-23 09:51:36 +00:00
debian Bug 23345: Rename include-indexes to exclude-indexes in koha-dump 2019-07-26 16:23:03 +01:00
docs Bug 22128: Add Rudolf Byker to contributors 2019-06-28 14:34:05 +01:00
errors
…
etc Bug 20292: Filter/censor info sent via SIP 2019-06-24 15:33:48 +01:00
ill Bug 21460: (follow-up) Fix bugs found in QA 2019-04-25 10:46:56 +00:00
installer Bug 11529: DBRev 19.06.00.018 2019-08-05 15:03:20 +01:00
koha-tmpl Bug 23328: Some check-in messages should be dismissable 2019-08-05 15:44:10 +01:00
labels Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
members Bug 23219: Cancel patrons holds when patron delete 2019-07-15 12:48:36 +01:00
misc Bug 11529: Simplify and optimize batchRebuildBiblioTables.pl 2019-08-05 15:03:17 +01:00
offline_circ Bug 22600: Add 'interface' to accountlines 2019-04-10 19:43:11 +00:00
opac Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
patron_lists
…
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins Bug 21073: (QA follow-up) Avoid unnecessary unless/else construct 2019-06-18 17:30:44 +01:00
reports Bug 22563: Update lost handling to use accountline.status 2019-07-15 11:28:01 +01:00
reserve Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
reviews
…
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
services
…
skel
…
suggestion Bug 22905: (QA follow-up) remove bad warn 2019-05-23 14:41:14 +00:00
svc Bug 11529: (follow-up) Fix QA issues 2019-08-05 15:03:19 +01:00
t Bug 11529: (follow-up) Fix QA issues 2019-08-05 15:03:19 +01:00
tags Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
tmp/modified_authorities
…
tools Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
virtualshelves Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig
…
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap
…
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL
…
Koha.pm Bug 11529: DBRev 19.06.00.018 2019-08-05 15:03:20 +01:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 21626: (QA follow-up) Embed teams.yaml for debian packages 2019-05-17 14:46:10 +00:00
README
…
README.md
…
README.robots
…
about.pl Bug 21626: (QA follow-up) Don't crash on missing teams file 2019-05-17 14:46:10 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL
…
gulpfile.js Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display 2019-02-04 14:13:35 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
koha_perl_deps.pl
…
kohaversion.pl
…
mainpage.pl Bug 21907: Fix article requests count for non-superlibrarians 2019-02-04 14:50:40 +00:00
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
rewrite-config.PL Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo