Go to file
Kyle M Hall 430f0ea6ba Bug 7940 - Placing a hold on a single item from the staff cart causes errors
This is caused by the javascript function placeHold() in basket.pl
The cause of this error is thus: when a staff member uses the cart
to place holds on multiple items at once, the cart redirects to
reserver/request.pl with the params 'biblionumbers' ( a string of
biblionumbers separated by slashes ( e.g. '5/4/3/' ) and the param
multi_hold with a value of 1.

When multi_hold is enabled, request.pl splits the string 'biblionumbers'
on those slashes and works on that list.

In placeHold(), when only one item is checked, the system passes
the param biblionumbers with a single biblionumber ( e.g. '5/' )
and does *not* pass the multi_hold param. This causes request.pl
to not parse the biblionumbers param, and thus reserve.pl has
no biblionumber to work on ( hence our error here ).

There are two options to resolve this:
A) Add the multi_hold param even for a single hold from the cart.
B) In the event of a single hold being placed from the cart,
   switch to the standard single hold url ( i.e. request.pl?biblionumber=234 )

This commit resolves the situation using option B, as it seems more
logical than using the multi-holds system for a single hold.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, works as advertised. Good catch!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-12 17:58:49 +02:00
C4 Bug 7756: FIX send email for late orders 2012-04-12 16:50:27 +02:00
Koha Bug 7562 Add strict & warnings to KohaDates Plugin 2012-04-03 18:11:46 +02:00
acqui Bug 7756: FIX send email for late orders 2012-04-12 16:50:27 +02:00
admin Bug 2505 : use warnings in smart_rules.pl 2012-04-10 11:30:20 +02:00
authorities Bug 7816 :[SIGNED-OFF] Encode output as utf-8 dont just flag it as such 2012-04-10 13:41:58 +02:00
basket Bug 6050 Make calls to GetItemsInfo consistent 2011-06-14 14:12:02 +12:00
catalogue Bug 4032 XSLT systempreference takes a path to file rather than YesNo 2012-03-29 16:58:55 +02:00
cataloguing Bug 7866: z39.50 search list ordered by rank 2012-04-03 18:10:57 +02:00
circ Bug 2505 : Switch on warnings in circ/returns.pl 2012-04-10 11:30:30 +02:00
debian Bug 7893 - add package dependencies 2012-04-10 11:12:23 +02:00
docs welcome gaetan, you're 179th ! 2012-03-20 15:58:50 +01:00
errors Housekeeping in errors scripts 2010-05-12 07:29:03 -04:00
etc Bug 7838 - Add sort-string-utf.chr for Ukrainian and Russian 2012-04-12 17:23:53 +02:00
install_misc Bug 7858 - Missing packages from install_misc/ubuntu.packages 2012-04-04 14:49:48 +02:00
installer missing \n in updatedatabase that causes some ugly display 2012-04-11 15:18:40 +02:00
koha-tmpl Bug 7940 - Placing a hold on a single item from the staff cart causes errors 2012-04-12 17:58:49 +02:00
labels Bug 7765 - labels/label-edit-layout.pl: plack $layout scoping 2012-03-22 18:01:15 +01:00
members Bug 6679 :[SIGNED-OFF] members dir now passes perlcritic tests 2012-04-10 13:44:53 +02:00
misc Bug 7613 follow up to fix perlcritic errors 2012-04-06 17:26:36 +02:00
offline_circ Bug 4976 - Status of item returned with process_koc.pl is empty in Intranet 2012-03-19 16:23:10 +01:00
opac Bug 7935: Introduce sys pref to control 'browse results' in OPAC 2012-04-10 15:26:37 +02:00
patroncards Bug 7318: Fixes category display in patroncards Patron Search results. 2012-02-27 18:01:00 +01:00
reports Bug 7829 - reports/ remove all exit(1) for plack 2012-03-28 16:25:24 +02:00
reserve Bug 7641: Suspend Reserves 2012-03-29 14:37:49 +02:00
reviews Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
rotating_collections Bug 6553 : Follow up adding license statements 2011-08-13 19:54:38 +12:00
selenium Adding selenium tests for filterMembers 2009-09-30 11:30:37 +02:00
serials Bug 5354 follow-up : dealing with a wrong regexp 2012-03-28 16:17:45 +02:00
services Bug 7178: Acquisition item creation improvement 2012-03-26 11:07:23 +02:00
skel installer: fixed chown invocation; added skel for KOHA_LOG_DIR 2007-12-17 09:13:53 -06:00
sms Bug 2505 - Add commented use warnings where missing in the sms/ directory 2010-04-21 20:25:08 +12:00
suggestion Bug 7871: prevents crash when suggestion linked to erased budget 2012-04-10 13:41:16 +02:00
svc bug_7613: OCLC Connexion gateway 2012-04-06 17:26:20 +02:00
t members now passes perlcritic, but not misc. removing testing of misc 2012-04-10 18:03:55 +02:00
tags Bug 6933 follow-up, perltyding new script list.pl 2012-02-02 10:17:43 +01:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities changing DO_NOT_REMOVE to README.txt 2007-10-21 19:14:41 -05:00
tools bug_7613: OCLC Connexion gateway 2012-04-06 17:26:20 +02:00
virtualshelves Bug 7860 - /virtualshelves/addbybiblionumber.pl plack scoping 2012-04-04 11:18:52 +02:00
xt Merge remote-tracking branch 'origin/new/bug_5327' 2012-02-15 13:55:48 +01:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap 7439 Mailmap for master 2012-01-27 12:27:58 +01:00
INSTALL Updating main INSTALL instructions 2011-10-22 09:04:19 +13:00
INSTALL.debian Updating distro specific install files 2011-10-22 09:12:15 +13:00
INSTALL.fedora7 Bug 7532 - remove dependency on Date::ICal 2012-02-17 11:49:05 +01:00
INSTALL.opensuse Bug 7356 - Fix various typos and mis-spellings 2012-01-13 11:51:26 +01:00
INSTALL.ubuntu Bug 7858 - Missing packages from install_misc/ubuntu.packages 2012-04-04 14:49:48 +02:00
INSTALL.ubuntu.lucid Updating distro specific install files 2011-10-22 09:12:15 +13:00
LICENSE Update LICENSE with a fresh copy from upstream. This updates the FSF address, and refers to the LGPL with its current name, and changes a few other minor things of the typographical sort. No semantic changes. 2010-03-16 20:17:48 -04:00
MANIFEST.SKIP Bug Fixing : 3334 2009-06-19 06:33:34 -05:00
Makefile.PL Bug 7698: Add CHR/ICU Zebra tokenization choice to installation 2012-03-13 16:08:04 +01:00
README updated links in README 2010-05-24 08:14:16 -04:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 7164 follow-up history.txt and perlcritic compliance 2011-12-14 15:10:28 +01:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl Bug 7038 Contextual help is always in English 2011-10-18 16:01:25 +13:00
fix-perl-path.PL installer: improvements to fix-path-perl.PL on Win32 2007-12-20 19:20:12 -06:00
help.pl Bug 6628 : Stopping a potential vulnerability 2011-11-28 10:05:58 +01:00
install-CPAN.pl Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00
koha_perl_deps.pl Bug 6914 - fixes for the color option of koha_perl_deps.pl 2011-12-03 07:47:38 +01:00
kohaversion.pl Bug 7935 follow-up: DBRev number 2012-04-10 15:26:55 +02:00
mainpage.pl Bug 6875 cleaning mainpage.pl 2012-02-15 14:58:31 +01:00
rewrite-config.PL Bug 7698: Add CHR/ICU Zebra tokenization choice to installation 2012-03-13 16:08:04 +01:00

README

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 2 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/