Koha-clms/installer/data/mysql
Julian Maurice b8a1515ad3 Bug 21395: Make perlcritic happy
This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes
almost all perlcrictic violations according to this .perlcriticrc
The remaining violations are silenced out by appending a '## no critic'
to the offending lines. They can still be seen by using the --force
option of perlcritic
This patch also modify t/00-testcritic.t to check all Perl files using
the new .perlcriticrc.
I'm not sure if this test script is still useful as it is now equivalent
to `perlcritic --quiet .` and it looks like it is much slower
(approximatively 5 times slower on my machine)

Test plan:
1. Run `perlcritic --quiet .` from the root directory. It should output
   nothing
2. Run `perlcritic --quiet --force .`. It should output 7 errors (6
   StringyEval, 1 BarewordFileHandles)
3. Run `TEST_QA=1 prove t/00-testcritic.t`
4. Read the patch. Check that all changes make sense and do not
   introduce undesired behaviour

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit b168f4a2e9)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2020-07-13 16:44:43 +00:00
..
atomicupdate Bug 25232: DBRev 20.05.01.002 2020-07-13 15:44:14 +00:00
de-DE Bug 23787: (follow-up) Format due date as due date 2020-05-12 10:58:06 +01:00
en Bug 23787: (follow-up) Format due date as due date 2020-05-12 10:58:06 +01:00
fr-CA Bug 23787: (follow-up) Format due date as due date 2020-05-12 10:58:06 +01:00
fr-FR Bug 23787: (follow-up) Format due date as due date 2020-05-12 10:58:06 +01:00
it-IT Bug 23787: (follow-up) Format due date as due date 2020-05-12 10:58:06 +01:00
mandatory Bug 17355: DB changes - set is_system for categories 2020-05-04 07:57:21 +01:00
nb-NO Bug 23787: (follow-up) Format due date as due date 2020-05-12 10:58:06 +01:00
pl-PL Bug 23787: (follow-up) Format due date as due date 2020-05-12 10:58:06 +01:00
ru-RU Bug 23787: (follow-up) Format due date as due date 2020-05-12 10:58:06 +01:00
uk-UA Bug 23787: (follow-up) Format due date as due date 2020-05-12 10:58:06 +01:00
account_credit_types.sql Bug 24081: Add credit_types, offset_types and permissions 2020-03-04 14:46:13 +00:00
account_debit_types.sql Bug 25010: Fix typo 'rewewal' in debit types 2020-04-03 14:26:35 +01:00
account_offset_types.sql Bug 24081: (QA follow-up) Fix small typo 2020-03-04 14:46:25 +00:00
audio_alerts.sql Bug 11431: (QA followup) Make audio alerts sql top level 2015-11-04 12:33:53 -03:00
backfill_statistics.pl Bug 13795: Remove occurences of unused columns in code 2019-04-18 10:05:51 +00:00
fix_unclosed_nonaccruing_fines_bug17135.pl Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
kohastructure.sql Bug 24986: Modify some borrowers DB fields to (TINY|MEDIUM)TEXT 2020-07-13 15:16:55 +00:00
labels_upgrade.pl Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
patroncards_upgrade.pl Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
sysprefs.sql Bug 25232: Add ability to skip trapping items with a given notforloan value 2020-07-13 15:36:28 +00:00
update22to30.pl Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
updatedatabase.pl Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
userflags.sql Bug 4461: Adding user flags for managing OPAC problem reports 2020-04-06 11:18:13 +01:00
userpermissions.sql Bug 17268: Add macros table and permissions 2020-05-04 08:25:07 +01:00