Koha-clms/opac
Julian Maurice b168f4a2e9 Bug 21395: Make perlcritic happy
This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes
almost all perlcrictic violations according to this .perlcriticrc
The remaining violations are silenced out by appending a '## no critic'
to the offending lines. They can still be seen by using the --force
option of perlcritic
This patch also modify t/00-testcritic.t to check all Perl files using
the new .perlcriticrc.
I'm not sure if this test script is still useful as it is now equivalent
to `perlcritic --quiet .` and it looks like it is much slower
(approximatively 5 times slower on my machine)

Test plan:
1. Run `perlcritic --quiet .` from the root directory. It should output
   nothing
2. Run `perlcritic --quiet --force .`. It should output 7 errors (6
   StringyEval, 1 BarewordFileHandles)
3. Run `TEST_QA=1 prove t/00-testcritic.t`
4. Read the patch. Check that all changes make sense and do not
   introduce undesired behaviour

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-06-29 12:37:02 +02:00
..
clubs
…
errors
…
external/overdrive
…
rss
…
sci
…
sco
…
svc
…
ilsdi.pl
…
maintenance.pl
…
oai.pl
…
opac-ISBDdetail.pl
…
opac-MARCdetail.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
opac-account-pay-paypal-return.pl
…
opac-account-pay-return.pl
…
opac-account-pay.pl
…
opac-account.pl
…
opac-addbybiblionumber.pl
…
opac-alert-subscribe.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
opac-article-request-cancel.pl
…
opac-authorities-home.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
opac-authoritiesdetail.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
opac-basket.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
opac-blocked.pl
…
opac-browse.pl
…
opac-browser.pl
…
opac-changelanguage.pl
…
opac-course-details.pl
…
opac-course-reserves.pl
…
opac-detail.pl Bug 25416: Let OPAC XSLTs know if the context is an anonymous session 2020-05-15 09:33:22 +01:00
opac-discharge.pl
…
opac-downloadcart.pl Bug 17842: Simplify the code 2020-06-12 10:32:35 +02:00
opac-downloadshelf.pl
…
opac-export.pl
…
opac-ics.pl
…
opac-idref.pl
…
opac-illrequests.pl
…
opac-image.pl
…
opac-imageviewer.pl
…
opac-issue-note.pl
…
opac-library.pl Bug 13388: Add library pages to the OPAC 2020-05-04 09:11:03 +01:00
opac-main.pl
…
opac-memberentry.pl Bug 25769: Patron self modification triggers change request for date of birth to null 2020-06-24 14:23:33 +02:00
opac-messaging.pl Bug 18911: Add the ability to set the preferred lang for notice at the OPAC 2020-06-24 15:15:41 +02:00
opac-modrequest-suspend.pl
…
opac-modrequest.pl
…
opac-mymessages.pl
…
opac-news-rss.pl
…
opac-overdrive-search.pl
…
opac-passwd.pl
…
opac-password-recovery.pl
…
opac-patron-consent.pl
…
opac-patron-image.pl
…
opac-privacy.pl
…
opac-ratings-ajax.pl
…
opac-ratings.pl
…
opac-readingrecord.pl
…
opac-recordedbooks-search.pl
…
opac-registration-verify.pl
…
opac-renew.pl
…
opac-reportproblem.pl
…
opac-request-article.pl
…
opac-reserve.pl
…
opac-restrictedpage.pl
…
opac-retrieve-file.pl
…
opac-review.pl Bug 25340: Pass biblio object to OPAC comments template 2020-05-04 08:53:37 +01:00
opac-routing-lists.pl
…
opac-search-history.pl
…
opac-search.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
opac-sendbasket.pl
…
opac-sendshelf.pl
…
opac-serial-issues.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
opac-shareshelf.pl
…
opac-shelves.pl Bug 25416: Let OPAC XSLTs know if the context is an anonymous session 2020-05-15 09:33:22 +01:00
opac-showmarc.pl
…
opac-showreviews.pl Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
opac-suggestions.pl
…
opac-tags.pl Bug 23276: Do not display tag if pref TagsEnabled is off 2020-06-15 10:32:29 +02:00
opac-tags_subject.pl
…
opac-topissues.pl
…
opac-user.pl Bug 25110: Allow patrons to add star ratings to titles on their summary/checkout page 2020-04-29 17:04:32 +01:00
tracklinks.pl
…
unapi
…