Koha-clms/koha-tmpl
David Gustafsson 9c07acd0cc Bug 23680: Incorrect conversion of Perl boolean to js
A Perl boolean value is on the server side converted
to a JS string (resulting in the values '0' or '1).
Since the string '0' is a truthy value in JS this
incorrectly triggers window.close() on the client
in many instances, for example when adding a new item.

To test:

1. Go to a bibliographic record in the staff client.
2. Expand the "New" menu and open "New item" in new tab.
3. The new tab will immediately close.
4. Apply the patch.
5. Perform steps 1-2 again.
6. The tab should now remain open.

Sponsored-by: Gothenburg University Library
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit b488527ebe)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2019-11-14 14:00:13 +01:00
..
intranet-tmpl Bug 23680: Incorrect conversion of Perl boolean to js 2019-11-14 14:00:13 +01:00
opac-tmpl Bug 22804: OPAC Overdrive JavaScript contains untranslatable strings 2019-10-08 09:28:16 +02:00