Koha-clms/C4
Marc Véron 002a2dcb1f Bug 15429 - sub _parseletter should not change referenced values
In C4/Letters.pm, sub _parseletter changes values that are passed by
reference. E.g. patron's expiry date can change from iso format to
syspref format, leading to strange behaviour in the calling routines
(see Bug 15423).

This patch makes sub _parseletter work on a copy of the referenced values.

(Submitted to get feedback - is this the way to go?)

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  Good solution to real time bomb.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2015-12-30 14:03:52 +00:00
..
AuthoritiesMarc
…
Barcodes
…
Bookseller
…
ClassSortRoutine
…
Creators Bug 14468: Remove warnings when creating Labels 2015-10-27 10:12:32 -03:00
External
…
Form
…
Heading
…
ILSDI
…
Installer Bug 15215: Remove warning due to misuse of UNIVERSAL 2015-11-20 11:16:49 -03:00
Labels Bug 14781: Creation of barcode types 2of5 not functional 2015-11-05 10:31:46 -03:00
Linker
…
Members
…
OAI
…
Output
…
Patroncards
…
Reports Bug 14982: Remove C4::Dates from guided report wizard and dictionary 2015-10-26 11:20:11 -03:00
SIP Bug 15215: Remove warning due to misuse of UNIVERSAL 2015-11-20 11:16:49 -03:00
Search Bug 10933: (follow-up) fix the previous patch to work with master 2015-10-27 11:03:03 -03:00
Serials
…
Utils Bug 15252 - Patron search on start with does not work with several terms 2015-12-30 13:05:54 +00:00
Accounts.pm Bug 14402: Make purge_zero_balance_fees() delete fees with NULL balance. 2015-11-09 14:58:51 -03:00
Acquisition.pm Bug 15036: Do not overwrite complete status in basket ops 2015-11-09 15:44:07 -03:00
Auth.pm Bug 15344: Remove unucessary call to GetMemberDetails 2015-12-30 11:53:18 +00:00
Auth_cas_servers.yaml.orig
…
Auth_with_cas.pm
…
Auth_with_ldap.pm
…
Auth_with_shibboleth.pm
…
AuthoritiesMarc.pm Bug 15130: useless unitialization warnings when updating authorities 2015-11-06 12:08:51 -03:00
BackgroundJob.pm
…
Barcodes.pm
…
Biblio.pm Bug 6657: Prevent biblionumber to be duplicated 2015-11-16 12:35:35 -03:00
Bookseller.pm
…
Boolean.pm
…
Branch.pm
…
Breeding.pm
…
Budgets.pm Bug 14388: Funds should be sorted by budget_code 2015-11-09 12:08:20 -03:00
Calendar.pm Bug 14954: Remove unused C4::Calendar::addDate subroutine 2015-11-17 23:44:57 -03:00
Category.pm
…
Charset.pm Bug 14078: (followup) converting from ISO5426 is not complete 2015-11-16 12:48:44 -03:00
Circulation.pm Bug 14101: Automatic renewals exactly on due date 2015-11-20 10:13:47 -03:00
ClassSortRoutine.pm
…
ClassSource.pm
…
Context.pm Bug 14778: Make sure the dbh returned is checked by DBIC 2015-10-23 12:01:17 -03:00
Contract.pm
…
CourseReserves.pm
…
Creators.pm
…
Csv.pm
…
Debug.pm Bug 14870: (followup) Remove mention of C4::Dates from C4/Debug.pm 2015-11-19 13:05:06 -03:00
HTML5Media.pm
…
Heading.pm
…
HoldsQueue.pm Bug 15062: Holds queue with Transport Cost Matrix will transfer item even if transfers disabled 2015-11-23 11:32:53 -03:00
Images.pm Bug 14778: Install fixtures for t/Images.t 2015-10-23 12:01:18 -03:00
ImportBatch.pm
…
ImportExportFramework.pm
…
InstallAuth.pm
…
Installer.pm Bug 11431: (QA followup) Make audio alerts sql top level 2015-11-04 12:33:53 -03:00
ItemCirculationAlertPreference.pm
…
ItemType.pm Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page 2015-11-05 09:58:02 -03:00
Items.pm Bug 11084 [QA Followup] - Suppress userenv warning 2015-12-29 19:32:20 +00:00
Koha.pm Bug 15093: Load/show saved item type group and hideinopac 2015-11-01 17:10:44 -03:00
Labels.pm
…
Languages.pm
…
Letters.pm Bug 15429 - sub _parseletter should not change referenced values 2015-12-30 14:03:52 +00:00
Linker.pm
…
Log.pm Bug 14870: (followup) Remove stray C4::Dates 2015-11-19 13:05:06 -03:00
MarcModificationTemplates.pm
…
Matcher.pm
…
Members.pm Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-30 11:53:18 +00:00
Message.pm
…
NewsChannels.pm Bug 14248: Optionally display authorship for news 2015-10-27 16:26:22 -03:00
Output.pm Bug 14544: Make the intranet side independent of Page.pm 2015-11-05 09:58:01 -03:00
Overdues.pm Bug 14985: Remove C4::Dates from files in folder C4/*.pm (part one) 2015-11-13 11:24:54 -03:00
Patroncards.pm
…
Print.pm
…
Ratings.pm
…
Record.pm
…
Reports.pm
…
Reserves.pm Bug 14515: Add biblioitems to messages in C4/Reserves.pm 2015-12-29 19:43:36 +00:00
Review.pm
…
Ris.pm Bug 14971: fix RIS export 2015-12-11 16:28:27 +00:00
RotatingCollections.pm Bug 15066: Make transfer rotating collection works under Plack 2015-11-05 09:50:09 -03:00
SMS.pm
…
Scheduler.pm
…
Scrubber.pm
…
Search.pm Bug 14985: Remove C4::Dates from files in folder C4/*.pm (part one) 2015-11-13 11:24:54 -03:00
Serials.pm Bug 14870: QA follow-up - fixing tiny typo 2015-11-19 13:05:06 -03:00
Service.pm Bug 11559: Supporting changes for Rancor 2015-10-27 12:16:05 -03:00
ShelfBrowser.pm
…
SocialData.pm
…
Stats.pm
…
Suggestions.pm Bug 15090: Fix date filter for Suggestions management 2015-11-02 11:35:02 -03:00
TTParser.pm
…
Tags.pm
…
Templates.pm
…
TmplToken.pm
…
TmplTokenType.pm
…
UsageStats.pm Bug 15101: Correct typo AllowPkiAuth vs AllowPKIAuth 2015-12-30 02:17:45 +00:00
XISBN.pm
…
XSLT.pm
…