Go to file
Pasi Kallinen 3c2cd21cc3 Bug 20110: Adding same user multiple times to same budget
In javascript, using indexOf to test if a number exists in an array
of strings doesn't work, and makes it possible to add the same user
multiple times into the same budget fund.
Make borrowernumber into string and compare that instead.

Test plan:

1) Go to Home -> Administration -> Budgets -> Funds -> Add Fund
2) Add a user to the fund
3) Try to add the same user again to the same fund. No error.
4) Apply patch
5) Do 1, 2, and 3 again. You should now get an error message
   saying the user is already in the list.

Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2018-02-05 09:47:33 -03:00
C4 Bug 20126: (follow-up bug 10455) Restore MARC field length calculation in ModBiblioMarc 2018-02-02 12:08:42 -03:00
Koha Bug 20060: Resolve uninitialized warn from Koha::Template::Plugin::Branches 2018-02-05 09:47:09 -03:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 19993: use Modern::Perl in Acquisition perl scripts 2018-02-05 09:45:47 -03:00
admin Bug 19992: use Modern::Perl in Admin perl scripts 2018-02-05 09:45:46 -03:00
api/v1 Bug 16213: (QA follow-up) Fix terminology 2018-01-30 14:21:28 -03:00
authorities Bug 20063: (bug 18811 follow-up) Allow hidden $9 subfields 2018-01-22 13:44:42 -03:00
basket Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
catalogue Bug 19995: use Modern::Perl in Catalogue perl scripts 2018-02-05 09:45:47 -03:00
cataloguing Bug 19996: (QA follow-up) Remove commented use warnings; 2018-02-05 09:45:47 -03:00
circ Bug 19997: use Modern::Perl in Circulation perl scripts 2018-02-05 09:45:48 -03:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 19230: Preventing warn when deleting course 2018-01-30 14:18:21 -03:00
debian Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
docs Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 17951: (follow-up) Make Makefile.PL handle template_cache_dir config 2017-12-22 13:15:39 -03:00
ill Bug 7317: Display all the libraries, not only one 2017-11-09 13:31:10 -03:00
installer Bug 12932: Check the Perl version even if all modules installed 2018-02-05 09:44:16 -03:00
koha-tmpl Bug 20110: Adding same user multiple times to same budget 2018-02-05 09:47:33 -03:00
labels Bug 19999: use Modern::Perl in label scripts 2018-02-05 09:45:48 -03:00
members Bug 20009: use Modern::Perl in Members perl scripts 2018-02-05 09:46:44 -03:00
misc Bug 19730: (follow-up bug 17196) Use biblio_metadata.timestamp in export_records.pl 2018-02-02 12:08:42 -03:00
offline_circ Bug 20018: use Modern::Perl in offline_circ scripts 2018-02-05 09:46:45 -03:00
opac Bug 19989: remove confusing variable 2018-02-05 09:45:46 -03:00
patron_lists Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
patroncards Bug 20010: use Modern::Perl in Patroncards perl scripts 2018-02-05 09:46:44 -03:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 20012: use Modern::Perl in Reports perl scripts 2018-02-05 09:46:44 -03:00
reserve Bug 20013: use Modern::Perl in Reserve perl script 2018-02-05 09:46:44 -03:00
reviews Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl 2017-12-21 11:07:37 -03:00
rotating_collections Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
serials Bug 20015: use Modern::Perl in Serials perl script 2018-02-05 09:46:45 -03:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
svc Bug 20016: use Modern::Perl in svc scripts 2018-02-05 09:46:45 -03:00
t Bug 20126: Add simple test for ModBiblioMarc 2018-02-02 12:08:42 -03:00
tags Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 20098: Inventory tool: CVS export: fix itemlost column 2018-02-05 09:47:09 -03:00
virtualshelves Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
xt Bug 20020: use Modern::Perl in XT scripts 2018-02-05 09:47:09 -03:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 17682: DBRev 17.12.00.006 2018-01-19 15:50:30 -03:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 17951: (follow-up) Make Makefile.PL handle template_cache_dir config 2017-12-22 13:15:39 -03:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 19542: (QA follow-up) Remove debug warn 2017-12-11 14:30:42 -03:00
changelanguage.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
edithelp.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 18432 : Follow up - Updating to use they/them 2017-04-21 10:56:43 -04:00
rewrite-config.PL Bug 17951: (follow-up) Make Makefile.PL handle template_cache_dir config 2017-12-22 13:15:39 -03:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo