Go to file
Oleg Vasylenko 37ad15eae7 Bug 17988 - Select2 prevents correct tag expand/minimize functionality
Overview:
Select2 (Bug 13501) introduced divs and inputs that broke some assumptions about the expected HTML structure.
Because of that, expanding fields to show all hidden subfields does not work properly.

Steps to Reproduce:
1. Open some book in the editor or create new (cataloguing/addbiblio.pl)
2. Try to minimize or expand fields, that have among subfields the following:
	— Thesaurus driven subfield → subfield with Select2
	— Hidden subfield.

Actual Results:
 — some fields become hidden, some not, and vice versa
 — in the console, you'll see «Uncaught TypeError: Cannot read property 'match' of null»

Expected Results:
 — all subfields should minimize/maximize completely

Additional Information:
This happens because Select2 adds some divs, that do not have ID property.
The following patch adds check for the needed attribute existance.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 317abac238)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
2017-02-14 20:39:49 +01:00
C4 Bug 16387: Fix default shortened loan period time 2017-02-07 22:21:15 +01:00
Koha Bug 17782 - Patron updated_on field should be set to current timestamp when borrower is deleted 2017-02-07 22:23:53 +01:00
OpenILS
…
acqui Bug 17681: Exiisting typos might thow some feees when recieved 2016-12-18 19:39:18 +00:00
admin Bug 17692: Remove 'CGI::param called in list context' warnings 2016-12-22 19:22:53 +00:00
api/v1 Bug 17086: Reword borrowers to patrons in Swagger tags for holds 2016-11-22 11:31:08 +00:00
authorities Bug 17118: (follow-up 15381) Fix regression when clearing a linked authority 2016-09-02 14:01:34 +00:00
basket Bug 17830: CSRF - Handle unicode characters in userid 2017-01-04 23:01:53 +01:00
catalogue Bug 16951: Replace some more 2016-12-22 19:26:08 +00:00
cataloguing Bug 17922: Use correct number of digits when replacing date placeholders 2017-02-07 22:18:39 +01:00
circ Bug 17940: (follow-up 14695) Fix - Mark holds as waiting when transfer is done 2017-02-14 20:33:19 +01:00
course_reserves Bug 15758: Koha::Libraries - Remove GetBranchesLoop 2016-09-08 14:36:02 +00:00
debian Bug 17871: (followup) Remove zebra::* from the packages templates 2017-02-07 22:14:04 +01:00
docs Bug 7143: [QA Follow-up] Handling tabs 2017-01-22 20:29:05 +01:00
errors Bug 15288: Error pages: Code duplication removal and better translatability 2016-01-27 05:57:34 +00:00
etc Bug 17871: Remove zebra::snippet to allow access to facets in YAZ 5.8.1+ 2017-02-07 22:13:51 +01:00
install_misc Bug 16770: Remove 2 other occurrences of libmemoize-memcached-perl 2016-06-24 14:05:56 +00:00
installer Increment version for 16.11.03 security release 2017-01-30 17:03:24 +01:00
koha-tmpl Bug 17988 - Select2 prevents correct tag expand/minimize functionality 2017-02-14 20:39:49 +01:00
labels Bug 17900: Fix possible SQL injection in patron cards template editing 2017-01-30 15:37:54 +01:00
members Bug 17905: FIX CSRF in member-flags 2017-01-30 15:59:09 +01:00
misc Bug 17731: Remove noxml option from rebuild_zebra.pl 2017-02-14 08:20:01 +01:00
offline_circ Bug 15902 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers 2016-09-27 13:53:23 +00:00
opac Bug 17134: Replace item types codes with category in facets (opac) 2017-02-14 20:38:07 +01:00
patron_lists Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
patroncards Bug 17900: Fix possible SQL injection in patron cards template editing 2017-01-30 15:37:54 +01:00
plugins Bug 16586: Koha Plugins: Limit results of GetPlugins by metadata 2016-09-09 12:13:39 +00:00
reports Bug 17931: Remove unused vars from reserves_stats 2017-01-22 20:03:16 +01:00
reserve Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
reviews Bug 15839: Koha::Reviews - Remove C4::Review residue 2016-09-09 10:31:00 +00:00
rotating_collections Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
serials Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories 2016-10-28 16:35:52 +00:00
services Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
skel
…
sms Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
suggestion Bug 17252 - Koha::AuthorisedValues - Remove GetAuthorisedValueByCode 2016-10-21 15:35:21 +00:00
svc Bug 17375: Search by dateofbirth - handle invalid dates 2016-10-27 13:18:32 +00:00
t Bug 17782: Fix tests 2017-02-07 22:24:20 +01:00
tags Bug 16154: CGI->multi_param - Assign a list 2016-04-26 23:16:43 +00:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 17830: CSRF - Handle unicode characters in userid 2017-01-04 23:01:53 +01:00
virtualshelves Bug 17901: Fix possible SQL injection in shelf editing 2017-01-30 15:40:38 +01:00
xt Bug 17469: Add missing sample notices fr-CA test 2017-01-22 20:17:42 +01:00
.editorconfig
…
.htaccess
…
.mailmap (RM followup) .mailmap updates 2015-05-22 17:02:21 -03:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Increment version for 16.11.03 security release 2017-01-30 17:03:24 +01:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 16952: Czech language definitions for sorting in Zebra 2016-10-28 15:33:00 +00:00
README
…
README.md Bug 15465 [QA Followup] - Update wording, switch logo, add links 2016-02-24 04:02:26 +00:00
README.robots
…
about.pl Bug 7533: Add a warning to the about page if template_cache_dir is not set 2017-02-07 08:04:02 +01:00
changelanguage.pl Bug 16776: Do not forget external language choice in language switcher 2016-08-10 13:51:33 +00:00
edithelp.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 16724: Fix link to the online documentation links 2016-06-24 12:00:42 +00:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl
…
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
rewrite-config.PL Bug 16222: (QA followup) Add /api dir for the API 2016-04-20 21:18:36 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-comminity.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo