gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/Koha
History
Petro Vashchuk 368fedd5c1 Bug 28316: screen unquoted semicolons and all followup colons 
Currently searches like: "book:", ":book" and "host-item:test:n"
cause internal server errors.

This patch adds additional regexes that remove the colons at the start
and end of the query, and another regex that screens all follow-up
colons that go after the first colon to avoid errors when searching for
"host-item:test:n".

To reproduce:
1) using ES, search for the book with title that contains
semicolon at the start or at the end of the line, separated with spaces,
this should cause internal server error.
2) try doing the same with something like "host-item:test:n", it should
result in error as well.
3) apply the patch.
4) repeat steps 1-2, ensure that it works now.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 5b4b14e493)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
 		2022-01-31 00:44:32 +01:00
..
Account Bug 28482: Refresh line from DB to get stored value 2021-06-21 14:14:06 +02:00
Acquisition Bug 26582: (QA follow-up) Rename closed => is_closed 2020-11-05 15:24:20 +01:00
App Bug 20582: Reset CGI::PARAM_UTF8 to 1 before each CGI request 2020-10-06 14:34:17 +02:00
ArticleRequest Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Authority Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
BackgroundJob Bug 22417: Remove $dbh in Koha::BackgroundJob::* 2020-10-05 15:23:08 +02:00
Biblio Bug 26171: Show biblionumber in Koha::Exceptions::Metadata::Invalid 2021-01-07 14:46:51 +01:00
BiblioUtils Bug 24827: Specify UTF-8 as encoding in new_from_xml() 2020-03-16 14:45:47 +00:00
Cache Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Cash Bug 26172: Replace _result[set] calls 2020-11-05 15:24:20 +01:00
Charges Bug 21443: Remove the dependency on finesCalendar 2020-03-24 11:09:16 +00:00
Checkouts Bug 27004: Prevent claim resolution to fail 2021-01-05 09:34:53 +01:00
Club Bug 27330: (follow-up) Cleanup missed on bug 23843 2021-02-25 09:57:05 +01:00
Config Bug 27154: Remove Koha::Util::SystemPreferences 2021-02-12 14:04:32 +01:00
Course Bug 23727: Editing course reserve items is broken 2020-04-17 13:45:56 +01:00
Edifact Bug 27708: Unify two item object creation blocks to be stored as hash 2021-11-12 13:15:24 -10:00
Exceptions Bug 26312: (follow-up) Fix passing of exception messages 2021-04-19 15:14:46 +02:00
Exporter Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls 2019-07-15 11:28:08 +01:00
ExternalContent Bug 25527: Add logger to Koha::ExternalContent 2020-05-18 15:25:03 +01:00
Filter/MARC Bug 25030: (QA follow-up) Add POD 2021-10-22 15:50:57 -10:00
Illrequest Bug 22818: Add generation and sending of notices 2020-11-11 08:35:10 +01:00
Indexer Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Item Bug 24000: Koha::Item::Search::Field does not return 1 2021-04-15 12:55:42 +02:00
Library Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
List
…
MetadataRecord Bug 28268: Improve memory usage when indexing authorities in Elasticsearch 2021-05-18 12:17:33 +02:00
Middleware Bug 25950: Remove <client> in X-Forwarded-For from proxy tests 2020-07-20 12:37:29 +02:00
Misc
…
Notice Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Number Bug 26239: Do not format large negative numbers 2020-08-19 08:22:02 +02:00
OAI/Server Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Object Bug 26555: (QA follow-up) Add a 'payload' attribute for carrying useful things 2020-10-15 14:50:06 +02:00
Objects Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Old Bug 23916: (QA follow-up) Adapt all the things to the new column and accessor names 2020-11-10 15:00:14 +01:00
Patron Bug 25946: borrowerRelationship can be empty 2021-04-07 11:42:20 +02:00
Patrons Bug 28293: (bug 20443 follow-up) Fix wrong key in Patrons::Import->generate_patron_attributes 2021-05-12 17:11:10 +02:00
Plugins Bug 26803: Fix PLUGIN_DIR when plugin_dirs is multivalued 2020-11-04 12:59:33 +01:00
REST Bug 29032: Pre-load ILL backends to speed up response 2021-10-08 16:14:27 -10:00
RecordProcessor
…
SMS Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SMTP Bug 26595: Remove password from the smtp_server API object 2020-10-14 15:53:38 +02:00
Schema Bug 29341: DBIC schema changes 2021-11-19 16:07:32 -10:00
SearchEngine Bug 28316: screen unquoted semicolons and all followup colons 2022-01-31 00:44:32 +01:00
Serial Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Sitemapper Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Subscription Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SuggestionEngine Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Tags Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Template/Plugin Bug 27120: Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' 2021-04-29 15:48:46 +02:00
Util Bug 27461: Move hardcoded value to module 2021-10-08 16:30:39 -10:00
XSLT Bug 23290: (RM follow-up) Correction to copyright statement 2020-02-25 14:35:39 +00:00
Z3950Responder Bug 27149: Don't strip itemnumber when adding item status via Z3950Responder 2021-01-14 17:29:56 +01:00
pdfformat Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Account.pm Bug 28156: Rename Koha::Account::Line->renewal with is_renewal 2021-04-22 16:39:06 +02:00
ActionLog.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ActionLogs.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
AdditionalField.pm
…
AdditionalFieldValue.pm
…
AdditionalFieldValues.pm
…
AdditionalFields.pm
…
AdvancedEditorMacro.pm Bug 17268: (follow-up) Fix translatability 2020-05-04 08:26:22 +01:00
AdvancedEditorMacros.pm Bug 17268: (follow-up) Fix translatability 2020-05-04 08:26:22 +01:00
ApiKey.pm Bug 28772: Make validate_secret return 1|0 2021-09-20 20:21:00 -10:00
ApiKeys.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ArticleRequest.pm Bug 28582: Fix hashref in a warning message 2021-07-09 16:49:17 -10:00
ArticleRequests.pm Bug 23384: Fix use statement order for ArticleRequest::Status 2020-03-06 15:00:25 +00:00
AudioAlert.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
AudioAlerts.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
AuthUtils.pm Bug 28772: Add a warning about hash_password usage in updatedatabase.pl 2021-09-20 20:21:00 -10:00
AuthorisedValue.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
AuthorisedValueCategories.pm Bug 17355: (QA follow-up) Fix used package name 2020-05-07 19:10:29 -03:00
AuthorisedValueCategory.pm Bug 17355: (QA follow-up) Fix used package name 2020-05-07 19:10:29 -03:00
AuthorisedValues.pm Bug 28554: In Koha::AuthorisedValues sort by description 2021-09-08 10:28:31 -10:00
Authorities.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Authority.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
BackgroundJob.pm Bug 26742: Remove die from connect 2021-03-08 16:46:26 +01:00
BackgroundJobs.pm Bug 22417: Add missing POD and html filters 2020-10-05 15:23:08 +02:00
Biblio.pm Bug 29172: Make CustomCoverImagesURL compatible with control fields 2021-10-22 15:40:03 -10:00
BiblioFramework.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
BiblioFrameworks.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
BiblioUtils.pm Bug 26180: Add descending option to rebuild_elasticsearch.pl 2020-11-04 12:59:33 +01:00
Biblioitem.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Biblioitems.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Biblios.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Cache.pm Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-12 16:32:32 +02:00
Caches.pm
…
Calendar.pm Bug 25723: (QA follow-up) Handle holiday and exception on same day 2020-07-20 17:45:31 +02:00
Checkout.pm Bug 25552: (QA follow-up) Improve claim_returned POD 2021-02-05 17:19:03 +01:00
Checkouts.pm Bug 24159: (QA follow-up) Make terminology consistent 2020-06-25 10:51:59 +02:00
CirculationRule.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
CirculationRules.pm Bug 28774: Don't store blank values for rental discount 2021-09-08 10:42:58 -10:00
Cities.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
City.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSortRule.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSortRules.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSource.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSources.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSplitRule.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ClassSplitRules.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Club.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Clubs.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Config.pm Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-12 16:32:32 +02:00
Course.pm Bug 23727: Add Koha Object(s) related to course reserves 2020-04-17 13:45:51 +01:00
Courses.pm Bug 23727: Add Koha Object(s) related to course reserves 2020-04-17 13:45:51 +01:00
CoverImage.pm Bug 26145: Refactoring - Move C4::Images to Koha::CoverImages 2020-10-12 11:28:41 +02:00
CoverImages.pm Bug 26145: Refactoring - Move C4::Images to Koha::CoverImages 2020-10-12 11:28:41 +02:00
CsvProfile.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
CsvProfiles.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Database.pm Bug 28276: Do not fetch config ($KOHA_CONF) from memcached 2021-05-12 16:32:32 +02:00
DateUtils.pm Bug 25617: (bug 25133 follow-up) 12 PM is not 24 but 0 2020-05-29 11:30:02 +02:00
Desk.pm Bug 13881: Add desk management 2020-03-25 09:19:15 +00:00
Desks.pm Bug 13881: Add desk management 2020-03-25 09:19:15 +00:00
EDI.pm Bug 28960: Explicitly call get_column 2021-10-06 10:01:31 -10:00
Edifact.pm
…
Email.pm Bug 29330: Add Koha::Email->new_from_string 2021-12-19 21:15:44 +01:00
Exceptions.pm Bug 26518: Raise exception if the insert failed 2020-11-25 15:18:17 +01:00
ExternalContent.pm Bug 25527: Add logger to Koha::ExternalContent 2020-05-18 15:25:03 +01:00
FrameworkPlugin.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Hold.pm Bug 27209: (follow-up) Add ->is_pickup_location_valid 2020-12-28 14:41:08 +01:00
Holds.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
I18N.pm Bug 25517: Look in all possible places for MO files 2020-05-23 08:31:21 +01:00
Illcomment.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Illcomments.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Illrequest.pm Bug 22818: (follow-up) Respond to feedback 2020-11-11 08:35:10 +01:00
Illrequestattribute.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Illrequestattributes.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Illrequests.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
ImportBatch.pm Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages 2020-11-11 15:55:49 +01:00
ImportBatchProfile.pm Bug 23019: (follow-up) Fix other things 2020-11-11 15:55:49 +01:00
ImportBatchProfiles.pm Bug 23019: (follow-up) Fix other things 2020-11-11 15:55:49 +01:00
ImportBatches.pm Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages 2020-11-11 15:55:49 +01:00
Item.pm Bug 27003: Item creation log must be done after the item is created 2020-12-04 16:50:05 +01:00
ItemType.pm Bug 21946: Display parent-child relationship on smart-rules.pl 2020-08-13 10:13:14 +02:00
ItemTypes.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Items.pm Bug 28286: Replace < 1 with <= 0 2021-05-12 16:41:57 +02:00
KeyboardShortcut.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
KeyboardShortcuts.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Libraries.pm Bug 24368: Remove Koha::Libraries->pickup_locations 2020-05-13 10:30:41 +01:00
Library.pm Bug 27071: (follow-up) Get rid of loop 2021-03-02 08:01:05 +01:00
Linktracker.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Localization.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Localizations.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Logger.pm Bug 25172: Remove _recheck_logfile 2020-04-22 13:43:58 +01:00
Manual.pm Bug 26944: Point help link to automatic item mod in manual 2020-11-18 12:03:03 +01:00
MarcSubfieldStructure.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
MarcSubfieldStructures.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
MessageAttribute.pm Bug 22818: (QA follow-up) Licence and POD fixes 2020-11-11 08:35:10 +01:00
MessageAttributes.pm Bug 22818: Fix TestBuilder.t 2020-11-11 18:03:17 +01:00
MetaSearcher.pm Bug 17515: Order Z3950 server by rank and preserve ordering 2020-11-02 11:03:09 +01:00
MetadataIterator.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
MetadataRecord.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
MoreUtils.pm
…
News.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
NewsItem.pm Bug 27714: Prevent Koha::NewsItem->author to explode 2021-02-25 10:38:46 +01:00
OAuth.pm Bug 28772: Make secret validation use the new method 2021-09-20 20:21:00 -10:00
OAuthAccessToken.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
OAuthAccessTokens.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Object.pm Bug 29157: Date and Datetime attributes cannot be set NULL 2021-10-22 15:45:59 -10:00
Objects.pm Bug 27021: Make chaining ->empty always return an empty resultset 2020-11-16 13:46:51 +01:00
Patron.pm Bug 28973: Improve Koha::Patron::can_see_patron_infos efficiency 2021-11-10 15:47:14 -10:00
Patrons.pm Bug 23916: (QA follow-up) Remove stray changes and fix typo 2020-11-10 15:00:14 +01:00
Plugins.pm Bug 25549: Add error reporting to plugins-home 2020-10-22 10:04:30 +02:00
ProblemReport.pm Bug 4461: Update license statements 2020-04-06 11:18:39 +01:00
ProblemReports.pm Bug 4461: Update license statements 2020-04-06 11:18:39 +01:00
PseudonymizedTransaction.pm Bug 24151: Rename the config key with 'bcrypt_settings' 2020-07-20 15:17:42 +02:00
PseudonymizedTransactions.pm Bug 24151: (QA follow-up) Fix POD warnings from QA tools 2020-07-20 15:17:42 +02:00
Quote.pm Bug 16371: Combine get_daily_quote and get_daily_quote_for_interface 2020-08-13 10:15:33 +02:00
Quotes.pm Bug 16371: Fix inconsistencies with timestamp 2020-08-13 10:15:34 +02:00
RDF.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Rating.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Ratings.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
RecordProcessor.pm Bug 25008: Overload Koha::RecordProcessor->options to update filters 2020-04-14 08:31:37 +01:00
Report.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Reports.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Review.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Reviews.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Schema.pm
…
Script.pm Bug 23571: (QA follow-up) Remove perlcritic warning 2020-04-14 17:24:35 +01:00
SearchEngine.pm Bug 24000: Some modules do not return 1 2021-04-15 12:55:42 +02:00
SearchField.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SearchFields.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SearchMarcMap.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SearchMarcMaps.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Serial.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Serials.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SharedContent.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SimpleMARC.pm Bug 26894: Handle subfield 0 and delete empty fields 2021-01-18 15:30:59 +01:00
Sitemapper.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Statistic.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Statistics.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationItem.pm Bug 23432: Replace 'die' with 'warn' 2020-10-26 00:04:18 +01:00
StockRotationItems.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationRota.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationRotas.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationStage.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationStages.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Subscription.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Subscriptions.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Suggestion.pm Bug 23591: Add some useful methods to Koha::Suggestions 2020-04-14 16:36:13 +01:00
SuggestionEngine.pm
…
Suggestions.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Tag.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Tags.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Token.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
UploadedFile.pm Bug 28123: Quote filename value in Content-Disposition header 2021-04-22 16:17:09 +02:00
UploadedFiles.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Uploader.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelf.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelfcontent.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelfcontents.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelfshare.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelfshares.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Virtualshelves.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Z3950Responder.pm Bug 25292: Flushing L1 on every Z3950 server search 2021-01-11 13:59:30 +01:00
Z3950Server.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Z3950Servers.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00