839f3492bc
The warnings look like: [2026/05/08 15:02:42] [32918] [WARN] Variable "@messages" is not available at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 698. [2026/05/08 15:02:42] [32918] [WARN] Variable "$op" is not available at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 704. Note in the fix, we are switching to the "our" keyword. When we declare things with "our", and we run this under plack, those variables and values persist across multiple requests! Due to this behavior we always need to reinitialize anything that uses "our" unless we specifically want that behavior ( like caching ). Test plan: 1) Send an EDI order, note the warnings in the logs 2) Apply this patch 3) Restart all the things! 4) Send another EDI order, note the warnings are gone! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> |
||
|---|---|---|
| .. | ||
| acqui-home.pl | ||
| addorder.pl | ||
| addorderiso2709.pl | ||
| ajax-getauthvaluedropbox.pl | ||
| basket.pl | ||
| basketgroup.pl | ||
| basketheader.pl | ||
| booksellers.pl | ||
| cancelorder.pl | ||
| check_budget_total.pl | ||
| check_uniqueness.pl | ||
| duplicate_orders.pl | ||
| edifactmsgs.pl | ||
| edimsg.pl | ||
| finishreceive.pl | ||
| histsearch.pl | ||
| invoice-files.pl | ||
| invoice.pl | ||
| invoices.pl | ||
| lateorders-export.pl | ||
| lateorders.pl | ||
| moddeliverydate.pl | ||
| modordernotes.pl | ||
| neworderempty.pl | ||
| newordersubscription.pl | ||
| newordersuggestion.pl | ||
| ordered.pl | ||
| orderreceive.pl | ||
| parcel.pl | ||
| parcels.pl | ||
| showorder.pl | ||
| spent.pl | ||
| transferorder.pl | ||
| uncertainprice.pl | ||
| vendor_issues.pl | ||
| vendors.pl | ||
| z3950_search.pl | ||