Kyle M Hall 07eefd07b6 Bug 23727: Editing course reserve items is broken ... Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com>		2020-05-19 23:28:10 +00:00
..
Acquisition	Bug 24294: (QA follow-up) Add rollback and 008 default test	2020-03-31 22:23:19 +00:00
Auth	…
Authority	Bug 22437: Add test case to Merge.t	2020-05-13 16:12:31 +00:00
Biblio	Bug 21708: Add a few tests in TransformHtmlToMarc.t	2020-04-03 21:25:53 +00:00
Circulation	Bug 24901: Fix tests for 19.11.x	2020-04-15 16:48:30 +00:00
CourseReserves	Bug 23727: Editing course reserve items is broken	2020-05-19 23:28:10 +00:00
Creators	…
Exporter	…
Holds	Bug 18928: Update new occurrences	2019-07-01 14:57:10 +01:00
Illrequest	…
Items	Bug 24030: Remove OldWay comparaison from GetItemsForInventory.t	2019-11-13 13:25:24 +00:00
Koha	Bug 25278: add clear_search_fields_cache method	2020-05-19 22:59:40 +00:00
LDAP	…
Labels	Bug 23900: Add tests	2020-04-03 20:56:13 +00:00
Letters	Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string	2020-05-07 17:17:12 +00:00
Members	…
OAI	Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string	2020-05-07 17:17:12 +00:00
Patron	Bug 24200: (follow-up) Try to fix random failures from Borrower_PrevCheckout.t	2020-04-03 18:38:26 +00:00
Record	Bug 24029: Remove "Truncated incorrect DOUBLE value: '01e'" from marcrecord2csv.t	2019-11-13 13:22:11 +00:00
Reports	Bug 24614: Fix Reports/Guided.t	2020-04-03 22:38:31 +00:00
Reserves	Bug 20567: Add tests	2020-01-31 23:18:41 +00:00
SIP	Bug 20816: [19.11.x] Add ability to define custom templated fields in SIP patron responses	2020-05-11 19:09:47 +00:00
Search	…
Serials	…
Template/Plugin	Bug 21824: Add KohaDates method 'output_preference' to make it easy to store formatted dates in TT variable	2019-11-01 08:52:09 +00:00
Utils	Bug 25046: Add test	2020-05-01 17:44:49 +00:00
XSLT_Handler	…
api/v1	Bug 24908: Unit tests	2020-05-08 22:37:27 +00:00
cronjobs	Bug 24268: Unit tests	2019-12-20 18:56:01 +00:00
data	Bug 11677: Use zebra not-onloan-count index for availability limit	2019-08-20 15:00:16 +01:00
selenium	Bug 24801: (follow-up) Display all the libraries - Selenium fix	2020-05-11 19:14:02 +00:00
www	Bug 24144: (bug 23836 follow-up) Fix regressions.t tests	2019-12-09 23:53:05 +00:00
00-strict.t	…
01-test_dbic.t	…
Accounts.t	Bug 24408: Do not compare floats with precision in tests	2020-01-31 23:10:19 +00:00
Acquisition.t	Bug 24277: Regression tests	2020-01-18 15:46:54 +00:00
Amazon.t	…
ArticleRequests.t	Bug 22273: Modify Koha::ArticleRequest->store to fill created_on	2020-04-01 20:46:07 +00:00
AudioAlerts.t	…
Auth.t	Bug 24145: (bug 22543 follow-up) Fix Auth.t	2019-12-10 19:37:06 +00:00
Auth_with_cas.t	…
Auth_with_ldap.t	…
AuthorisedValues.t	Bug 23272: Adapt controller and tests	2019-09-13 08:04:15 +01:00
AuthoritiesMarc.t	…
BackgroundJob.t	Bug 24760: (follow-up) Add a neighboring test messsage	2020-04-02 16:19:23 +00:00
Barcodes.t	…
Barcodes_ValueBuilder.t	…
Biblio.t	Bug 24094: Unit tests	2020-03-13 00:21:38 +00:00
Bookseller.t	…
Breeding.t	Bug 24267: (QA follow-up) Remove two calls, add transaction	2020-01-12 21:14:06 +00:00
Budgets.t	…
Cache.t	…
Calendar.t	Bug 23974: Add test descriptions	2020-01-30 23:19:34 +00:00
Charset.t	Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls	2019-07-15 11:28:08 +01:00
Circulation.t	Bug 25417: (QA follow-up) Add integration test for AddReturn	2020-05-13 19:18:59 +00:00
Clubs.t	…
ColumnsSettings.t	…
Context.t	…
Contract.t	…
CourseReserves.t	…
DecreaseLoanHighHolds.t	Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string	2020-05-07 17:17:12 +00:00
Filter_MARC_ViewPolicy.t	Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls	2019-07-15 11:28:08 +01:00
Fines.t	…
FrameworkPlugin.t	…
Heading.t	Bug 24269: Adjust C4::Heading to generate headings from auth tags	2020-03-13 00:39:55 +00:00
Heading_MARC21.t	Bug 24269: Adjust C4::Heading to generate headings from auth tags	2020-03-13 00:39:55 +00:00
Hold.t	…
Holds.t	Bug 25184: (follow-up) fix number of tests	2020-05-11 21:56:04 +00:00
HoldsQueue.t	Bug 23934: Unit test	2020-01-31 00:12:11 +00:00
Holidays.t	Bug 19475: Clear the caches at the end of the tests	2020-04-28 20:20:55 +00:00
ILSDI_Services.t	Bug 23805: Update accounttype references in tests	2019-10-24 17:35:19 +01:00
Illcomments.t	…
Illrequestattributes.t	…
Illrequests.t	Bug 22280: Add a unit test	2019-10-01 14:44:50 +01:00
ImportBatch.t	Bug 24827: Add a test	2020-04-03 18:14:18 +00:00
ImportExportFramework.t	…
Installer.t	…
Items.t	Bug 23081: Adjust tests	2020-05-08 21:17:41 +00:00
Items_DelItemCheck.t	…
Koha.t	Bug 22302: Unit tests	2020-02-11 00:12:38 +00:00
Koha_Authority.t	…
Koha_Database.t	…
Koha_Elasticsearch.t	…
Koha_ExternalContent_OverDrive.t	…
Koha_ExternalContent_RecordedBooks.t	…
Koha_Misc_Files.t	…
Languages.t	…
Letters.t	…
LibraryGroups.t	…
Linker_Default.t	Bug 24269: Adjust C4::Heading to generate headings from auth tags	2020-03-13 00:39:55 +00:00
Linker_FirstMatch.t	Bug 24269: Adjust C4::Heading to generate headings from auth tags	2020-03-13 00:39:55 +00:00
Log.t	Bug 22917: Fix typo in another test file	2019-05-23 14:47:41 +00:00
MarcModificationTemplates.t	…
Members.t	Bug 23579: (RM follow-up) Fix failing tests	2019-10-25 13:13:26 +01:00
MungeMarcPrice.t	…
NewsChannels.t	…
Overdues.t	Bug 25127: Correction to tests	2020-05-08 22:53:45 +00:00
Passwordrecovery.t	Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string	2020-05-07 17:17:12 +00:00
PatronLists.t	…
Patroncards.t	…
Patrons.t	Bug 17168: (QA follow-up) Only remove guarantor relationship if not Child AND not Professional	2019-10-26 07:37:42 +01:00
QueryParser.t	…
Record.t	…
RecordProcessor_EmbedSeeFromHeadings.t	…
RefundLostItemFeeRule.t	Bug 18930: (RM follow-up) Restore primary key find	2019-07-16 13:53:54 +01:00
Reports.t	…
Reserves.t	Bug 23964: (follow-up) We should check for only active holds when determining to set waiting	2019-11-25 16:38:16 +00:00
RotatingCollections.t	…
Search.t	Bug 15142: (RM follow-up) Fix tests	2020-01-31 00:10:19 +00:00
Serials.t	Bug 23416: Add PreserveSerialNotes system preference	2019-08-12 14:35:18 +01:00
Serials_2.t	…
Service.t	…
ShelfBrowser.t	…
Sitemapper.t	Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string	2020-05-07 17:17:12 +00:00
Stats.t	…
StockRotationItems.t	…
StockRotationRotas.t	…
StockRotationStages.t	…
SuggestionEngine_ExplodedTerms.t	…
Suggestions.t	Bug 22778: Add unit test	2020-05-04 20:52:45 +00:00
Tags.t	…
Templates.t	…
TestBuilder.t	Bug 24062: Make sure TestBuilder will stop generate X or other invalid category's types	2019-11-19 15:17:08 +00:00
Upload.t	…
UsageStats.t	Bug 23233: (RM follow-up) Rename syspref in test	2020-01-15 00:04:18 +00:00
Virtualshelves.t	…
XISBN.t	Bug 23274: Mock simple_search_compat to cover both search engines	2020-01-30 23:44:59 +00:00
XSLT.t	Bug 7611: Adjust tests	2020-04-21 18:58:31 +00:00
XSLT_Handler.t	…
check_kohastructure.t	…
check_sysprefs.t	…
db_structure.t	…
default_search_class.pl	…
rollingloans.t	…
sysprefs.t	…
zebra_config.pl	…