Koha-clms/Koha
Tomas Cohen Arazi 900f6b2ce0 Bug 36329: Make POST /transfer_limits/batch honor BranchTransferLimitsType
This patch adds tests for the different cases of `BranchTransferLimitsType`.
It also adds tests for the situation of the consumer sending both limit
criterias on the request.

The controller gets adjusted for this new behavior and the spec gets
documentation added about this.

Bonus: tests are added the right guidelines code, and
BranchTransferLimitsType gets mocked to avoid failures due to existing
data.

To test:
1. Apply this patches
2. Run:
   $ ktd --shell
  k$ qa
=> SUCCESS: All green, and tests pass!
3. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Fixed a typo in one of the return messages

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit e846641edd)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit f39baa0b98)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2024-05-13 14:40:58 +00:00
..
Account Bug 32894: Remove wrong caching from Koha:: methods - simple 2023-07-12 07:50:40 +01:00
Acquisition Bug 33885: Make Koha::Acq::Order->creator return undef if no creator 2023-06-26 14:41:10 +02:00
App
…
ArticleRequest
…
Auth Bug 30843: Add mfa_range configuration option for TOTP 2023-10-05 08:36:20 -10:00
Authority
…
BackgroundJob Bug 35843: Correct invalid exception 2024-02-08 18:51:19 +00:00
Biblio Bug 33270: (QA follow-up) Do not change param hashref 2023-07-19 09:27:44 +01:00
BiblioUtils
…
Cache
…
Cash
…
Charges
…
Checkouts Bug 33362: Allow return claims to be resolved even if the issue has since been delete from the database 2023-05-24 11:21:31 -03:00
Club
…
CodeList/Unimarc
…
Config Bug 32478: Remove Koha::Config::SysPref->find since bypasses cache 2023-06-09 16:04:58 -03:00
Course
…
Database Bug 32312: Add missing column descriptions to the statistics table 2023-11-07 22:13:04 -10:00
ERM Bug 34789: Update usage throughout Koha modules and Vue components 2023-09-18 10:27:46 -10:00
Edifact Bug 35173: Correctly concat error strings 2023-11-07 22:01:20 -10:00
Exceptions Bug 27249: Add missing POD for Koha::Exceptions::Calendar 2023-10-24 20:27:34 -10:00
Exporter Bug 25503: Make _get_biblio_for_export test pass 2023-05-10 15:26:19 -03:00
ExternalContent Bug 33697: Remove RecordedBooks (rbdigital) integration 2023-06-09 11:22:15 -03:00
Filter/MARC Bug 32464: Koha::Item->as_marc_field obsolete option mss 2023-06-09 12:04:54 -03:00
Hold
…
Illrequest Bug 21548: ILLLIBS patron category / partner_code seems extraneous 2023-03-31 12:14:51 +02:00
Import Bug 32437: (QA follow-up) Change to replace POD 2023-03-31 13:13:28 +02:00
Indexer
…
Item Bug 33739: Only trigger indexing on last item modification at ModItemTransfer 2023-05-16 11:26:06 +02:00
Library Bug 32894: Remove wrong caching from Koha:: methods - simple 2023-07-12 07:50:40 +01:00
List
…
MetadataRecord
…
Middleware Bug 36149: (follow-up) POD and tidy 2024-05-01 15:35:19 +00:00
Misc
…
Notice Bug 30287: (follow-up) Add content wrap matching send time 2024-01-04 20:34:51 +00:00
Number
…
OAI/Server Bug 34467: OAI GetRecord bad encoding for Unimarc 2023-10-09 20:39:15 -10:00
Object Bug 32894: Remove wrong caching from Koha:: methods - simple 2023-07-12 07:50:40 +01:00
Objects Bug 32735: (follow-up) Make Koha::Objects::Record::Collections->print_collection work with Authorities and Biblios 2023-05-05 12:13:50 -03:00
Old Bug 34609: Add biblio method to Old::Hold 2023-09-07 14:35:37 -10:00
Patron Bug 34731: (follow-up) Fix conditional variable declaration 2023-09-14 07:54:48 -10:00
Patrons Bug 34883: Stop patron expiry date being set to NULL during import 2023-10-12 10:33:22 -10:00
Plugins Bug 29672: Clear cache of enabled plugins when a plugin's state change 2022-11-03 11:28:16 -03:00
REST Bug 36329: Make POST /transfer_limits/batch honor BranchTransferLimitsType 2024-05-13 14:40:58 +00:00
RecordProcessor
…
Result
…
SMS
…
SMTP Bug 34622: Fix store default query 2023-09-20 20:06:10 -10:00
Schema Bug 31297: DBIC 2024-01-12 20:38:37 +00:00
SearchEngine Bug 35086: Add chunk_size option to elasticsearch configuration 2024-02-02 16:25:22 +00:00
Serial
…
Sitemapper
…
Subscription
…
SuggestionEngine
…
Tags
…
Template/Plugin Bug 35955: Cache CSRF token in template plugin 2024-03-19 21:23:36 +00:00
Ticket Bug 31028: Add catalog concern management page to staff 2023-03-06 11:23:17 -03:00
UI Bug 34266: Default to biblioitems.itemtype only if it's a valid itemtype 2023-09-07 20:11:04 -10:00
Util
…
XSLT Bug 12758: Add new module call in Koha::XSLT::Base 2022-11-09 09:52:25 -03:00
Z3950Responder
…
pdfformat Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages 2023-05-16 15:17:28 -03:00
Account.pm Bug 34620: Do not throw expection if payment type is writeoff 2023-09-07 20:42:15 -10:00
ActionLog.pm
…
ActionLogs.pm
…
AdditionalContent.pm
…
AdditionalContents.pm Bug 29144: Add $contents->find_best_match, $library->opac_info 2022-09-16 09:55:19 -03:00
AdditionalField.pm Bug 11844: Fix QA issues (POD, TT filters, file exec flag) 2023-05-16 12:58:38 +02:00
AdditionalFieldValue.pm
…
AdditionalFieldValues.pm
…
AdditionalFields.pm
…
AdvancedEditorMacro.pm
…
AdvancedEditorMacros.pm
…
ApiKey.pm
…
ApiKeys.pm
…
ArticleRequest.pm Bug 32894: (QA follow-up) Fix typo 2023-07-12 07:50:40 +01:00
ArticleRequests.pm
…
AudioAlert.pm
…
AudioAlerts.pm
…
AuthUtils.pm Bug 33341: Address some perlcritic errors in 5.36 2023-03-28 14:50:33 +02:00
AuthorisedValue.pm Bug 30920: (follow-up) Flush on delete 2023-03-13 15:11:44 -03:00
AuthorisedValueCategories.pm
…
AuthorisedValueCategory.pm Bug 32997: Add REST API endpoint to list authorised values for multiple given categories 2023-03-02 12:00:15 -03:00
AuthorisedValues.pm Bug 35579: Cache authorised value lookup by MARC field 2024-01-12 22:02:27 +00:00
Authorities.pm Bug 33083: Add a generic class to handle methods for collections of records 2023-03-13 15:11:59 -03:00
Authority.pm Bug 33996: (QA follow-up) Fix mappings to match guidelines 2023-07-17 15:46:10 +01:00
BackgroundJob.pm Bug 35843: Correct invalid exception 2024-02-08 18:51:19 +00:00
BackgroundJobs.pm Bug 31969: Use filter_by_last_update 2022-11-25 09:40:09 -03:00
Biblio.pm Bug 33497: Add a filter relationship for branchtransfers 2023-07-17 16:41:30 +01:00
BiblioFramework.pm
…
BiblioFrameworks.pm
…
BiblioUtils.pm
…
Biblioitem.pm
…
Biblioitems.pm
…
Biblios.pm Bug 33974: (follow-up) biblionumber column needs special handling 2023-07-17 16:26:38 +01:00
Cache.pm
…
Caches.pm
…
Calendar.pm Bug 27249: Prevent infinite loop when searching for an open day 2023-10-24 20:27:34 -10:00
Checkout.pm
…
Checkouts.pm
…
CirculationRule.pm Bug 32894: Remove wrong caching from Koha:: methods - simple 2023-07-12 07:50:40 +01:00
CirculationRules.pm Bug 32271: (QA follow-up) Correction to 'can_be_blank' logic 2023-08-07 20:05:46 -10:00
Cities.pm
…
City.pm
…
ClassSortRule.pm
…
ClassSortRules.pm
…
ClassSource.pm Bug 30920: (follow-up) Flush on delete 2023-03-13 15:11:44 -03:00
ClassSources.pm
…
ClassSplitRule.pm
…
ClassSplitRules.pm
…
Club.pm
…
Clubs.pm
…
Config.pm Bug 31393: Koha::Config: handle the special case for 'content' attribute 2023-11-07 22:14:09 -10:00
CookieManager.pm Bug 31250: (QA follow-up) The future will be easier 2022-09-12 15:34:11 -03:00
Course.pm
…
Courses.pm
…
CoverImage.pm
…
CoverImages.pm
…
CsvProfile.pm
…
CsvProfiles.pm
…
CurbsidePickup.pm
…
CurbsidePickupIssue.pm
…
CurbsidePickupIssues.pm
…
CurbsidePickupOpeningSlot.pm
…
CurbsidePickupOpeningSlots.pm
…
CurbsidePickupPolicies.pm
…
CurbsidePickupPolicy.pm Bug 32891: Fix slot selection in last hour 2023-02-21 10:22:28 -03:00
CurbsidePickups.pm
…
Database.pm
…
DateUtils.pm Bug 33611: Ensure dt_from_string always returns a new object 2023-05-09 10:58:04 -03:00
Desk.pm
…
Desks.pm
…
EDI.pm Bug 35398: (QA follow-up) Tidy code 2024-03-19 15:21:43 +00:00
Edifact.pm
…
Email.pm
…
Encryption.pm Bug 33934: Add more detail to 'No encryption_key in koha-conf.xml' 2023-06-09 12:05:00 -03:00
Exception.pm
…
Exceptions.pm Bug 32334: Add general exception FileNotFound 2023-04-12 11:21:55 -03:00
ExternalContent.pm
…
FrameworkPlugin.pm Bug 35012: Apply change to all events 2023-11-14 09:03:53 -10:00
Hold.pm Bug 34333: Add Koha::Hold->cancellation_requested 2023-09-18 11:42:11 -10:00
Holds.pm Bug 32529: Add Koha::Holds->filter_by_found 2023-01-05 09:21:10 -03:00
I18N.pm Bug 35174: Do not explode if po dir does not exist 2023-11-22 09:33:46 +01:00
Illbackend.pm Bug 34223: (follow-up) Ensure consistent ordering of statuses 2023-09-14 08:23:44 -10:00
Illcomment.pm
…
Illcomments.pm
…
Illrequest.pm Bug 35105: Fix patron accessor in Illrequest.pm 2023-10-24 22:16:50 -10:00
Illrequestattribute.pm Bug 22440: Add standard accessors for later usage 2023-05-05 09:13:41 -03:00
Illrequestattributes.pm Bug 22440: New ILL requests table 2023-05-05 09:13:41 -03:00
Illrequests.pm Bug 22440: Add Koha::Illrequests->filter_by_visible 2023-05-05 09:13:40 -03:00
ImportBatch.pm
…
ImportBatchProfile.pm
…
ImportBatchProfiles.pm
…
ImportBatches.pm
…
Item.pm Bug 35167: Make 'effective_not_for_loan_status' fallback to 0 if itype has it undef 2023-11-02 10:31:49 -10:00
ItemType.pm Bug 34008: Harmonize attribute names 2023-11-07 22:41:49 -10:00
ItemTypes.pm
…
Items.pm Bug 32019: (follow-up) Fix terminology and styling 2023-02-20 09:54:20 -03:00
KeyboardShortcut.pm
…
KeyboardShortcuts.pm
…
Libraries.pm
…
Library.pm Bug 30920: (follow-up) Flush on delete 2023-03-13 15:11:44 -03:00
Linktracker.pm
…
Localization.pm Bug 30920: (follow-up) Flush on delete 2023-03-13 15:11:44 -03:00
Localizations.pm
…
Logger.pm Bug 33020: (QA follow-up) POD and chmod 2023-02-27 11:33:50 -03:00
Manual.pm Bug 33790: Fix and add various links to the manual 2023-07-18 10:04:03 +01:00
MarcOverlayRule.pm
…
MarcOverlayRules.pm
…
MarcSubfieldStructure.pm
…
MarcSubfieldStructures.pm
…
MessageAttribute.pm
…
MessageAttributes.pm
…
MetaSearcher.pm
…
MetadataIterator.pm
…
MetadataRecord.pm Bug 30358: Strip leading/trailing whitespace characters from input fields when cataloguing 2023-05-16 15:17:26 -03:00
MoreUtils.pm
…
OAuth.pm
…
OAuthAccessToken.pm
…
OAuthAccessTokens.pm
…
Object.pm Bug 33161: (follow-up) Remove stray variables and fix POD 2023-03-10 10:20:10 -03:00
Objects.pm
…
Patron.pm Bug 19613: Use the 'note' profile 2024-05-01 15:33:51 +00:00
Patrons.pm Bug 31937: Fix Patrons::search_unsubscribed - sharpen condition 2022-11-17 13:41:24 -03:00
Plugins.pm Bug 35507: Add verbose parameters in Koha::Plugins 2024-02-14 16:29:01 +00:00
ProblemReport.pm
…
ProblemReports.pm
…
PseudonymizedTransaction.pm
…
PseudonymizedTransactions.pm
…
Quote.pm
…
Quotes.pm
…
RDF.pm
…
Rating.pm
…
Ratings.pm
…
Recall.pm Bug 18398: Update C4::Message enqueue to use $patron->notice_email_address 2023-03-31 13:13:33 +02:00
Recalls.pm Bug 31147: Recalls should not adjust due time for related checkouts 2023-07-18 12:23:30 +01:00
RecordProcessor.pm
…
Report.pm Bug 27824: Trim column headers 2023-07-18 12:24:01 +01:00
Reports.pm
…
Review.pm
…
Reviews.pm
…
Schema.pm
…
Script.pm
…
SearchEngine.pm
…
SearchField.pm
…
SearchFields.pm
…
SearchFilter.pm Bug 17170: (QA follow-up) Spec cleanup 2022-10-21 11:15:22 -03:00
SearchFilters.pm Bug 17170: DB Updates 2022-10-21 11:15:13 -03:00
SearchMarcMap.pm
…
SearchMarcMaps.pm
…
Serial.pm
…
Serials.pm
…
Session.pm Bug 36098: Default to 'file' if pref does not exist 2024-03-19 15:03:55 +00:00
SharedContent.pm
…
SimpleMARC.pm Bug 24480: (follow-up) Shift new fields into array and add after all are copied 2023-11-09 15:58:08 -10:00
Sitemapper.pm
…
Statistic.pm
…
Statistics.pm
…
StockRotationItem.pm
…
StockRotationItems.pm
…
StockRotationRota.pm
…
StockRotationRotas.pm
…
StockRotationStage.pm
…
StockRotationStages.pm
…
Subscription.pm
…
Subscriptions.pm
…
Suggestion.pm Bug 32942: (follow-up) Restore missing statuses 2023-09-20 20:01:18 -10:00
SuggestionEngine.pm
…
Suggestions.pm Bug 33238: Fix bad suggestions query (Bug 29886 follow-up) 2023-04-17 09:39:43 -03:00
Tag.pm
…
Tags.pm
…
Ticket.pm Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-14 07:54:48 -10:00
Tickets.pm Bug 31028: Add new Koha::Object(s) classes 2023-03-06 11:23:17 -03:00
Token.pm Bug 34755: Backport Koha::Token change from bug 34478 2024-03-19 21:26:05 +00:00
TrackedLink.pm
…
TrackedLinks.pm
…
UploadedFile.pm
…
UploadedFiles.pm
…
Uploader.pm
…
Virtualshelf.pm Bug 32894: Remove wrong caching from Koha:: methods - simple 2023-07-12 07:50:40 +01:00
Virtualshelfcontent.pm
…
Virtualshelfcontents.pm
…
Virtualshelfshare.pm Bug 32894: Make ->sharee looks like others 2023-07-12 07:50:41 +01:00
Virtualshelfshares.pm
…
Virtualshelves.pm Bug 30418: Add ability for permitted staff to edit list contents 2023-05-15 18:23:57 -03:00
Z3950Responder.pm
…
Z3950Server.pm
…
Z3950Servers.pm
…