gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
32,190 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Marcel de Rooy 2ea99b1998
Bug 21115: Add multi_param call and add divider in cache key in svc/report and opac counterpart 
Resolve things like:
CGI::param called in list context from package CGI::Compile::ROOT::usr_share_koha_prodclone_opac_svc_report line 42, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.

The cache key in both script looks like:
    opac:report:id:602018
but should for consistency be:
    opac:report:id:60:2018
Note: The 2018 here is part of the sql_params and should not be
concatenated to the report id.

Test plan:
Do not yet apply this patch.
Make a report public, set cache to 300 secs.
Check its output with opac/svc/report.
Check for the warn in your log.
Apply the patch, restart Plack and flush cache.
Check opac/svc/report.
Modify your report; e.g. add a simple string to the SELECT.
Check opac/svc/report. You should still see cached output.
Flush the cache.
Check opac/svc/report. You should now see the added text.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested also by clearing individual keys with $cache->clear_from_cache.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit bfbbe52ff7)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
 		2018-10-17 11:55:53 +01:00
C4 Bug 21365: Call BiblioAutoLink from AddBiblio and ModBiblio 2018-10-17 11:31:33 +01:00
Koha Bug 20548: Remove copyright clearance for staff 2018-10-15 13:39:36 +01:00
OpenILS
…
acqui Bug 21365: Call BiblioAutoLink from AddBiblio and ModBiblio 2018-10-17 11:31:33 +01:00
admin Bug 21417: EDI ordering fails when basket and EAN libraries do not match 2018-10-15 12:48:46 +01:00
api/v1 Bug 20942: Split debit and credit lines 2018-08-02 18:03:36 +01:00
authorities Bug 21455: Authority search options get shuffled around when you click on 'Search' 2018-10-15 12:44:23 +01:00
basket Bug 16575: Irregular behaviour using window.print() followed by window.location.href 2018-08-02 14:43:04 +01:00
catalogue Bug 21291: (follow-up) Pass subscriptionsnumber to all tools in staff detail's sidebar 2018-10-17 11:50:22 +01:00
cataloguing Bug 21365: Call BiblioAutoLink from AddBiblio and ModBiblio 2018-10-17 11:31:33 +01:00
circ Bug 21291: (follow-up) Pass subscriptionsnumber to all tools in staff detail's sidebar 2018-10-17 11:50:22 +01:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 19230: Preventing warn when deleting course 2018-01-30 14:18:21 -03:00
debian Bug 21426: Handle USE_MEMCACHED=no in koha-create 2018-10-15 14:38:36 +01:00
docs Bug 7143: Update about page for new dev - Alberto Martinez 2018-09-27 14:33:31 +01:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 21031: Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration 2018-08-03 15:24:41 +01:00
ill Bug 21289: Fix "isa" bug during partner request 2018-10-05 13:10:31 +01:00
installer Bug 21417: DBRev 18.05.04.002 2018-10-15 12:53:18 +01:00
koha-tmpl Bug 20131: Inventory optional filters correct "For loan" addition 2018-10-17 11:46:14 +01:00
labels Bug 20765: Fix search for items by acqdate in label batch 2018-09-17 14:54:42 +01:00
members Bug 21167: Fix price formatting on printed fee invoice and receipt 2018-10-05 12:41:01 +01:00
misc Bug 21322: process_message_queue.pl --type should take an argument 2018-10-08 09:49:54 +01:00
offline_circ Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl 2018-09-17 14:27:25 +01:00
opac Bug 21115: Add multi_param call and add divider in cache key in svc/report and opac counterpart 2018-10-17 11:55:53 +01:00
patron_lists Bug 19837: Add error feedback for duplicated or unfound cardnumbers 2018-02-18 16:48:46 -03:00
patroncards Bug 8604: Patron cards made for patrons which don't have patron images use preceding card's image 2018-08-02 15:22:00 +01:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 16653: (QA follow-up) Avoid a warning and remove unused variables 2018-07-02 08:23:42 +01:00
reserve Bug 21291: (follow-up) Pass subscriptionsnumber to all tools in staff detail's sidebar 2018-10-17 11:50:22 +01:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-15 13:34:36 +01:00
serials Bug 20241: Fix display of publication year in subscription record search for MARC21 2018-10-03 10:37:05 +01:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel
…
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-09 11:20:29 +01:00
svc Bug 21115: Add multi_param call and add divider in cache key in svc/report and opac counterpart 2018-10-17 11:55:53 +01:00
t Bug 21479: "Mock" SearchEngine to use Zebra 2018-10-16 14:50:59 +01:00
tags Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
test
…
tmp/modified_authorities
…
tools Bug 21291: (follow-up) Pass subscriptionsnumber to all tools in staff detail's sidebar 2018-10-17 11:50:22 +01:00
virtualshelves Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
xt Bug 20906: Fix translatable-templates.t 2018-06-25 18:13:55 +01:00
.editorconfig
…
.gitignore Bug 20267: Add basic .gitignore 2018-03-26 17:31:16 -03:00
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 21417: DBRev 18.05.04.002 2018-10-15 12:53:18 +01:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 18342: Enable memcached by default for new installs 2018-05-03 12:47:07 -03:00
README
…
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 20428: Display warning if the entry is empty 2018-05-14 11:14:40 -03:00
changelanguage.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
edithelp.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
fix-perl-path.PL
…
help.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
install-CPAN.pl
…
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl
…
mainpage.pl Bug 20489: Remove warnings from the interface 2018-04-20 12:24:00 -03:00
rewrite-config.PL Bug 18342: Enable memcached by default for new installs 2018-05-03 12:47:07 -03:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo