gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
29,863 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Jonathan Druart 2e0d9f41bb Bug 20462: Ensure batch item deletion will not delete the same item twice 
This has been done on bug 9509 when barcodes are scaned, but not when using a text file.

Test plan (stolen from Barton on the bug report):
1) Create a text file containing duplicate barcodes

Here's a quick way to do that, substitute INSTANCE for the instance name of your test server:

sudo koha-mysql INSTANCE <<< "select barcode from items where barcode is not null limit 3" | sed '1d;p' > /tmp/dup_barcodes.txt

2) Go to Home › Tools › Batch item deletion
3) Click 'Choose File', select the file you created in step 1.
4) Click 'Continue'
5) Note that duplicate items appear in the list of items to batch delete
6) Check 'Delete records if no items remain'
7) This will trigger a software error

Note that entering the barcodes via the 'scan items one by one' text box removes duplicates in the list, so this only causes problems when uploading a file.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 1f4baf31bb)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
 		2018-05-22 11:57:04 +02:00
C4 Bug 20455: Fix sort patrons by date expired 2018-05-22 11:22:42 +02:00
Koha Bug 20229: Explicitly list the SQL modes we support 2018-04-10 08:53:40 +02:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 19596: Don't try to get hold or items count for non-existent biblios 2018-02-05 11:34:25 +01:00
admin Bug 20227: Check for categorycode in default_borrower_circ_rules 2018-05-09 16:46:06 +02:00
api/v1 Bug 18763: Fix swagger/definitions.t 2017-06-20 10:19:55 +02:00
authorities Bug 20430: (See also bug 19436) Button display depends on wrong server count 2018-04-24 07:12:19 +02:00
basket Bug 18124: Change the calls to generate and check CSRF tokens 2017-03-30 09:07:09 +00:00
catalogue Bug 20341: Show authorized value description for withdrawn like damaged and lost 2018-04-24 07:10:53 +02:00
cataloguing Bug 18593: Move suggestions when bibliographic records are merged 2018-04-24 15:22:21 +02:00
circ Bug 19921: Fix update child when only one adult patron category exist 2018-01-30 09:09:39 +01:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 20276: Fix GetCourseItem call to get itemnumber 2018-02-26 13:41:21 +01:00
debian Revert "Bug 20234: Make maintenance scripts use koha-zebra instead of koha-*-zebra" 2018-05-16 08:22:53 +02:00
docs Bug 7143: Add Patricio Marrone to history.txt 2017-03-31 13:45:33 +00:00
errors Bug 15288: Error pages: Code duplication removal and better translatability 2016-01-27 05:57:34 +00:00
etc Bug 19739: Add default ES configuration to koha-conf.xml 2018-04-24 17:16:06 +02:00
installer Increment version for 17.05.11 release 2018-04-25 08:25:17 +02:00
koha-tmpl Bug 20318: Add class 'required' to the label 2018-05-22 11:53:45 +02:00
labels Bug 19681: Correct result count formatting 2017-12-20 09:30:46 +01:00
members Bug 20367: Avoid resetting userid when BorrowerUnwantedField contains userid 2018-03-27 13:46:10 +02:00
misc Update release notes for 17.05.11 release 2018-04-25 08:31:26 +02:00
offline_circ Bug 17501: Remove Koha::Upload::get from Koha::Upload 2017-01-20 14:20:05 +00:00
opac Bug 20083: Follow up - use same logic in opac-showmarc 2018-03-27 13:59:19 +02:00
patron_lists Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
patroncards Bug 18246: Patron card creator: Unit not always displays properly in layouts 2017-03-22 20:58:10 +00:00
plugins Bug 19088: plugins-upload causes error log noise 2017-09-29 15:34:42 +02:00
reports Bug 19671: Map itemtypes to hash for correct display in issues_stats.pl 2018-05-02 07:31:46 +02:00
reserve Bug 18474: Restore multiple holds when patron is searched for 2018-05-22 11:46:54 +02:00
reviews Bug 15839: Koha::Reviews - Remove C4::Review residue 2016-09-09 10:31:00 +00:00
rotating_collections Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
serials Bug 20461: Serials: fix ignored params in subscription creation form 2018-04-24 17:10:43 +02:00
services Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
suggestion Bug 18839: Suggestion.pl spelling mistake 2017-07-27 16:30:17 +02:00
svc Bug 17898: Automagically convert SQL reports 2017-05-19 18:48:26 +00:00
t Bug 20503: Prevent Borrower_PrevCheckout.t to fail randomly 2018-05-22 11:42:29 +02:00
tags Bug 5471: Use uri_escape_utf8 to handle utf8 chars correctly 2017-09-29 11:17:17 +02:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 20462: Ensure batch item deletion will not delete the same item twice 2018-05-22 11:57:04 +02:00
virtualshelves Bug 7663: Fix bad merge conflict with bug 15584 2017-03-03 18:18:14 +00:00
xt Bug 19262: Remove xt/author/pod_spell.t 2017-10-23 15:29:50 +02:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Update mailmap - Jonathan Druart 2017-06-29 09:33:25 +02:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Increment version for 17.05.11 release 2018-04-25 08:25:17 +02:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 19067: Map clubs/ into INTRANET_CGI_DIR in Makefile.PL 2017-09-12 16:04:02 +02:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 18931 - Follow up - Typo fix in SQL statement 2017-07-27 10:25:20 +02:00
changelanguage.pl Bug 16776: Do not forget external language choice in language switcher 2016-08-10 13:51:33 +00:00
edithelp.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 16724: Fix link to the online documentation links 2016-06-24 12:00:42 +00:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl Bug 17990: Refactor Perl module versions check 2017-02-17 12:13:44 +00:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 18432 : Follow up - Updating to use they/them 2017-04-21 10:56:43 -04:00
rewrite-config.PL Bug 15427 : Enable TLS support for MySQL 2017-03-03 18:33:07 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo