Koha-clms/Koha/REST/V1
Tomas Cohen Arazi 82e0edd876
Bug 35053: Make sure request is checked as an item-level request if item_id passed
This patch makes the validation code have the `$item` variable defined
when checking holdability, in the case both `item_id` and `biblio_id`
params are passed.

Otherwise, if the requested item is not holdable, but a biblio-level
hold *could* be placed, the item-level hold is placed.

This is highlighted by the regression tests.

To test:
1. Apply the regression tests patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/holds.t
=> FAIL: Tests don't pass. A request that should be rejected is allowed
because biblio-level hold is allowed.
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! Item-level rules are checked and thus the
request rejected (code 403)
5. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-20 11:02:55 -03:00
..
Acquisitions Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
Auth Bug 34313: Add patron information in pass validation response 2023-08-29 14:59:02 -03:00
Biblios Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
CashRegisters Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
Clubs Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
Config/SMTP Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
ERM Bug 34339: (QA follow-up) Replace new by search in Licenses 2023-09-08 11:54:51 -03:00
OAuth Bug 34271: Remove a few Logger statements from REST API 2023-10-18 10:26:03 -03:00
Patrons Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
Preservation Bug 30708: Tidy perl files 2023-10-18 15:42:04 -03:00
AdvancedEditorMacro.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
ArticleRequests.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
Auth.pm Bug 33708: Allow anonymous access to OAuth endpoints 2023-05-18 11:35:16 -03:00
AuthorisedValueCategories.pm Bug 32997: Add REST API endpoint to list authorised values for multiple given categories 2023-03-02 12:00:15 -03:00
AuthorisedValues.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
Authorities.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
BackgroundJobs.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
Biblios.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
Checkouts.pm Bug 32496: Some fixes 2023-09-22 10:52:40 -03:00
CirculationRules.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Cities.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
ERM.pm Bug 33606: (QA follow-up) Cosmetic changes 2023-07-06 12:24:15 -03:00
Holds.pm Bug 35053: Make sure request is checked as an item-level request if item_id passed 2023-10-20 11:02:55 -03:00
Illbackends.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
IllbatchStatuses.pm Bug 30719: (QA follow-up) Rename illbatchstatuses 2023-10-17 14:45:22 -03:00
Illbatches.pm Bug 30719: (QA follow-up) Pick better column names and cleanup 2023-10-17 14:45:23 -03:00
Illrequests.pm Bug 30719: (QA follow-up) c->validation fixes 2023-10-17 14:45:18 -03:00
ImportBatchProfiles.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
ImportRecordMatches.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
Items.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
Libraries.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
OAuth.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
Patrons.pm Bug 33690: Convert to x-koha-override 2023-10-04 11:07:56 -04:00
Preservation.pm Bug 30708: Tidy perl files 2023-10-18 15:42:04 -03:00
Quotes.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
ReturnClaims.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
SearchFilter.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
Stage.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
Static.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Suggestions.pm Bug 32942: (QA follow-up) Moving Suggestion->STATUS check to Suggestion::store 2023-09-18 15:31:45 -03:00
Tickets.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
TransferLimits.pm Bug 33556: Avoid relying on $c->validation 2023-07-21 17:14:37 -03:00
TwoFactorAuth.pm Bug 30843: Add mfa_range configuration option for TOTP 2023-09-25 10:53:51 -03:00