Koha-clms/Koha
Nick Clemens 3e506d58ab
Bug 39408: Don't attempt to send a message if one is not generated
The routine to create the message can return nothing if there is no content,
we should handle this case and not attempt to send.

To test:
1 - Test plan from last patch
2 - Apply this patch
3 - POST to patron API again
4 - Success!

Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit c1fa513be9)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
(cherry picked from commit 91da4b4b38)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2025-11-10 15:21:27 +01:00
..
Account Bug 22421: (QA follow-up) Update API mapping and specs 2024-11-08 17:06:06 +01:00
Acquisition Bug 39826: UTF8-decode vendor interface's password on display 2025-09-29 11:51:09 +02:00
App Bug 38630: (QA follow-up) Add copyright, license and/or POD 2025-09-29 09:34:51 +02:00
ArticleRequest
…
Auth Bug 37157: Fix Malformed UTF-8 character in JSON string before decode_json 2024-06-27 11:50:06 +02:00
Authority
…
BackgroundJob Bug 39652: Rename new_from_statistic 2025-09-29 10:00:07 +02:00
Biblio Bug 28478: Add get_opac_suppression extractor 2025-02-18 19:17:20 +01:00
Cache
…
Cash Bug 36481: (QA follow-up) Rename branch_default to library_default 2024-05-01 13:51:41 +01:00
Charges
…
Checkouts
…
Club
…
CodeList/Unimarc
…
Config
…
Course Bug 40419: Fix wrong license 2025-08-01 14:50:29 +02:00
Database Bug 36039: (QA follow-up): Improve audit messages 2025-03-24 18:12:31 +01:00
DateTime/Format
…
ERM Bug 39345: 24.11 SQUASH 2025-10-16 07:47:17 +02:00
Edifact Bug 39904: (QA follow-up) Fix a few other cases 2025-10-03 15:45:34 +02:00
Exceptions Bug 39345: 24.11 SQUASH 2025-10-16 07:47:17 +02:00
Exporter
…
ExternalContent
…
Filter/MARC Bug 40128: StripWhitespaceChars can create empty subfields 2025-07-31 16:18:10 +02:00
Hold
…
ILL Bug 40171: Return fail if no transports for patron 2025-10-31 15:05:59 +00:00
Import Bug 40419: Fix wrong license 2025-08-01 14:50:29 +02:00
Indexer
…
Installer Bug 38299: Make filehandler optional for colored outputs 2024-11-18 17:44:37 +01:00
Item
…
Library Bug 6796: Add library_hours table and set opening hours for library 2024-04-12 11:26:03 +02:00
List
…
MetadataRecord Bug 35345: Add --where option to rebuild_elasticsearch.pl 2024-04-22 12:39:26 +02:00
Middleware Bug 36560: (QA follow-up) Tidy code 2024-10-25 16:41:29 +02:00
Misc
…
Notice Bug 38903: Fix theme in some getTranslatedLanguages calls 2025-09-29 09:37:15 +02:00
Number Bug 37511: Location of the currency symbol (before or *after*) the amount 2024-10-30 11:57:26 +01:00
OAI Bug 39857: Fix expanded_avs option for OAI 2025-05-17 21:05:56 +02:00
Object Bug 38528: Update empty field value logic 2025-08-06 09:57:00 +00:00
Objects Bug 35287: (QA follow-up): Squash 2024-10-24 13:38:22 +02:00
Old Bug 33284: Set renewer_id for sets of checkouts 2025-08-04 10:13:03 +02:00
Patron Bug 40458: add pod coverage to Discharge.pm 2025-08-01 15:52:50 +02:00
Patrons Bug 40579: Fix CSV formula injection vulnerabilities 2025-09-02 16:34:19 +01:00
Plugins
…
Policy
…
Preservation
…
REST Bug 39408: Don't attempt to send a message if one is not generated 2025-11-10 15:21:27 +01:00
RecordProcessor
…
Result
…
SMS
…
SMTP
…
Schema Bug 39075: DBIC schema changes 2025-10-03 16:13:01 +02:00
SearchEngine Bug 39079: Follow 'and_or' variable when passed to build_auth_query_compat 2025-10-03 14:35:53 +02:00
Serial
…
Sitemapper Bug 36977: Google does not read sitemaps with the name sitemapNNNN.xml 2024-10-30 14:34:52 +01:00
Subscription
…
SuggestionEngine
…
Tags
…
Template/Plugin Bug 40132: Remove POD for get_opac_news_by_id 2025-09-19 12:00:58 +02:00
Ticket Bug 35657: Add support for assignee_id to ticket_updates endpoint 2024-05-02 15:03:35 +02:00
UI Bug 40818: Remove HTML from marc_lib 2025-10-28 14:59:13 +00:00
Util Bug 36976: Warning 'Argument "" isn't numeric in numeric' in log when merging bibliographic records 2024-06-28 13:49:24 +02:00
XSLT
…
Z3950Responder Bug 36996: Add z3950Status system preference 2024-07-23 16:53:03 +01:00
pdfformat Bug 33393: tidy layout1page.pm 2024-04-19 19:54:46 +02:00
Account.pm Bug 22421: (follow-up): Check issue during add_credit 2024-11-08 12:42:07 +01:00
ActionLog.pm
…
ActionLogs.pm
…
AdditionalContent.pm Bug 36875: (follow-up) Modify query in translated_content 2024-06-20 17:55:39 +02:00
AdditionalContents.pm Bug 40020: Remove warnings from Koha/AdditionalContents.t 2025-07-25 13:49:01 +02:00
AdditionalContentsLocalization.pm
…
AdditionalContentsLocalizations.pm
…
AdditionalField.pm Bug 37577: Add additional fields for ERM packages 2024-11-08 16:09:19 +01:00
AdditionalFieldValue.pm
…
AdditionalFieldValues.pm
…
AdditionalFields.pm
…
AdvancedEditorMacro.pm
…
AdvancedEditorMacros.pm
…
ApiKey.pm
…
ApiKeys.pm
…
ArticleRequest.pm Bug 36081: Use multivalue_preference 2025-02-24 20:43:20 +01:00
ArticleRequests.pm
…
AudioAlert.pm
…
AudioAlerts.pm
…
AuthUtils.pm
…
AuthorisedValue.pm Bug 34920: Ensure 'description' property is an empty string if 'lib' is null 2024-07-01 18:55:48 +02:00
AuthorisedValueCategories.pm
…
AuthorisedValueCategory.pm
…
AuthorisedValues.pm
…
Authorities.pm
…
Authority.pm Bug 29948: OPACAuthorIdentifiersAndInformation 2024-05-13 14:00:10 +02:00
BackgroundJob.pm Bug 34070: Deal with broker connection issues 2025-08-04 10:29:32 +02:00
BackgroundJobs.pm Revert "Bug 36217: Fix background jobs page's include_last_hour filter" 2024-10-18 14:26:01 +02:00
Biblio.pm Bug 31460: Merge item groups when merging records 2025-10-16 10:31:20 +02:00
BiblioFramework.pm
…
BiblioFrameworks.pm
…
BiblioUtils.pm Bug 31224: Update instances of metadata->record 2024-11-07 16:29:23 +01:00
Biblioitem.pm Bug 38679: (follow-up) Fix old typos in column names 2025-04-22 23:02:17 +02:00
Biblioitems.pm
…
Biblios.pm
…
Booking.pm Bug 38175: (follow-up) Quiet warnings in tests 2024-11-04 13:12:12 +00:00
Bookings.pm Bug 38175: (QA follow-up) Ensure we handle cancelled in clash detection 2024-10-24 18:27:24 +02:00
Cache.pm
…
Caches.pm
…
Calendar.pm
…
Checkout.pm Bug 38184: Show due date on OpacTrustedCheckout modal 2025-06-19 11:12:00 +02:00
Checkouts.pm
…
CirculationRule.pm
…
CirculationRules.pm Bug 34440: Add lead and trail time to circulation rules 2024-08-30 16:41:26 +02:00
Cities.pm
…
City.pm
…
ClassSortRule.pm
…
ClassSortRules.pm
…
ClassSource.pm
…
ClassSources.pm
…
ClassSplitRule.pm
…
ClassSplitRules.pm
…
Club.pm
…
Clubs.pm
…
Config.pm
…
CookieManager.pm
…
Course.pm Bug 40419: Fix wrong license 2025-08-01 14:50:29 +02:00
Courses.pm Bug 40419: Fix wrong license 2025-08-01 14:50:29 +02:00
CoverImage.pm
…
CoverImages.pm Bug 38966: Fix wrong POD in Koha/CoverImages.pm and Koha/Acquisition/Order/Claims.pm 2025-08-01 14:54:48 +02:00
CsvProfile.pm
…
CsvProfiles.pm
…
CurbsidePickup.pm
…
CurbsidePickupIssue.pm
…
CurbsidePickupIssues.pm
…
CurbsidePickupOpeningSlot.pm
…
CurbsidePickupOpeningSlots.pm
…
CurbsidePickupPolicies.pm
…
CurbsidePickupPolicy.pm
…
CurbsidePickups.pm
…
Database.pm Bug 36026: Use only configured TLS options for database connection 2024-11-11 15:35:36 +01:00
DateUtils.pm
…
Desk.pm Bug 36480: Add GET /libraries/:library_id/desks 2024-04-26 18:06:10 +02:00
Desks.pm
…
EDI.pm Bug 38423: Add unit tests 2025-04-17 14:30:35 +02:00
Edifact.pm
…
Email.pm Bug 31627: (follow-up) Update -Id to -ID 2024-05-10 14:11:50 +02:00
Encryption.pm Bug 40348: Remove warnings from api/v1/two_factor_auth.t 2025-08-01 11:21:35 +02:00
Exception.pm
…
Exceptions.pm Bug 35246: Make Koha::Biblio->to_api throw relevant exception if no biblioitem row 2025-08-06 13:25:37 +00:00
ExternalContent.pm
…
FrameworkPlugin.pm Bug 37146: Prevent path traversal by validating input 2024-08-01 17:26:37 +02:00
Hold.pm Bug 40542: Add cancellation_reason to Koha::Hold->strings_map 2025-09-19 15:01:53 +02:00
Holds.pm Bug 40985: Clarify POD of Holds->filter_by_found 2025-11-10 15:00:54 +01:00
I18N.pm
…
ImportBatch.pm Bug 34355: (QA follow-up) Permissions fixes 2024-11-11 17:43:18 +01:00
ImportBatchProfile.pm
…
ImportBatchProfiles.pm
…
ImportBatches.pm
…
Installer.pm Bug 40437: Remove warning from Koha/Installer.t 2025-08-01 15:04:53 +02:00
Item.pm Bug 40331: Return existing transfer if requesting a new transfer that is identical 2025-10-10 16:32:17 +02:00
ItemType.pm Bug 35906: Add bookable option on itemtype 2024-10-25 15:34:40 +02:00
ItemTypes.pm
…
Items.pm Bug 37334: [24.11] Allow filter holdings table by status (squashed) 2025-08-01 10:22:42 +02:00
KeyboardShortcut.pm
…
KeyboardShortcuts.pm
…
Language.pm Bug 38630: (QA follow-up) Add copyright, license and/or POD 2025-09-29 09:34:51 +02:00
Libraries.pm
…
Library.pm Bug 37850: (QA follow-up): Update illemail REST API attribute name 2024-11-12 17:50:16 +01:00
Linktracker.pm
…
Localization.pm
…
Localizations.pm
…
Logger.pm Bug 35907: Add ability to log all custom report runs with or without query 2024-05-10 16:45:45 +02:00
Manual.pm Bug 39712: Add POD 2025-09-19 16:10:14 +02:00
MarcOrder.pm Bug 39752: Check for biblio existence when matches are found 2025-09-29 11:35:15 +02:00
MarcOrderAccount.pm Bug 34355: Add account creation 2024-11-11 17:43:12 +01:00
MarcOrderAccounts.pm Bug 34355: Add account creation 2024-11-11 17:43:12 +01:00
MarcOverlayRule.pm
…
MarcOverlayRules.pm Bug 33268: Overlay rules don't work correctly when source is set to * 2025-04-17 14:30:33 +02:00
MarcSubfieldStructure.pm
…
MarcSubfieldStructures.pm
…
MetaSearcher.pm
…
MetadataIterator.pm
…
MetadataRecord.pm
…
MoreUtils.pm
…
OAIServer.pm Bug 35659: (more QA follow-ups) 2024-10-28 14:01:29 +01:00
OAIServers.pm Bug 35659: (more QA follow-ups) 2024-10-28 14:01:29 +01:00
OAuth.pm
…
OAuthAccessToken.pm
…
OAuthAccessTokens.pm
…
Object.pm Bug 38342: Pass the value to exception to avoid warnings 2024-11-07 18:49:40 +01:00
Objects.pm Bug 36873: Make Koha::Objects->delete pass parameters to the underlying method 2024-07-01 18:55:43 +02:00
OverdueRule.pm
…
OverdueRules.pm
…
Patron.pm Bug 40608: Continue password change even if notification fails 2025-09-26 16:23:55 +02:00
Patrons.pm Bug 37845: Remove C4::Members::DeleteExpiredOpacRegistrations 2024-10-21 15:10:31 +02:00
Plugins.pm Bug 30897: Remove recursive parent identification loop 2024-04-11 16:53:43 +02:00
ProblemReport.pm
…
ProblemReports.pm
…
PseudonymizedTransaction.pm Bug 39652: Rename new_from_statistic 2025-09-29 10:00:07 +02:00
PseudonymizedTransactions.pm
…
Quote.pm
…
Quotes.pm Bug 40242: Remove double operator in Quotes.pm 2025-07-25 16:11:15 +02:00
Rating.pm
…
Ratings.pm
…
Recall.pm Bug 23781: SMS notices and messaging preferences for recalls 2024-07-23 16:38:08 +01:00
Recalls.pm Bug 32696: Recalls can inadvertently extend the due date 2024-08-19 17:29:54 +02:00
RecordProcessor.pm
…
RecordSource.pm Bug 37513: Add Koha::RecordSource->usage_count 2024-08-27 12:14:24 +02:00
RecordSources.pm Bug 35919: Add Koha::RecordSource(s) classes 2024-04-26 17:06:03 +02:00
Report.pm Bug 32413: Fix repeated param names for JSON report 2024-10-30 07:47:48 +01:00
Reports.pm
…
Review.pm
…
Reviews.pm
…
Schema.pm
…
Script.pm Bug 36367: Remove _new_userenv 2024-06-14 11:17:17 +01:00
SearchEngine.pm
…
SearchField.pm Bug 20388: (QA follow-up) Tidy 2024-04-16 17:59:47 +02:00
SearchFields.pm
…
SearchFilter.pm Bug 39020: Search filters can't parse query 2025-10-03 15:51:56 +02:00
SearchFilters.pm
…
SearchMarcMap.pm
…
SearchMarcMaps.pm
…
Serial.pm
…
Serials.pm
…
Session.pm
…
SharedContent.pm Bug 27490: Update systempreference 'language' to 'StaffInterfaceLanguages' 2024-09-13 13:54:25 +02:00
SimpleMARC.pm Bug 32950: (follow-up) Fix copy_field regression for cross-field operations 2025-10-31 15:50:33 +00:00
Sitemapper.pm
…
Statistic.pm Bug 37540: Ensure datetime is a string before enqueueing pseudonymization 2024-08-01 18:22:27 +02:00
Statistics.pm
…
StockRotationItem.pm Bug 28294: Remove updateWrongTransfer 2024-11-07 18:49:36 +01:00
StockRotationItems.pm
…
StockRotationRota.pm
…
StockRotationRotas.pm
…
StockRotationStage.pm Bug 39717: Use numeric comparison for stock rotation stages 2025-09-29 10:06:37 +02:00
StockRotationStages.pm
…
Subscription.pm
…
Subscriptions.pm
…
Suggestion.pm Bug 35597: Move modification logging to Koha::Suggestion 2024-06-13 14:08:33 +01:00
SuggestionEngine.pm
…
Suggestions.pm
…
Tag.pm
…
Tags.pm
…
TemplateUtils.pm Bug 39184: Turn off ABSOLUTE and EVAL_PERL for user-entered templates 2025-05-26 20:48:04 +02:00
Ticket.pm Bug 36758: (follow-up) Fix unit tests 2024-08-12 14:01:08 +02:00
Tickets.pm
…
Token.pm
…
TrackedLink.pm
…
TrackedLinks.pm
…
UploadedFile.pm
…
UploadedFiles.pm
…
Uploader.pm Bug: 36818 Escape characters in file names uploaded 2024-06-20 17:55:37 +02:00
Virtualshelf.pm Bug 33440: Added permission requirements to unauthorized_transfer 2025-07-25 14:30:31 +02:00
Virtualshelfcontent.pm
…
Virtualshelfcontents.pm
…
Virtualshelfshare.pm
…
Virtualshelfshares.pm
…
Virtualshelves.pm Bug 28965: (QA follow-up) Fix misc qa issues 2024-11-08 16:09:22 +01:00
Z3950Responder.pm
…
Z3950Server.pm
…
Z3950Servers.pm
…