Koha-clms/circ
Joonas Kylmälä e5458fe73e Bug 28167: Remove uninitialized variable warnings from circ/set-library.pl
With UseCashRegisters syspref disabled going to the page
/cgi-bin/koha/circ/set-library.pl in staff interface and setting a
library gives the following errors in plack-intranet-error.log:

Use of uninitialized value $register_id in string ne at /kohadevbox/koha/circ/set-library.pl line 79.
Use of uninitialized value $referer in pattern match (m//) at /kohadevbox/koha/circ/set-library.pl line 114.

In the if clause $userenv_register_id appears to be typoed, it should have
been $register_id as $userenv_register_id is always defined. As for the
$referer variable, it is undef if there is no referer so let's just initialize
it to an empty string for the regex so it doesn't give the warning.

To test:
 1) Go directly to /cgi-bin/koha/circ/set-library.pl by typing it in
    the URL bar and set a library
 2) Make sure plack-intranet-error.log doesn't contain the above mentioned errors
    after applying this patch

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 8e25fa1dc5)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 513b1160bc)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
2022-11-14 17:48:03 +01:00
..
add_message.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
article-request-slip.pl Bug 29771: Scalar context for split 2022-03-11 06:35:50 -05:00
article-requests.pl Bug 27944: Add "requested" stage in article request process 2021-10-05 10:58:14 +02:00
bookcount.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
branchoverdues.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
branchtransfers.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
checkout-notes.pl Bug 29380: Correct table name in joins to prevent errors 2021-11-03 15:40:52 +01:00
circulation-home.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
circulation.pl Bug 30110: Fix concatenation during assignements 2022-03-25 10:40:18 -04:00
del_message.pl Bug 29903: Prevent messages to be deleted from unauthorised users 2022-01-25 14:44:56 -05:00
hold-transfer-slip.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
offline-mf.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
offline.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
on-site_checkouts.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
overdue.pl Bug 30282: overdues report does not display subtitle, part_name, part_number 2022-03-25 10:36:19 -04:00
pendingreserves.pl Bug 30935: Holds to pull shows wrong first patron 2022-08-26 15:11:36 +02:00
renew.pl Bug 29380: Correct table name in joins to prevent errors 2021-11-03 15:40:52 +01:00
request-article.pl Bug 29093: Interface changes 2021-10-15 11:34:26 +02:00
reserveratios.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
returns.pl Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON 2022-05-06 13:49:23 -04:00
set-library.pl Bug 28167: Remove uninitialized variable warnings from circ/set-library.pl 2022-11-14 17:48:03 +01:00
transfer-slip.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
transfers_to_send.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
transferstoreceive.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
view_holdsqueue.pl Bug 29015: Add options for itemtype, collection, and shelving location to view_holdsqueue.pl 2021-11-03 15:40:52 +01:00
waitingreserves.pl Bug 29771: Scalar context for split 2022-03-11 06:35:50 -05:00
ysearch.pl Bug 30251: (bug 10902 follow-up) With IndependentBranches non-superlibrarians do not get autocomplete list in circulation module 2022-04-01 06:36:48 -04:00