Go to file
David Cook 276602aadb Bug 26231: Remove incorrect use of AddAuthority() when 001 present
This patch removes the use of AddAuthority with a non-empty
authid argument, since that triggers an update rather than an insert.

In practice, the update also fails, but the error isn't raised,
as the database connection doesn't have RaiseError set.

Test plan:
1) Do not apply patch
2) Try to bulkmarcimport an authority file with a 001
3) Observe that the script reports success but no authority is added
4) Apply the path
5) Try to bulkmarcimport an authority file with a 001
6) Observe that the script reports success and the authority is added

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 9622561636)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2020-10-16 16:09:13 +00:00
C4 Bug 25265: [20.05.x] Prevent double reindex of the same item in batchmod 2020-10-16 14:15:22 +00:00
Koha Bug 24807: [20.05.x] Add "year" type to improve sorting behaviour 2020-10-16 14:27:07 +00:00
acqui Bug 10921: Prevent an order from a closed basket to be edited 2020-10-16 14:56:45 +00:00
admin Bug 24807: [20.05.x] Add "year" type to improve sorting behaviour 2020-10-16 14:27:07 +00:00
api/v1 Bug 26271: Add null to the list of accepted account_line data types 2020-09-14 21:35:32 +00:00
authorities Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
basket Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
catalogue Bug 24663: (follow-up) Remove authnotrequired if set to 0 2020-08-31 20:04:45 +00:00
cataloguing Bug 15933: Add +x to the script 2020-10-16 14:52:21 +00:00
circ Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
clubs Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
course_reserves Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
debian Bug 26448: Don't overwrite commit parameter passed to koha-elasticsearch 2020-10-16 15:28:25 +00:00
docs Bug 21395: (QA follow-up) Remove some introduced issues 2020-07-13 16:45:15 +00:00
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 26253: (bug 22857 follow-up) Remove duplicated mana_config in etc/koha-conf.xml 2020-08-31 20:06:11 +00:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer Bug 26341: Database update for bug 21443 is not idempotent and will destroy settings 2020-10-16 16:00:09 +00:00
koha-tmpl Bug 10921: Prevent an order from a closed basket to be edited 2020-10-16 14:56:45 +00:00
labels Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
members Bug 26076: (QA Follow up) Prevent error by using a fresh resultset 2020-09-04 17:56:04 +00:00
misc Bug 26231: Remove incorrect use of AddAuthority() when 001 present 2020-10-16 16:09:13 +00:00
offline_circ Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
opac Bug 26464: Code correction in opac-main when news_id passed 2020-10-16 15:03:14 +00:00
patron_lists Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
patroncards Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
plugins Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
pos Bug 26023: Properly secure the cashup and refund actions 2020-09-04 17:43:21 +00:00
reports Bug 17801: Use issuedate for limits in Most Circulated Items 2020-09-14 21:43:59 +00:00
reserve Bug 24683: Subroutine name changed (fix), no code logic changed This is the intermediate refactor: renamed subroutine only. 2020-09-04 17:48:22 +00:00
reviews Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
rotating_collections Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
serials Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel
…
suggestion Bug 24819: (follow-up) Rename suggestor to suggester 2020-04-20 13:36:42 +01:00
svc Bug 26331: Make svc/letters/preview executable 2020-09-14 21:22:22 +00:00
t Bug 24807: [20.05.x] Add "year" type to improve sorting behaviour 2020-10-16 14:27:07 +00:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
tmp/modified_authorities
…
tools Bug 25265: [20.05.x] Prevent double reindex of the same item in batchmod 2020-10-16 14:15:22 +00:00
virtualshelves Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
xt Bug 26265: add a plan for tests 2020-09-02 14:32:44 +00:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.perlcriticrc Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL
…
Koha.pm Bug 24807: DBRev 20.05.04.001 2020-10-16 14:45:45 +00:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 26265: Add missing xt dir 2020-09-02 14:32:13 +00:00
README
…
README.md
…
README.robots
…
about.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
cpanfile Bug 25723: Drop DateTime::Set from cpanfile 2020-07-27 17:38:47 +00:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
gulpfile.js Bug 26228: Update gulpfile to work with Node.js v12 2020-09-03 14:49:31 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl
…
mainpage.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
package.json Bug 26228: Update gulpfile to work with Node.js v12 2020-09-03 14:49:31 +00:00
rewrite-config.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-07-28 14:46:44 +00:00
yarn.lock Bug 26228: Update gulpfile to work with Node.js v12 2020-09-03 14:49:31 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo