2b0bd07a2d
This patch introduces tests for the per_page=-1 handling use case. From
now on per_page=-1 means 'all resources'.
On writing this I noticed that we always paginate results no matter
what, but there was a weird condition under which on pagination headers
were sent back to the API consumer. This is highlighted in the precedent
patch, which is not the -1 situation this one tries to tackle.
Both pagination and searching are broken with per_page=-1, which is a
standard, and we actually didn't explicitly set a way to request all
resources.
To verify this:
1. Apply the previous tests patch and this one
2. Run:
$ kshell
k$ prove t/Koha/REST/Plugin/Pagination.t \
t/db_dependent/Koha/REST/Plugin/Objects.t
=> FAIL: Things are damn broken
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| Authority | ||
| I18N/po/xx_XX/LC_MESSAGES | ||
| Middleware | ||
| Plugins | ||
| REST/Plugin | ||
| SearchEngine | ||
| Util | ||
| Config.t | ||
| Exceptions.t | ||
| I18N.t | ||
| ItemType.t | ||
| RDF.t | ||
| Script.t | ||
| Script_cron.t | ||
| Z3950responder.t | ||