952933c31e
HTML1 is gone. Almost... The previous rule said that we could not have TT tags within HTML tags because it caused problems with the translation. It was incorrect. Bug 38720 removed that rule, and stated that the only problematic use was a IF with ">". It was also incorrect. This one bug states that we cannot have TT tags to construct HTML tags IF one of the attribute contains a translatable string. The list of translatable attributes are listed in tmpl_process3.pl. This patch restores xt/tt_valid.t (and move it to xt/author) and adjust slightly the test to take into account this last statement. Test plan: 0. Apply only this first patch 1. Run xt/author/tt_valid.t => It fails on mana-subscription-search-result.inc 2. Update po for your prefered language => The string "This resource has been reported more than" is not in the po files 3. Apply the second patch, repeat 1 and 2 => It still fails: adding a space between the TT tag and the attribute is not enough here => The string is picked now! but... install the template and open the translated version => 4. Apply the third patch, repeat 1 and 2 => The tests pass! => The string is still picked, install => The template looks good! Now if you are familiar with Mana you can try to see the translated string on the UI Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> |
||
|---|---|---|
| .. | ||
| Text_CSV_Various.t | ||
| codespell.t | ||
| icondirectories.t | ||
| pod_checker.t | ||
| pod_coverage.t | ||
| podcorrectness.t | ||
| show-template-structure.pl | ||
| tt_valid.t | ||
| valid-templates.t | ||