Go to file
Tomas Cohen Arazi 1e4ca48931 Bug 31106: Make clean_search_term escape double quotes
We noticed that several characters will break Zebra queries. So search
terms need to be quoted for things to work. In this context, double
quotes inside search terms are problematic because double quotes are
what we use for quoting strings.

This patch makes the clean_search_term method escape double quotes.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t
=> FAIL: It doesn't work as it should!
3. Apply this patch
4. Repeat 2
=> SUCCESS: It does the job!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 24bb15785d)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 2e063b708d)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
2022-08-16 10:46:01 +02:00
C4 Bug 30969: Cross site scripting (XSS) attack in OPAC authority search ( opac-authorities-home.pl ) 2022-07-25 10:27:24 +02:00
Koha Bug 31106: Make clean_search_term escape double quotes 2022-08-16 10:46:01 +02:00
acqui Bug 29771: Remove trivial cases 2022-03-11 06:35:45 -05:00
admin Bug 30848: Add an ExpandCodedFields RecordProcessor filter 2022-08-11 15:40:33 +02:00
api Bug 30663: Add x-koha-override options to /suggestions 2022-05-13 15:09:28 -04:00
authorities Bug 29334: Do not apply defaultvalue to existing auth record 2021-11-15 12:38:39 +01:00
basket Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
catalogue Bug 30997: Fix "CGI::param called in list context" warning in detail.pl 2022-07-21 16:31:19 +02:00
cataloguing Bug 31179: Don't copy invisible subfields when duplicating items 2022-08-16 10:42:56 +02:00
circ Bug 30337: Holds to Pull ( pendingreserves.pl ) ignores holds if priority 1 hold is suspended 2022-06-21 14:54:10 +02:00
clubs Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
course_reserves Bug 30840: Add support for barcode filters to course reserves 2022-06-21 15:40:30 +02:00
debian Bug 25622: Use special chars in DB password (koha-create) 2022-08-12 09:30:43 +02:00
docs Bug 30808: Add the 22.05 release team. 2022-06-27 16:17:16 +02:00
errors Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
etc Bug 29957: Add example lines in koha-conf.xml 2022-04-15 07:15:21 -04:00
ill Bug 22614: Migrate original request 2021-09-21 20:22:57 +02:00
installer Bug 30775: Make 952w to have datepicker plugin by default 2022-08-11 15:04:44 +02:00
koha-tmpl Bug 30837: Fix table width on 'Print summary' 2022-08-16 09:27:11 +02:00
labels Bug 25616: [21.11.x] (QA follow-up) Catch a case in labels/label-item-search.pl 2022-03-04 09:20:36 -05:00
lib/CGI/Session/Serialize Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
members Bug 17648: (QA follow-up) Restore imediate sending of the notice 2022-03-25 09:32:21 -04:00
misc Bug 30914: (24153 follow-up) Fix cleanup_database.pl --transfers --old-reserves 2022-08-12 10:13:01 +02:00
offline_circ Bug 30525: Items batch modification broken 2022-04-22 14:29:43 -04:00
opac Bug 30918: Allow passing filtered record to get_marc_notes 2022-08-11 17:05:40 +02:00
patron_lists Bug 16446: Add ability to add patrons to list by borrowernumber 2021-10-21 12:24:04 +02:00
patroncards Bug 24001: Fix patron card template edition 2022-05-06 13:47:21 -04:00
plugins Bug 29787: Add plugin version to plugin search results 2022-04-15 06:36:54 -04:00
pos Bug 28481: (RM follow-up) formatting 2021-12-17 10:04:21 -05:00
reports Bug 30551: Make cash register report take branchcode from cash register 2022-06-27 10:59:12 +02:00
reserve Bug 30207: Allow any reserveforothers subpermission to access the page 2022-07-21 11:30:39 +02:00
reviews Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
rotating_collections Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
serials Bug 30377: Fix two CGI::param called in list context-warnings 2022-04-08 10:40:16 -04:00
services Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
skel
…
suggestion Bug 24370: Allow resetting library to ANY 2021-11-02 14:57:04 +01:00
svc Bug 26669: (QA follow-up) Update last run when report run by name 2022-04-08 10:46:13 -04:00
t Bug 31106: Unit tests 2022-08-16 10:45:54 +02:00
tags Bug 29469: (bug 17600 follow-up) Fix tag approval/rejection from staff 2021-11-16 15:49:22 +01:00
tmp/modified_authorities
…
tools Bug 22659: (follow-up) Add category to redirect 2022-08-11 11:46:54 +02:00
virtualshelves Bug 29542: Prevent access to private list to non authorized users 2022-01-25 14:43:23 -05:00
xt Bug 27622: Fix sample_notices.t 2021-10-07 15:49:01 +02:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json
…
.gitignore
…
.htaccess
…
.mailmap 21.11.00 - Update .mailmap 2021-11-26 12:26:22 +01:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.scss-lint.yml
…
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Increment version for 21.11.10 release 2022-07-22 13:07:30 +02:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
README
…
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
…
about.pl Bug 28870: Move email address validation to a specific class method 2021-09-28 10:22:36 +02:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 28610: Elasticsearch 7 - hits.total is now an object 2022-04-08 10:41:05 -04:00
fix-perl-path.PL Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
gulpfile.js Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
help.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
koha_perl_deps.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
mainpage.pl Bug 29020: Add link on the mainpage for users without admin access 2021-10-19 09:29:09 +02:00
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo