Koha-clms/Koha
Mark Tompsett e1b5fa657d Bug 14385: Squash of a lot of patches rebased
- Added missing GetHiddenItems parameter change case
     Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
     There was a typo botcat vs borcat and borrowernumber was never
     defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
     This will test all the if structures fully in GetHiddenItemnumbers.
         prove t/db_dependent/Items.t

- Tweak borrower category code
     $borrower->{categorycode} on a Koha::Patron is not the
     same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
     There was one search context place wrong. Changed it to $is_opac
     as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
     When a user isn't logged in, $borrower is undef and causes error
     when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
     C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
     prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
     These files generally add borcat parameter to GetMarcBiblio.
     Others might include correction of filtering of items
     (opac-basket), or a comment as to why no changes were done
     (opac-search).

     In the case of opac-search, correcting the first FIXME will
     likely correct the OpacHiddenItems issues on tags. As such,
     that is beyond this bugs scope.

     Some code had loop optimizations and fixes made, like a
     'next unless $record' when the biblio shouldn't even be in
     the list.

- Modify opac-ISBDdetail and opac-MARCdetail
     Both files had similar logic. They were rearranged and
     optimized, so that both files would have practically identical
     initial blocks of code.

     Optimizations were possible, because GetMarcBiblio
     returns a filtered record, so that there is no double call
     (once in the opac-### file and once in GetMarcBiblio) to
     GetHiddenItemnumbers.

- Fix hiding in opac-tags
     opac/opac-tags.pl was not properly hiding.

     There is currently one known bug associated with tags left.
     If you have two biblios tagged by different people with the
     same tag, the opac-search will show the one you tagged that
     is supposed to be hidden, because tag searches work differently
     than regular searches. This is beyond the scope of this bug.
     See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
     prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!
- Rebased t/db_dependent/Items.t conflict.

The test plan is in comment #112 last I checked.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-11-02 10:33:12 +00:00
..
Account Bug 13098: Fix POD for Koha::Account::Offsets::total 2018-10-31 13:13:38 +00:00
Acquisition Bug 20366: Add new method Koha::Acquisition::Basket->basket_group 2018-08-30 13:48:08 +00:00
ArticleRequest
…
Authority
…
Biblio
…
BiblioUtils Bug 14385: Squash of a lot of patches rebased 2018-11-02 10:33:12 +00:00
Cache
…
Club
…
Config
…
Edifact Bug 21425: Display basketno correctly in Order error msg 2018-10-01 13:56:19 +00:00
Exceptions Bug 21337: (QA follow-up) Rename exception code 2018-10-26 16:06:57 +00:00
Exporter Bug 14385: Squash of a lot of patches rebased 2018-11-02 10:33:12 +00:00
ExternalContent Bug 21082: Update OverDrive authentication method 2018-10-09 11:04:23 +00:00
Filter/MARC
…
Illrequest Bug 20996: (QA follow-up) Fix pod 2018-11-02 10:33:07 +00:00
Indexer
…
Item
…
Library Bug 21082: Add new admin page for overdrive 2018-10-09 11:04:23 +00:00
List
…
MetadataRecord
…
Middleware
…
Misc
…
Notice
…
Number Bug 21262: Do not format numbers for editing if too big 2018-09-15 23:59:59 +00:00
OAI/Server
…
Object/Limit
…
Old Bug 21432: (bug 20899 follow-up) Fix patron's name display for deleted patrons 2018-10-03 17:18:44 +00:00
Patron Bug 20819: Add Koha object classes for patron consents 2018-09-20 13:45:25 +00:00
Patrons Bug 21596: Handle empty string for date_renewed when storing a patron 2018-10-18 14:17:39 +00:00
Plugins Bug 20669: Add upgrade method to plugins 2018-09-26 16:29:05 +00:00
QueryParser/Driver
…
REST Bug 20996: (follow-up) Fix merge problems 2018-11-02 10:33:06 +00:00
RecordProcessor
…
SMS
…
Schema/Result Bug 18591: Add missing schema file 2018-10-27 15:03:03 +00:00
SearchEngine
…
Serial
…
Sitemapper
…
Subscription
…
SuggestionEngine
…
Template/Plugin Bug 21593: Remove GROUP BY from GetAuthValueDropbox 2018-10-18 11:54:25 +00:00
Util Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
Account.pm Bug 21694: Keep the context 2018-10-31 13:51:07 +00:00
AdditionalField.pm
…
ApiKey.pm
…
ApiKeys.pm
…
ArticleRequest.pm
…
ArticleRequests.pm
…
AudioAlert.pm
…
AudioAlerts.pm
…
AuthUtils.pm
…
AuthorisedValue.pm
…
AuthorisedValueCategories.pm
…
AuthorisedValueCategory.pm
…
AuthorisedValues.pm
…
Authorities.pm
…
Authority.pm
…
Biblio.pm Bug 17530: (QA follow-up) Move may_article_request to ItemType 2018-09-07 13:16:08 +00:00
BiblioFramework.pm
…
BiblioFrameworks.pm
…
BiblioUtils.pm
…
Biblioitem.pm
…
Biblioitems.pm
…
Biblios.pm
…
Cache.pm
…
Caches.pm
…
Calendar.pm
…
Checkout.pm
…
Checkouts.pm
…
CirculationRule.pm Bug 18887: Fix POD c/p issues 2018-10-03 17:58:16 +00:00
CirculationRules.pm Bug 18887: Replace croak with exceptions 2018-10-03 17:58:17 +00:00
Cities.pm
…
City.pm
…
ClassSortRule.pm
…
ClassSortRules.pm
…
ClassSource.pm
…
ClassSources.pm
…
Club.pm
…
Clubs.pm
…
Config.pm
…
CsvProfile.pm
…
CsvProfiles.pm
…
Database.pm Bug 21613: (QA follow-up) Resolve warning on $ENV{_} - avoid autovivification 2018-10-29 00:41:27 +00:00
DateUtils.pm
…
EDI.pm Bug 21417: EDI ordering fails when basket and EAN libraries do not match 2018-10-09 11:54:08 +00:00
Edifact.pm
…
Email.pm
…
Exceptions.pm
…
ExternalContent.pm Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than die if user not logged in 2018-10-01 13:56:38 +00:00
FieldMapping.pm
…
FieldMappings.pm
…
FrameworkPlugin.pm
…
Hold.pm
…
Holds.pm
…
I18N.pm
…
Illcomment.pm Bug 18591: (follow-up) Add more POD 2018-10-27 13:15:59 +00:00
Illcomments.pm Bug 18591: Fix pluralization of type 2018-10-27 15:53:34 +00:00
Illrequest.pm Bug 20996: (follow-up) Fix merge problems 2018-11-02 10:33:06 +00:00
Illrequestattribute.pm
…
Illrequestattributes.pm
…
Illrequests.pm
…
IssuingRule.pm
…
IssuingRules.pm Bug 17530: (QA follow-up) Fix caching error 2018-09-07 13:16:10 +00:00
Item.pm Bug 11897: (QA follow-up) Remove rebase leftover 2018-10-09 15:46:05 +00:00
ItemType.pm Bug 21599: Fix item type creation by defining default values 2018-10-18 14:17:56 +00:00
ItemTypes.pm
…
Items.pm
…
Libraries.pm
…
Library.pm Bug 11897: (QA follow-up) Remove rebase leftover 2018-10-09 15:46:05 +00:00
Linktracker.pm
…
Localization.pm
…
Localizations.pm
…
Logger.pm
…
Manual.pm Bug 19817: (QA follow-up) Add German manual and fix system preference help files 2018-09-06 17:32:29 +00:00
MarcSubfieldStructure.pm
…
MarcSubfieldStructures.pm
…
MetaSearcher.pm
…
MetadataIterator.pm
…
MetadataRecord.pm
…
MoreUtils.pm
…
News.pm
…
NewsItem.pm
…
OAuth.pm
…
OAuthAccessToken.pm
…
OAuthAccessTokens.pm
…
Object.pm
…
Objects.pm
…
Patron.pm Bug 21596: (follow-up) Handle updated_on part 2 2018-10-30 12:07:35 +00:00
Patrons.pm Bug 21337: (QA follow-up) Rename exception code 2018-10-26 16:06:57 +00:00
Plugins.pm
…
RDF.pm
…
Rating.pm
…
Ratings.pm
…
RecordProcessor.pm
…
RefundLostItemFeeRule.pm
…
RefundLostItemFeeRules.pm
…
Report.pm
…
Reports.pm
…
Review.pm
…
Reviews.pm
…
Schema.pm
…
SearchEngine.pm
…
SearchField.pm
…
SearchFields.pm
…
SearchMarcMap.pm
…
SearchMarcMaps.pm
…
Serial.pm
…
Serials.pm
…
SimpleMARC.pm
…
Sitemapper.pm
…
StockRotationItem.pm Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationItems.pm Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationRota.pm Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationRotas.pm Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationStage.pm Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationStages.pm Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
Subscription.pm
…
Subscriptions.pm
…
Suggestion.pm
…
SuggestionEngine.pm
…
Suggestions.pm
…
Token.pm
…
UploadedFile.pm
…
UploadedFiles.pm
…
Uploader.pm
…
Virtualshelf.pm
…
Virtualshelfcontent.pm
…
Virtualshelfcontents.pm
…
Virtualshelfshare.pm
…
Virtualshelfshares.pm
…
Virtualshelves.pm Bug 21612: Remove incorrect GROUP BY's from Koha::VirtualShelves 2018-10-26 16:31:25 +00:00
XSLT_Handler.pm
…
Z3950Server.pm
…
Z3950Servers.pm
…