Go to file
Michael Hafen 1b2ac303aa Bug 18855: Don't create duplicate overdue fines if an issue is returned
This includes Jonathan's followup

If cronjobs/fines.pl is running during circulation hours, then an issue may
be considered for having it's overdue fine updated after the issue has been
returned and it's fine status flipped from 'UNRETURNED' to 'RETURNED'.  In
this case UpdateFine will create a duplicate fine because it can't find the
specific accountline for the (formerly) overdue issue.

This changes cronjobs/fines.pl to double check the issue before updating
the fine.  If the issue has changed between starting the script and updating
the fine, then the script will skip it.

There is a small amount of time between the check and calling UpdateFine
where the issue can be changed and this problem can reoccure.  The chance
of that happening is so small that it's probably fine to leave as is.

It is also possible that the fine won't be updated because the issue was
returned.  In this case the fine payed by the patron will be lower, but that
is better then the patron finding later that there is more to a fine they
thought they had paid all of.

Test plan (by Caroline):
0. Preliminary settings
   0.1. finesMode system preference must be set to Calculate and charge
   0.2. There must be a circulation rule that will charge fines (beware of bug 32271)
   0.3. In Tools > Calendar, today must not be a holiday

1. Make a lot of overdue checkouts - I used the batch checkout feature, but if your system already has a lot of overdue checkouts, you can skip to step 2

   1.1. Enable batch checkouts
        1.1.1. Go to Administration > Global system preferences
        1.1.2. Search for BatchCheckouts
        1.1.3. Set BatchCheckouts to Allow
        1.1.4. Select all categories in BatchCheckoutsValidCategories
        1.1.5. Click "Save all Circulation preferences"

   1.2. Get a list of barcodes
        1.2.1. Go to Reports
        1.2.2. Click "Create from SQL"
        1.2.3. Give the report a name
        1.2.4. For the SQL query, enter

               SELECT barcode FROM items WHERE onloan IS NULL LIMIT 60;

	1.2.5. Click "Save report"
	1.2.6. Click "Run report"
	1.2.7. Click "Download" > "Tab separated text"

   1.3. Go to a patron's file
        1.3.1. Go to Patrons
        1.3.2. Click on "Search"
        1.3.3. Click on a patron's name

   1.4. Do a batch checkout with a due date in the past
        1.4.1. Click on the "Batch check out" tab on the left
        1.4.2. In "Use a file", click "Choose file"
        1.4.3. Choose the file downloaded from the report
        1.4.4. In "Hard due date", choose a date in the past
        1.4.5. Click "Check out"
        1.4.6. Click "Checkout or renew"

2. Find the last issue in the database

   2.1. In the database (or in reports), type the following query

        SELECT issues.*, items.itype as itemtype, items.homebranch, items.barcode, items.itemlost, items.replacementprice, items.biblionumber FROM issues  LEFT JOIN items USING (itemnumber) WHERE date_due < NOW() \G;

   2.2. Copy the barcode from the last entry

3. Set up so that you can run fines.pl and check in the item at the same time (or very close to the same time)

   3.1. In Koha, click the "Check in" option in the search bar at the top of the page
   3.2. Paste the barcode in the search bar BUT DO NOT PRESS ENTER OR THE ARROW RIGHT AWAY
   3.3. In a terminal, enter the fines.pl command

        ./misc/cronjobs/fines.pl

   3.4. Execute the command and immediately click on the arrow in the staff interface to check in the item

4. Check the patron's fines

    4.1. Click on the patron's name in the check in screen
    4.2. Go to the Accounting tab on the left
    4.3. In the search box just above the table, paste in the returned item's barcode

    --> Without the patch, there are two fines, one Fine (Accruing) and one Fine (Returned) for the same item at the same time
    --> With the patch, there is only one fine, Fine (Returned)

Signed-off-by: Sam Lau <samalau@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 7e1104da83)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 931e2b2d52)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
2023-07-18 13:32:48 +00:00
C4 Bug 33879: Do no longer overwrite interface in check_cookie_auth 2023-07-18 13:27:57 +00:00
Koha Bug 33497: Add a filter relationship for branchtransfers 2023-07-18 13:27:58 +00:00
acqui Bug 33653: Use filter_by_active instead 2023-05-15 12:06:44 +00:00
admin Bug 33578: Fix controller when editing a restriction type 2023-07-18 11:24:05 +00:00
api Bug 34130: Make requested_date nullable in api definition 2023-07-18 11:40:27 +00:00
authorities Bug 33803: Remove comment about tab width 2023-06-12 10:28:26 +00:00
basket Bug 33102: Display fields from biblioitems in OPAC/staff interface cart 2023-05-12 16:34:19 +01:00
bin
…
catalogue Bug 33497: (follow-up) Adjust relationship name from bug 33493 2023-07-18 13:27:59 +00:00
cataloguing Bug 34146: Do not allow multiple copies to crash server 2023-07-18 13:11:35 +00:00
circ Bug 34094: Use DefaultPatronSearchMethod consistently 2023-07-18 13:11:38 +00:00
clubs Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
course_reserves Bug 31893: Use checkauth and do not fetch about.tt template 2023-01-31 14:09:05 +00:00
debian Bug 33371: Add [Install] section to koha-common.service 2023-06-08 16:59:56 +00:00
docs Bug 33899: Add the 23.11 release team 2023-07-12 09:36:01 +00:00
erm Bug 32922: Remove space in shebang 2023-02-24 07:51:37 +00:00
errors Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI 2022-04-20 09:03:39 -10:00
etc Bug 24517: Add missing 6th position to date-entered-on-file index 2023-07-18 10:47:02 +00:00
ill Bug 28909: Allow illview to use backend template 2022-08-09 13:21:39 -03:00
installer Bug 33720: Also flush in install 2023-07-18 13:00:03 +00:00
koha-tmpl Bug 34180: Template variable in JavaScript prevents authority MARC preview from displaying 2023-07-18 13:13:43 +00:00
labels Bug 31633: (follow-up) Group template params 2022-10-03 14:09:59 -03:00
lib/CGI/Session/Serialize
…
members Bug 34094: Use DefaultPatronSearchMethod consistently 2023-07-18 13:11:38 +00:00
misc Bug 18855: Don't create duplicate overdue fines if an issue is returned 2023-07-18 13:32:48 +00:00
offline_circ Bug 30016: Remove GetOpenIssue subroutine 2022-08-31 08:50:37 -03:00
opac Bug 33957: Add normalized_oclc and only fetch when needed 2023-07-12 09:36:04 +00:00
patron_lists
…
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins Bug 30367: (follow-up) Same adjustment for gitlab 2023-05-12 15:58:09 +01:00
pos Bug 30619: Add email receipt to POS 2022-09-07 15:59:34 -07:00
recalls Bug 34013: Recalls awaiting pickup doesn't show count on each tab 2023-07-18 11:21:31 +00:00
reports Bug 29664: (QA follow-up) Typo transacton 2023-07-18 13:11:38 +00:00
reserve Bug 30687: Allow pickup location to be forced when override is allowed 2023-05-15 13:01:46 +00:00
reviews
…
rotating_collections
…
serials Bug 34146: Counterpart for serials-edit 2023-07-18 13:11:36 +00:00
services
…
skel
…
suggestion Bug 33421: Fix filtering suggestions by status 2023-06-08 16:43:04 +00:00
svc Bug 33944: Don't fetch item object unless using recalls 2023-07-18 11:11:10 +00:00
t Bug 33496: Add 'host_items' param to Koha::Biblio->items 2023-07-18 13:27:57 +00:00
tags Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
tools Bug 33989: Only look up authorized value descriptions for items in results 2023-07-18 11:33:35 +00:00
virtualshelves Bug 16522: (follow-up) MARC display templates and get_marc_host fixes 2023-01-31 17:15:27 +00:00
xt Bug 30002: Remove unused xt/perltidyrc 2023-07-12 09:16:19 +00:00
.editorconfig
…
.eslintrc.json
…
.gitignore Bug 33710: Ignore how-to related files 2023-05-15 13:03:55 +00:00
.htaccess
…
.mailmap Update .mailmap 2023-07-18 09:22:47 +00:00
.perlcriticrc
…
.perltidyrc Bug 30002: Adjust perltidy 2023-07-12 09:16:19 +00:00
.proverc.dist
…
.stylelintrc.json Bug 31528: (follow-up) A few additional rules 2022-10-03 08:23:15 -03:00
INSTALL
…
Koha.pm Bug 34029: DBRev 22.11.07.003 2023-07-18 11:53:29 +00:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 30002: (QA follow-up) Add .perltidyrc to Makefile.PL mapping 2023-07-12 09:41:28 +00:00
README
…
README.md
…
README.robots
…
about.pl Bug 33934: Add more detail to 'No encryption_key in koha-conf.xml' 2023-06-12 11:53:36 +00:00
app.psgi
…
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-03-10 12:27:47 +00:00
changelanguage.pl
…
cpanfile Bug 32558: (QA follow-up) Move ForkManager to required 2023-03-08 14:39:16 +00:00
cypress.json Bug 33408: Extend defaultCommandTimeout for cypress 2023-05-15 13:15:43 +00:00
fix-perl-path.PL
…
gulpfile.js Bug 32609: Improve yarn build commands 2023-03-10 12:27:27 +00:00
help.pl
…
koha_perl_deps.pl
…
kohaversion.pl
…
mainpage.pl Bug 33133: Add fast cataloging to 'Cataloging' page 2023-04-11 10:51:27 +00:00
package.json Bug 33066: Introduce a KohaTable Vue component 2023-05-11 17:01:22 +01:00
rewrite-config.PL
…
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 32806: Move main-erm.ts to modules/erm.ts 2023-02-28 18:54:57 +00:00
yarn.lock Bug 33066: Introduce a KohaTable Vue component 2023-05-11 17:01:22 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo