gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
32,159 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Marcel de Rooy 15fd90dcbc Bug 19633: Use alphanumeric error codes in upload 
The error codes 1 to 7 are used in Uploader.pm or tools/upload.pl.
It would be nice to use alphanumeric codes instead.
No behavior change expected.

Test plan:
[1] Run t/db_dependent/Upload.t
[2] Verify that a regular upload with tools/upload.pl still works.
[3] Rename upload_path in your koha-conf.xml. Restart Plack, flush the cache
    and try to upload to a category. Correct error message?
[4] Upload the same file twice to the same category.
    Correct error message the second time?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Bug 19633: (QA follow-up) Really remove these ugly numbers

See BZ comment5. We now remove the numbers also from the constant names.

Test plan:
Read the changes.
Git grep "ERRCODE_"
Run t/db_dependent/Upload.t (Note: You may see one failure here; it is fixed
on bug 20727. So depends on who reaches master first.)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
 		2018-08-10 10:10:46 +00:00
C4 Bug 21188: Convert return_date to a DateTime object 2018-08-09 15:24:23 +00:00
Koha Bug 19633: Use alphanumeric error codes in upload 2018-08-10 10:10:46 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 21033: Remove few warns in acqui/basket.pl 2018-08-09 11:31:44 +00:00
admin Bug 19436: Add SRU support for authorities 2018-08-08 20:31:34 +00:00
api/v1 Bug 20942: Split debit and credit lines 2018-07-18 16:49:27 +00:00
authorities Bug 20273: Use compat routines for autocomplete in auth_finder.pl 2018-07-19 17:25:16 +00:00
basket Bug 16575: Irregular behaviour using window.print() followed by window.location.href 2018-07-19 16:12:56 +00:00
catalogue Bug 20919: Remove unecessary search calls on the biblio detail page 2018-07-13 10:34:29 +00:00
cataloguing Bug 19436: Add SRU support for authorities 2018-08-08 20:31:34 +00:00
circ Bug 21056: Add another flush later 2018-08-09 10:57:08 +00:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 20467: (QA follow-up) Display error if no or invalid course id is passed 2018-07-02 12:55:38 +00:00
debian Bug 21031: Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration 2018-08-02 10:23:08 -03:00
docs Bug 7143: Update timeline (2 new devs) 2018-08-08 21:25:50 +00:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 21031: Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration 2018-08-02 10:23:08 -03:00
ill Bug 20556: Marking ILL request as complete.. 2018-04-20 11:42:00 -03:00
installer Bug 21149: Fix superlibrarian creation in onboarding 2018-08-08 12:49:22 +00:00
koha-tmpl Bug 19633: Use alphanumeric error codes in upload 2018-08-10 10:10:46 +00:00
labels Bug 12020: Allow translating label-edit-batch hardcoded strings 2018-03-26 17:31:15 -03:00
members Bug 20828: Step 4 of moremember is used for Housebound and additional attributes 2018-08-09 11:28:58 +00:00
misc Bug 21035: Handle new lines when running reports 2018-08-09 11:18:55 +00:00
offline_circ Bug 19752: offline_circ/service.pl - Return HTTP status 401 when authentication failed and add option nocookie 2018-05-03 13:26:48 -03:00
opac Bug 21018: Allow uris defined in the item 2018-08-08 13:06:19 +00:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 8604: Patron cards made for patrons which don't have patron images use preceding card's image 2018-07-23 15:08:57 +00:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 20495: Remove get_saved_report 2018-07-02 12:06:54 +00:00
reserve Bug 20724: Move the ReservesNeedReturns logic to AddReserve 2018-05-16 10:53:13 -03:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
serials Bug 20730: Move the authentication block before doing anything 2018-05-23 11:44:10 -03:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-08 20:58:23 +00:00
svc Bug 17698: Make patron notes show up on staff dashboard 2018-07-23 15:23:40 +00:00
t Bug 19633: Use alphanumeric error codes in upload 2018-08-10 10:10:46 +00:00
tags Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 19633: Use alphanumeric error codes in upload 2018-08-10 10:10:46 +00:00
virtualshelves Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
xt Bug 20906: Fix translatable-templates.t 2018-06-22 12:59:09 +00:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.sass-lint.yml Bug 19474: (QA follow-up) Fix sass lint yaml configuration 2018-08-09 15:12:20 +00:00
.scss-lint.yml Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 11911: DBRev 18.06.00.012 2018-07-23 15:34:21 +00:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 18342: Enable memcached by default for new installs 2018-05-03 12:47:07 -03:00
README
…
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 20727: (QA follow-up) Remove a few use statements again 2018-06-22 16:10:10 +00:00
changelanguage.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
edithelp.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
help.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 17698: Do not send pending_checkout_notes from all circ scripts 2018-07-23 15:23:44 +00:00
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
rewrite-config.PL Bug 18342: Enable memcached by default for new installs 2018-05-03 12:47:07 -03:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo