gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/t/db_dependent
History
Andrew Nugged a831c288da Bug 24683: Subroutine name changed (fix), no code logic changed This is the intermediate refactor: renamed subroutine only. 
Naming mistake came because this sub is used to detect if anything
available for hold, but it used in "if ANY UNAVAILABLE rule", so actually
results of this sub negated (see below "return" in the code).

In details:

when previous refactor was done, name for subroutine was chosen
wrongly in "opposite" direction from what it actually does:

it was named "ItemsAnyAvailableForHold", but this subroutine gave
truth (1) if at least one of the items available on shelf, not lost,
not on loan, not held, and not restricted by smart rules and damaged
status. So, if this sub says that item is still "available", this
actually PREVENTS item from hold in parent sub (see negated return):

    sub IsAvailableForItemLevelRequest {
        ...
        my $any_available = ItemsAnyAvailableAndNotRestricted...
        return $any_available ? 0 : 1;
             # ^^^ if any available and not restricted - we don't allow
             #     on-shelf holds
        ...

I.e. like it named now: "ItemsAnyAvailableAndNotRestricted".

Small aside fix: white space for '&&' inside brackets added to join
operation by priority visually.

Testing plan not needed: all places where sub used it just renamed.
More: all this places/code was introduced in one older commit so there
is also no overlaps or other calls/uses for this subroutine.

Signed-off-by: Agustin Moyano <agustinmoyano@theke.io>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 618cf80df9)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
 		2020-09-04 17:48:22 +00:00
..
Acquisition Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
Auth Bug 20128: (QA follow-up) Corrections to haspermission 2019-04-17 12:25:26 +00:00
Authority Bug 22437: Add test case to Merge.t 2020-05-12 11:01:49 +01:00
Biblio Bug 24715: Cache repeatable subfield in TransformKohaToMarc 2020-04-17 09:25:06 +01:00
Circulation Bug 26078: Prevent generating a new transfer from return policy when resolving a transfer 2020-09-03 14:38:21 +00:00
CourseReserves Bug 25444: Add unit tests 2020-05-28 17:01:55 +02:00
Creators Bug 25852: Add tests 2020-08-13 16:24:34 +00:00
Exporter
…
Holds Bug 24683: Subroutine name changed (fix), no code logic changed This is the intermediate refactor: renamed subroutine only. 2020-09-04 17:48:22 +00:00
Illrequest Bug 23632: Remove C4::Logs::GetLogs 2020-09-04 14:39:36 +00:00
Items Bug 23463: Move DelItem.t and Items_DelItemCheck.t tests to a Koha/Item.t subtest 2020-03-23 09:26:33 +00:00
Koha Bug 23632: Remove C4::Logs::GetLogs 2020-09-04 14:39:36 +00:00
LDAP Bug 21395: (QA follow-up) Remove some introduced issues 2020-07-13 16:45:15 +00:00
Labels Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
Letters Bug 25629: Fix capitalization in sample notices 2020-07-28 14:59:34 +00:00
Members Bug 20443: Remove extended_attributes_code_value_arrayref AND C4::Members::Attributes 2020-03-23 13:49:22 +00:00
OAI Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Patron Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Record Bug 21395: Fix QA errors 2020-07-13 16:45:01 +00:00
Reports Bug 22001: Make the DBD error regex less strict 2020-03-31 17:46:21 +01:00
Reserves Bug 25566: Add option to ignore found holds and use it when checking high holds 2020-07-24 20:54:48 +00:00
SIP Bug 25348: (QA follow-up) Silence irrelevant warnings 2020-08-17 15:45:35 +00:00
Search Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
Serials Bug 7046: Implemented subscription renewal dropdown sub length element 2020-04-08 11:48:03 +01:00
Template/Plugin Bug 25765: (QA follow-up) Save a DB hit 2020-07-30 17:30:41 +00:00
Utils Bug 25875: Unit test 2020-07-13 16:22:51 +00:00
api/v1 Bug 23634: (QA follow-up) Adjust tests 2020-08-31 20:01:38 +00:00
cronjobs Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
data Bug 11677: Use zebra not-onloan-count index for availability limit 2019-08-20 15:00:16 +01:00
selenium Bug 26162: Wait for the table to be refreshed 2020-08-13 18:25:26 +00:00
www Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
00-strict.t
…
01-test_dbic.t
…
Accounts.t Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
Acquisition.t Bug 24161: Keep tracks of late orders claims 2020-05-04 09:44:44 +01:00
Amazon.t
…
ArticleRequests.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
AudioAlerts.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Auth.t Bug 24145: (bug 22543 follow-up) Fix Auth.t 2019-12-02 17:13:27 +00:00
Auth_with_cas.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Auth_with_ldap.t Bug 25172: Fix Auth_with_ldap.t 2020-04-22 15:43:16 +01:00
AuthorisedValues.t Bug 17355: Fix failing tests 2020-05-05 14:59:30 +01:00
AuthoritiesMarc.t
…
BackgroundJob.t Bug 24760: (follow-up) Add a neighboring test messsage 2020-03-06 14:58:47 +00:00
Barcodes.t Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
Barcodes_ValueBuilder.t Bug 21937: Add test to show autoBarcode annual increment bug 2019-04-19 14:32:17 +00:00
Biblio.t Bug 25189: Unit tests 2020-07-10 15:53:00 +00:00
Breeding.t Bug 24052: Fix Koha/XSLT/Base.t 2020-03-24 10:42:23 +00:00
Budgets.t Bug 10577: Improve semantics of GetBudgetPeriod() 2019-03-28 12:46:14 +00:00
Cache.t Bug 22808: Move Cache.t to db_dependent 2019-05-07 10:50:00 +00:00
Calendar.t Bug 25850: Add tests for weekday holidays 2020-07-24 20:51:21 +00:00
Charset.t Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls 2019-07-15 11:28:08 +01:00
Circulation.t Bug 25723: Update cache flushing calls 2020-07-27 17:39:40 +00:00
Clubs.t
…
ColumnsSettings.t
…
Context.t Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
Contract.t
…
CourseReserves.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
DecreaseLoanHighHolds.t Bug 25566: Add option to ignore found holds and use it when checking high holds 2020-07-24 20:54:48 +00:00
Filter_MARC_ViewPolicy.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Fines.t Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules 2020-02-04 09:56:24 +00:00
FrameworkPlugin.t
…
Heading.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Heading_MARC21.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Hold.t Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
Holds.t Bug 26043: Fix random failure from Holds.t 2020-08-13 17:58:18 +00:00
HoldsQueue.t Bug 25786: AddReserve now takes a hashref 2020-06-18 18:53:49 +02:00
Holidays.t Bug 25723: Remove tests for removed method 2020-07-27 17:39:55 +00:00
ILSDI_Services.t Bug 24769: Regression tests 2020-05-05 11:03:45 +01:00
Illcomments.t
…
Illrequestattributes.t
…
Illrequests.t Bug 26114: Regression tests 2020-08-17 15:34:56 +00:00
ImportBatch.t Bug 20415: Remove UseKohaPlugins system preference 2020-03-26 11:42:02 +00:00
ImportExportFramework.t
…
Installer.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Items.t Bug 25964: Prevent data loss when editing items from a MARC record 2020-07-24 20:31:28 +00:00
Koha.t Bug 22302: Unit tests 2020-02-05 12:35:24 +00:00
Koha_Authority.t
…
Koha_Database.t
…
Koha_Elasticsearch.t Bug 18235: (follow-up) fix tests and remove trailing space 2019-03-28 15:57:32 +00:00
Koha_ExternalContent_OverDrive.t Bug 25527: Add logger to Koha::ExternalContent 2020-05-18 15:25:03 +01:00
Koha_ExternalContent_RecordedBooks.t
…
Koha_Misc_Files.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Languages.t Bug 18213: Add language facets to Elasticsearch 2019-03-28 15:57:32 +00:00
Letters.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
LibraryGroups.t Bug 22284: New methods in Koha::Library::Groups and Koha::Library 2020-01-03 12:58:03 +00:00
Linker_Default.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Linker_FirstMatch.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Log.t Bug 23632: Remove C4::Logs::GetLogs 2020-09-04 14:39:36 +00:00
MarcModificationTemplates.t Bug 24900: Checks in MARC mod templates for when from field does not equal conditional field 2020-04-03 14:26:31 +01:00
Members.t Bug 23579: (RM follow-up) Fix failing tests 2019-10-25 13:13:26 +01:00
MungeMarcPrice.t
…
NewsChannels.t
…
Overdues.t Bug 25127: Correction to tests 2020-05-01 15:44:51 +01:00
Passwordrecovery.t Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
PatronLists.t
…
Patroncards.t Bug 22878: Add tests 2019-05-15 12:10:52 +00:00
Patrons.t Bug 25683: Patron with no accountlines should have 0 outstanding (not NULL) 2020-08-14 21:12:43 +00:00
Record.t
…
RecordProcessor_EmbedSeeFromHeadings.t
…
RefundLostItemFeeRule.t Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules 2020-02-04 09:56:24 +00:00
Reports.t
…
Reserves.t Bug 23070: Add tests 2020-07-27 15:47:07 +00:00
RotatingCollections.t Bug 23463: Replace AddItem calls with Koha::Item->store 2020-03-23 09:26:26 +00:00
Search.t Bug 23086: Unit test 2020-07-31 21:03:22 +00:00
Serials.t Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
Serials_2.t Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
Service.t
…
ShelfBrowser.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Sitemapper.t Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Stats.t Bug 21683: (follow-up) Remove last occurences of statistics.proccode 2019-03-21 18:19:23 +00:00
StockRotationItems.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationRotas.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationStages.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SuggestionEngine_ExplodedTerms.t
…
Suggestions.t Bug 23148: (follow-up) Correct image paths in sample data and tests 2020-07-27 15:55:42 +00:00
Tags.t Bug 21846: Simplify ugly double for loops 2019-03-15 12:27:44 +00:00
Templates.t
…
TestBuilder.t Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules 2020-02-04 09:56:24 +00:00
Upload.t Bug 21684: Fix UploadedFile[s]->delete 2020-01-07 16:32:53 +00:00
UsageStats.t Bug 25147: (RM follow-up) Update pref references. 2020-04-17 09:03:47 +01:00
Virtualshelves.t Bug 21684: Adjust some tests 2020-01-03 10:58:51 +00:00
XISBN.t Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
XSLT.t Bug 23463: Fix XSLT.t 2020-03-23 09:26:34 +00:00
check_kohastructure.t
…
check_sysprefs.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
db_structure.t
…
rollingloans.t
…
sysprefs.t Bug 22880: (follow-up) Loose ends: Better DB update, global inclusion, etc. 2020-02-24 13:24:25 +00:00
zebra_config.pl Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00