This code allows for "Perl false" to pass through to $suspended_until
if it is in $hold->suspend_until and in $body->{suspended_until}
But in case of "Perl truth" it calls dt_from_string for that value.
Reproduction:
1. run provided test in kshell: prove t/db_dependent/api/v1/holds.t
2. see the test fails with something like:
# Failed test 'Location change shouldn't touch suspended status'
# at t/db_dependent/api/v1/holds.t line 1067.
# got: '1'
# expected: '0'
# Failed test 'suspended_until should be undef'
# at t/db_dependent/api/v1/holds.t line 1068.
# got: '2022-01-20 00:00:00'
# expected: undef
# Looks like you failed 2 tests of 39.
3. apply the changes in this patch to Koha/REST/V1/Holds.pm
4. run provided test in kshell: prove t/db_dependent/api/v1/holds.t
5. test will pass.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
|
||
|---|---|---|
| .. | ||
| acquisitions_funds.t | ||
| acquisitions_orders.t | ||
| acquisitions_vendors.t | ||
| advanced_editor_macros.t | ||
| article_requests.t | ||
| auth.t | ||
| auth_authenticate_api_request.t | ||
| auth_basic.t | ||
| biblios.t | ||
| cashups.t | ||
| checkouts.t | ||
| cities.t | ||
| clubs_holds.t | ||
| holds.t | ||
| illrequests.t | ||
| import_batch_profiles.t | ||
| items.t | ||
| libraries.t | ||
| oauth.t | ||
| patrons.t | ||
| patrons_accounts.t | ||
| patrons_extended_attributes.t | ||
| patrons_holds.t | ||
| patrons_password.t | ||
| return_claims.t | ||
| smtp_servers.t | ||
| stockrotationstage.t | ||
| suggestions.t | ||
| transfer_limits.t | ||
| unhandled_exceptions.t | ||