Since bug 36085, the protected flag in a patron account was removed from
the patron creation form, regardless of if the user is a superlibrarian.
- Hoist $logged_in_user lookup before the edit_form block
- Move superlibrarian capability checks after the block so they apply
to all operations including patron creation
To test:
1. Sign in as a superlibrarian
2. Go to Patrons > New patron > choose any category
3. Without this patch: the "Protected" yes/no field is missing
from the "Library management" section
4. Apply this patch
5. Repeat step 2
- The "Protected" yes/no field is now visible
6. Create the patron with Protected set to "Yes"
7. Confirm the patron is saved as protected
8. Sign in as a non-superlibrarian with edit_borrowers permission
9. Repeat step 2
- The "Protected" field should still be hidden
10. Edit an existing patron as superlibrarian
- The "Protected" field is visible and functional
11. Edit an existing patron as non-superlibrarian
- The "Protected" field is hidden
12. Sign off
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
|
||
|---|---|---|
| .. | ||
| accountline-details.pl | ||
| alert-subscriptions.pl | ||
| apikeys.pl | ||
| boraccount.pl | ||
| cancel-charge.pl | ||
| default_messageprefs.pl | ||
| deletemem.pl | ||
| discharge.pl | ||
| discharges.pl | ||
| files.pl | ||
| holdshistory.pl | ||
| housebound.pl | ||
| ill-requests.pl | ||
| mancredit.pl | ||
| maninvoice.pl | ||
| member-flags.pl | ||
| member-password.pl | ||
| member.pl | ||
| memberentry.pl | ||
| members-home.pl | ||
| members-update-do.pl | ||
| members-update.pl | ||
| merge-patrons.pl | ||
| mod_debarment.pl | ||
| moremember.pl | ||
| notices.pl | ||
| patronimage.pl | ||
| pay.pl | ||
| paycollect.pl | ||
| print_overdues.pl | ||
| printfeercpt.pl | ||
| printinvoice.pl | ||
| printnotice.pl | ||
| printslip.pl | ||
| purchase-suggestions.pl | ||
| readingrec.pl | ||
| recallshistory.pl | ||
| routing-lists.pl | ||
| setstatus.pl | ||
| statistics.pl | ||
| summary-print.pl | ||
| two_factor_auth.pl | ||
| update-child.pl | ||