Go to file
Owen Leonard 0eb18dffd7
Bug 26258: Circulation tabs inconsistent with counters
This patch makes changes to the markup, style, and behaviour of counters
which are displayed on the patron's account tabs: Checkouts, Holds, etc.

This is a simplified patch compared to previous versions in order to try
to get this moving foward. The patch no longer includes added code to
keep tab counts up to date as, for instance, claims are added or
removed.

To test, apply the patch and rebuild the staff interface CSS.

 - Enable features if necessary: recalls, article requests, claims,
   clubs, and patron lists. Test both from the checkout page and the
   patron detail page.

Recalls:

- If necessary, check out some items to patrons so that there are titles
  which can be recalled.
- Log in to the OPAC and place one or more recalls.
- Return to the staff interface and view the "Recalls" tab on the
  patron's account.

Return claims:

- If necessary, check out some items to a patron. Click the "Claim
  returned" button on a few of the patron's checkouts.
- As you add claims, the "Claims" tab should update the count of claims.

  *** NOTE: This changes the display of claims in the tab so that the
      count of unresolved claims appears first: "Unresolved / Resolved".
      I think it makes more sense for the first number to be the one
      which shows the number of "active" issues.

- Test setting the ClaimReturnedWarningThreshold system preference to
  various values: e.g. empty, 1, 5.
  - If the pref is empty, OR if the pref is set to a number higher
    than the number of patron claims, the count of claims should be
    styled with the "info" blue background and the count of resolved
    claims is not shown.

    *** NOTE: Hiding the resolved claims seems logical if there is not a
        concern about the total number of claims.

  - If the number of all claims exceeds the value of the preference,
    the tab should show a count of "Unresolved claims / Resolved claims"
    with the yellow warning style.

Restrictions:

- Adding a restriction to the account should cause a counter with a
  red background to appear on the tab.

Clubs:

- If necessary, create at least one club template and then multiple
  clubs.
- From the "Clubs" tab on the patron's account, try enrolling and
  cancelling enrollments to confirm that the count on the tab updates
  correctly.

  *** NOTE: I have removed the count of available clubs because I think
      it's not relevant to this interface. We don't do it with patron
      lists, so this makes it a little more consistent..

Patron lists:

- If necessary, create two ore more patron lists.
- From the "Patron lists" tab, try adding and removing the patron from
  lists.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-11-26 10:40:35 -07:00
.github/workflows Bug 40027: Use GitHub workflow to automatically close PRs opened on the Koha repo there 2025-10-06 09:15:26 -06:00
C4 Bug 41271: Revert follow-up from bug 37893 2025-11-21 08:41:50 -07:00
Koha Bug 39532: Use new FINES restriction type to avoid conflict with SUSPENSION 2025-11-21 08:41:51 -07:00
acqui Bug 20253: (follow-up) Block auto_orders and UI ordering for duplicate PO numbers 2025-11-03 14:13:39 -07:00
admin Bug 37893: (QA follow-up): Nuke server params and listeners from UI 2025-11-18 11:21:03 -07:00
api Bug 37893: (QA follow-up): Fix xt/api.t 2025-11-18 11:21:19 -07:00
authorities Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
basket Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
bin Bug 40163: (follow-up) Fix wrong GNU links and update test 2025-09-24 09:25:04 -06:00
bookings Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
catalogue Bug 41153: Clean up catalogue/MARCdetail.pl 2025-11-07 10:54:09 -07:00
cataloguing Bug 29733: MARC21: Link 7xx linking fields to marc21_linking_section.pl value builder 2025-11-07 10:54:14 -07:00
circ Bug 40529: Behavior change: Main patch 2025-11-03 14:13:22 -07:00
clubs Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
course_reserves Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
debian Bug 41032: Fix Open Fifth missing in plugin repos config 2025-11-26 10:40:25 -07:00
docs Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
erm Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
errors Bug 28146: Respect ReplytoDefault in error pages 2025-10-09 14:58:41 -06:00
etc Bug 41032: Fix Open Fifth missing in plugin repos config 2025-11-26 10:40:25 -07:00
ill Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
installer Bug 39532: DBRev 25.06.00.036 2025-11-21 13:05:59 -07:00
koha-tmpl Bug 26258: Circulation tabs inconsistent with counters 2025-11-26 10:40:35 -07:00
labels Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
lib Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
members Bug 41212: Sort debit_types for manual invoice by description 2025-11-19 12:28:17 -07:00
misc Bug 39532: Use new FINES restriction type to avoid conflict with SUSPENSION 2025-11-21 08:41:51 -07:00
offline_circ Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
opac Bug 18148: Make list of lists in OPAC sortable 2025-11-05 07:12:35 -07:00
patron_lists Bug 32176: Remove duplicated code to select patron from autocomplete 2025-10-31 15:26:25 -06:00
patroncards Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
plugins Bug 25952: Skip invalid repositories when searching for plugins 2025-11-21 08:41:52 -07:00
pos Bug 40625: Fix duplicate cashup records via POST/REDIRECT/GET pattern 2025-09-26 10:37:00 -06:00
preservation Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
recalls Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
reports Bug 40163: (follow-up) Fix wrong GNU links and update test 2025-09-24 09:25:04 -06:00
reserve Bug 40517: (QA follow-up): Cleanup obsolete code 2025-10-29 11:50:10 -06:00
reviews Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
rotating_collections Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
serials Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
services Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
sip2 Bug 37893: Fix http links 2025-11-18 11:21:20 -07:00
skel
…
suggestion Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
svc Bug 40529: Add hold group targets logic 2025-11-03 14:13:14 -07:00
t Bug 41032: Fix Open Fifth missing in plugin repos config 2025-11-26 10:40:25 -07:00
tags Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
tools Bug 40843: Sort patron attributes by description 2025-11-19 12:28:16 -07:00
virtualshelves Bug 40916: Fix another occurance 2025-10-06 09:15:22 -06:00
xt Bug 41167: Add test to compare both apache conf 2025-11-17 15:15:52 -07:00
.codespell-ignore Bug 40950: Add 'falsy' programming idiom to codespell dictionary 2025-10-06 09:15:23 -06:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.git-blame-ignore-revs Bug 39096: Add 'tidy all' commits to a git blame ignore file 2025-02-17 13:10:25 +01:00
.gitignore Bug 40838: Add generated bookings CSS assets to gitignore 2025-09-19 08:42:47 -06:00
.htaccess
…
.mailmap Bug 40041: Remove duplicated or unecessary entries 2025-10-20 10:12:50 -06:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.prettierrc.js Bug 38664: Treat .vue files like other JS files 2025-02-11 14:58:25 +01:00
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.stylelintrc.json Bug 31528: (follow-up) A few additional rules 2022-10-03 08:23:15 -03:00
INSTALL
…
Koha.pm Bug 39532: DBRev 25.06.00.036 2025-11-21 13:05:59 -07:00
LICENSE Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
MANIFEST.SKIP
…
Makefile.PL Bug 37893: SIP2 VueJS module scaffolding 2025-11-18 11:20:45 -07:00
README
…
README.md Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
README.robots
…
SECURITY.md Bug 40527: Initial draft of SECURITY.md 2025-10-09 14:58:41 -06:00
about.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
app.psgi Bug 40163: (follow-up) Fix wrong GNU links and update test 2025-09-24 09:25:04 -06:00
build-resources.PL Bug 40163: (follow-up) Fix wrong GNU links and update test 2025-09-24 09:25:04 -06:00
changelanguage.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
cpanfile Bug 40663: Update GD::Barcode::QRcode to v2.01 2025-09-05 15:10:34 -06:00
cypress.config.ts Bug 38201: Move cypress components under t/cypress 2025-10-02 09:40:23 -06:00
eslint.config.mjs Bug 38524: Enable ESLint for .ts and .vue files 2025-01-16 15:56:17 +01:00
fix-perl-path.PL Bug 40163: (follow-up) Fix wrong GNU links and update test 2025-09-24 09:25:04 -06:00
gulpfile.js Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
help.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
kohaversion.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
mainpage.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
package.json Bug 38201: Add component tests for useBaseResource 2025-10-02 09:40:21 -06:00
rewrite-config.PL Bug 40163: (follow-up) Fix wrong GNU links and update test 2025-09-24 09:25:04 -06:00
rspack.config.js Bug 37893: SIP2 VueJS module scaffolding 2025-11-18 11:20:45 -07:00
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
yarn.lock Bug 38426: Adjust yarn.lock after node upgrade (18 to 20) 2025-11-25 10:13:20 -07:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit https://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

https://koha-community.org/

Koha Logo