Go to file
Galen Charlton 0c67e94c8b Bug 10656: (follow-up) handle OPAC sorting of authvals where lib_opac is NULL
The OPAC description for an authorized value is not required to be
populated.  In particular, if it is NULL, the staff description is
displayed instead.

This patch makes sure that the sort order (in OPAC mode) uses either
the staff description or the OPAC description as needed for each
value.

To test:

[1] Make sure that AdvancedSearchTypes includes "ccode"
[1] Arrange your CCODE values so the sort order for staff labels
    is different from the sort order for OPAC descriptions.  Also,
    ensure that one of the OPAC descriptions is NULL.  For example,

    authorised_value | lib     | lib_opac
    --------------------------------------
    ZZZ              | A_STAFF | Z_PUBLIC
    DDD              | D_STAFF | NULL
    AAA              | Z_STAFF | A_PUBLIC

[2] Prior to the patch, any CCODE values where the OPAC description
    is NULL will sort first in the OPAC advanced search page, even
    if the displayed label shouldn't come first.
[3] Apply the patch.
[4] Verify that the collection list on the OPAC advanced search page
    is now correct.
[5] Verify that the sort order on the staff advanced search page
    has not changed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, tested in staff and OPAC.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2013-09-06 16:48:23 +00:00
C4 Bug 10656: (follow-up) handle OPAC sorting of authvals where lib_opac is NULL 2013-09-06 16:48:23 +00:00
Koha Bug 9755: (follow-up) tweak test for tag visibility in merge hash 2013-07-23 23:11:04 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 10737: Add "Add to basket" link on vendor search results page 2013-09-05 15:28:31 +00:00
admin Bug 8887: only display desired result when doing exact syspref search 2013-08-16 16:17:41 +00:00
authorities Bug 5262: make authority plugin copy indicators to bib record 2013-08-14 17:17:22 +00:00
basket Bug 9073 - Download option from the cart should match the menu button in lists 2012-11-25 18:08:46 -05:00
catalogue Bug 10404: add previous/next browsing to staff client 2013-08-09 15:07:39 +00:00
cataloguing Bug 10766: unbreak reservoir search when UseQueryParser is OFF 2013-08-25 17:16:23 +00:00
circ Bug 5904: make patron search autocompletion respect IndependentBranches 2013-09-04 16:42:38 +00:00
course_reserves bug 8215: (followup) avoid spurious warning in Apache log 2013-05-21 16:01:08 -07:00
debian Bug 10574 - mute the "upgrading from 3.2" message 2013-09-06 14:54:53 +00:00
docs bug 7143: add latest batch of committers 2013-07-22 14:40:58 +00:00
errors Housekeeping in errors scripts 2010-05-12 07:29:03 -04:00
etc Bug 8911: make sure history.txt gets installed where history.txt can see it 2013-07-22 14:11:48 +00:00
install_misc Bug 8840 - [SIGNED-OFF] Patch to solve false "All dependencies installed!" 2013-05-12 21:15:19 -04:00
installer Bug 10593: make AuthoritiesLog default to yes 2013-08-28 13:44:57 +00:00
koha-tmpl Bug 10649 - Upgrade DataTables and move scripts out of theme directory 2013-09-05 15:43:36 +00:00
labels Bug 10527: remove disused routine C4::Branch::get_branch_code_from_name 2013-07-12 20:20:20 +00:00
members Bug 5652: display subtitles on patron checkout and holds summary 2013-08-06 14:30:52 +00:00
misc Bug 10361: Add option to cleanup_database.pl to purge OPAC search history 2013-09-04 14:22:50 +00:00
offline_circ Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly. 2013-03-21 20:35:37 -04:00
opac Bug 10588: improve selection of default branch for OPAC popular items pag 2013-09-04 17:14:22 +00:00
patroncards Bug 10527: remove disused routine C4::Branch::get_branch_code_from_name 2013-07-12 20:20:20 +00:00
plugins Bug 7804 - Add Koha Plugin System - QA Followup 2 2013-03-20 14:50:19 -04:00
reports Bug 3134: add ability to selelct multiple reports to delete at once 2013-08-21 14:24:33 +00:00
reserve Bug 10663: QA Followup: Typo in comment in renewscript 2013-08-16 01:39:16 +00:00
reviews Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
rotating_collections Bug 9605: rotating collections permissions are wrong 2013-03-30 22:11:05 -04:00
selenium
…
serials bug 10728: fix additional log noise generated by subscription-renew.pl 2013-08-19 14:10:38 +00:00
services Bug 7178: Acquisition item creation improvement 2012-03-26 11:07:23 +02:00
skel Bug 7804 - Add Koha Plugin System 2013-03-20 14:49:47 -04:00
sms Bug 2505 - Add commented use warnings where missing in the sms/ directory 2010-04-21 20:25:08 +12:00
suggestion Bug 9307: QA Followup 2013-06-19 07:19:39 -07:00
svc Bug 9908 - Fixing OCLC Connexion Client 2013-03-29 21:29:10 -04:00
t Bug 10656: add regression test 2013-09-06 16:47:30 +00:00
tags Merge remote branch 'origin/new/bug6554_reverts' 2013-05-01 11:22:30 -07:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities
…
tools Bug 7785: (follow-up) standardize POD 2013-08-13 16:15:30 +00:00
virtualshelves Bug 7788: [SIGNED-OFF] Followup: GetShelf call in addbybiblio script corrected 2012-05-22 12:06:26 +02:00
xt Bug 9802 - add test case to ensure man pages have correct XML 2013-03-20 15:11:10 -04:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap 7439 Mailmap for master 2012-01-27 12:27:58 +01:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 7440 - Remove NoZebra vestiges 2013-03-19 21:17:04 -04:00
INSTALL.opensuse Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
INSTALL.ubuntu Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.ubuntu.12.04 Bug 9267 - Ubuntu 12.04 install docs broken 2013-03-07 09:46:55 -05:00
INSTALL.ubuntu.lucid Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 10539: Followup for removing KohaTest unit tests 2013-09-05 15:06:05 +00:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 8911: make sure history.txt gets installed where history.txt can see it 2013-07-22 14:11:48 +00:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl 7368 Typo in edithelp.pl warning 2013-04-18 09:47:58 -04:00
fix-perl-path.PL
…
help.pl Bug 10052: QA Followup 2013-05-23 08:55:12 -07:00
install-CPAN.pl Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00
koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl 2013-07-11 14:03:32 +00:00
kohaversion.pl bug 7494: DBRev 3.13.00.015' 2013-07-24 15:12:52 +00:00
mainpage.pl Bug 10080 - Change system pref IndependantBranches to IndependentBranches 2013-05-22 07:58:23 -07:00
rewrite-config.PL Bug 10712: Save missing config variables to install log 2013-08-13 14:14:30 +00:00

README

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/