Go to file
Jonathan Druart 0b69f9502d Bug 18743: Fix suggestion listing when organized by library
There are some weird behaviors happening when using the "Organize by:
library" dropdown along with the library filter (in the "Acquisition
information" box).

I am suggesting the following test plan:
0. Create several suggestion from different libraries

A. You are superlibrarian and IndependentBranches is not set (=No)
1. Hit /suggestion/suggestion.pl
=> Default view shows the suggestions from your library
2. Filter by another library
=> You see the suggestions from this library
3. Filter by "Any" libraries
=> You see all the suggestions
4. "Organize by library"
=> You see all the suggestions, organized by library
5. Filter by a specific library
=> You see the suggestion from your library, all in one tab

B. You are not superlibrarian and IndependentBranches is not set (=No)
Same as A.

C. You are superlibrarian and IndependentBranches is set
Same as A.

D. You are not superlibrarian and IndependentBranches is set
You will never see suggestions coming from outside your library

QA: To be clear: the whole script needs a rewrite, but here we are just
trying to fix weird behaviors.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 9f16ab9e75)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2019-11-08 16:24:06 +01:00
C4 Bug 18743: Fix suggestion listing when organized by library 2019-11-08 16:24:06 +01:00
Koha Bug 22997: Searching gives no results in auth_finder.pl 2019-11-08 15:35:05 +01:00
OpenILS
…
acqui Bug 23863: Editing a basket clears create_items value 2019-11-08 16:16:50 +01:00
admin Bug 22786: Prevent fund creation for locked budgets 2019-09-09 09:57:05 +02:00
api/v1 Bug 23607: Make /patrons/:patron_id/account staff only 2019-10-08 09:07:15 +02:00
authorities Bug 19994: Used Modern::Perl in Authorities perl scripts 2019-01-28 14:58:23 +00:00
basket Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
catalogue Bug 12537: Don't retrieve XISBN results for the same biblionumber 2019-07-30 08:14:19 +02:00
cataloguing Bug 22830: correct for loop in value_builder/unimarc_field_4XX.pl value_builder 2019-09-02 16:49:26 +02:00
circ Bug 23551: Fix AddRenewal call in circ/renew.pl 2019-11-08 16:19:26 +01:00
clubs
…
course_reserves Bug 21003: Removed warning and changed wording on add_items-step2.tt 2019-03-23 09:51:36 +00:00
debian Bug 23345: Rename include-indexes to exclude-indexes in koha-dump 2019-08-09 14:53:01 +02:00
docs Bug 22128: Add Rudolf Byker to contributors 2019-07-25 13:43:53 +02:00
errors
…
etc Bug 15704: Split up Zebra indexing of RDA 264 information 2019-07-24 09:23:17 +02:00
ill Bug 21460: (follow-up) Fix bugs found in QA 2019-04-25 10:46:56 +00:00
installer Bug 23579: Remove default value for MEDIUMTEXT borrower_modifications.changed_fields 2019-11-08 16:21:25 +01:00
koha-tmpl Bug 23863: (QA follow-up) Add missing html filter 2019-11-08 16:17:05 +01:00
labels Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
members Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack 2019-11-08 15:23:58 +01:00
misc Update release notes for 19.05.04 release 2019-09-24 09:40:13 +02:00
offline_circ Bug 22600: Add 'interface' to accountlines 2019-04-10 19:43:11 +00:00
opac Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack 2019-11-08 15:23:58 +01:00
patron_lists
…
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins Bug 22053: ability to enable/disable some plugins 2019-05-09 18:54:44 +00:00
reports Bug 22090: Add missing information to cash register CSV file 2019-04-16 13:17:32 +00:00
reserve Bug 22021: Improve item status display when placing holds in staff 2019-08-06 16:36:23 +02:00
reviews
…
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 23126: Remove more unnecessary linebreak processing from serial collection 2019-07-25 13:37:16 +02:00
services
…
skel
…
suggestion Bug 18743: Fix suggestion listing when organized by library 2019-11-08 16:24:06 +01:00
svc Bug 22249: Mana - Move comment process in a dedicated sub 2019-08-09 14:40:09 +02:00
t Bug 23579: (RM follow-up) Fix failing tests 2019-11-08 16:21:42 +01:00
tags Bug 22036: Indented code where '^I' was written rather than an indent. 2019-01-17 02:23:28 +00:00
tmp/modified_authorities
…
tools Bug 22799: Avoiding batch item modification case sensitivity when entering barcodes 2019-09-05 16:36:45 +02:00
virtualshelves Bug 22941: Do not return 500 if sortfield contain parenthesis 2019-06-20 14:24:59 +02:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig
…
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap
…
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL
…
Koha.pm Increment version for 19.05.04 release 2019-09-24 09:33:09 +02:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 21626: (QA follow-up) Embed teams.yaml for debian packages 2019-05-17 14:46:10 +00:00
README
…
README.md
…
README.robots
…
about.pl Bug 23445: (RM follow-up) Add warning for unexpected lengthunit 2019-09-05 16:49:01 +02:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL
…
gulpfile.js Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display 2019-02-04 14:13:35 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
koha_perl_deps.pl
…
kohaversion.pl
…
mainpage.pl Bug 21907: Fix article requests count for non-superlibrarians 2019-02-04 14:50:40 +00:00
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
rewrite-config.PL Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo