gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/t/db_dependent
History
Jonathan Druart 0b615c8db9 Bug 6756: Fix bad behaviors if AnonymousPatron is not defined 
There are at least 2 wrong behaviors if the AnonymousPatron pref is not
defined (0 or empty string).
1/ If you use the clean borrower tools, you will get a successful
message when the nothing happened (the history has not been anonymised).
2/ At the OPAC, if a patron ask for delete his reading history, he will
get an error message "The deletion of your reading history failed,
because there is a problem with the configuration of this feature.
Please help to fix the system by informing your libr    ary of this
error". IMO this should not happen, the history should be anonymised.

With this patch, the old_issues.borrowernumber field will be set to NULL
if the AnonymousPatron pref if not defined.

Test plan:
1/ Fill the pref with "" or 0
2/ At the OPAC, go on the privacy tab and click on the "Immedia deletion" button.
You should get a green and friendly message. Confirm that the history
has been anonymised.
3/ Use the "Batch patron anonymization" tools (tools/cleanborrowers.pl)
to anonymize the checkout history.
Confirm that a) it works and b) you get a message.

Try again with AnonymousPatron set to a valid patron. You should not see
any changes with the current behaviors.

NOTE: This patch tweaks C4/Circulation.pm and provides tests.
      applying just this, and running prove success. Reverting just
      C4/Circulation.pm fails, as expected.
      Tested OPAC stuff with both patches applied.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Mason James <mtj@kohaaloha.com>
 		2015-10-02 23:32:35 +13:00
..
Acquisition Bug 13333: Fix Display basket group for already received orders 2015-02-26 16:21:27 +13:00
Circulation Bug 6756: Fix bad behaviors if AnonymousPatron is not defined 2015-10-02 23:32:35 +13:00
Holds Bug 12086: qa-followup: remove warning on launching unit tests 2014-06-25 22:30:02 +00:00
Koha Bug 11279: (follow-up) remove unnecessary check on number of quotes 2013-12-19 15:06:39 +00:00
LDAP
…
Labels Bug 14204: (QA followup) remove unneeded messages 2015-05-29 19:58:54 +12:00
Members Bug 10481: Unit tests for C4::Members::AddEnrolmentFeeIfNeeded 2013-08-16 15:08:41 +00:00
Record
…
Reports Bug 8594 - prevent the report system from breaking some subqueries 2012-09-05 10:12:06 +02:00
Search Bug 10807: Add an authority search history for the OPAC 2014-05-05 02:32:27 +00:00
Serials Bug 12003: Do not calculate next pubdate for irregular subscriptions 2014-04-18 20:57:51 +00:00
data Bug 12419: (QA followup) regression tests 2014-09-23 20:44:47 +00:00
www Bug 8300: Add mechanized unit test for batch import 2013-05-01 07:57:11 -04:00
00-strict.t Bug 7844: (follow-up) don't test koha.psgi for ability to compile (yet) 2014-04-29 19:34:23 +00:00
Accounts.t
…
Acquisition.t Bug 11027: (follow-up) update unit test to reflect new columns returned by GetLateOrders 2014-04-21 04:39:04 +00:00
Amazon.t
…
Auth.t Bug 14408 (3.16/3.14) regex fix for .tmpl files too 2015-06-25 06:40:46 +12:00
Auth_with_cas.t
…
AuthoritiesMarc.t Bug 7442: (follow-up) adjust UNIMARC test case to match change in BuildSummary() 2014-05-05 04:18:22 +00:00
BackgroundJob.t Bug 10601: (follow-up) unit tests for new ->set() and ->get() 2013-09-18 17:21:47 +00:00
Barcodes.t
…
Biblio.t Bug 10961: (followup) Make query fields explicit and add regression tests 2015-08-28 14:55:25 +12:00
Bookseller.t Bug 12048: add regression test 2014-04-18 20:45:58 +00:00
Borrower_Debarments.t Bug 12416: add new tests of DelUniqueDebarment 2014-06-25 22:26:15 +00:00
Borrower_Files.t Bug 12417: adding the units tests of the module Koha::Borrower::Files.pm 2014-07-23 21:20:59 +00:00
Branch.t Bug 10508: (follow-up) remove Perl 5.14 construct 2013-08-28 14:24:34 +00:00
Budgets.t Bug 12168: (follow-up) correct typos in test descriptions 2014-05-19 22:05:17 +00:00
Category.t Bug 11543: (followup) add one more test 2014-01-15 19:58:30 +00:00
Circulation.t Bug 12596: (followup) add reference to bug # and license note 2014-08-26 22:39:35 +00:00
Circulation_Branch.t Bug 10683: (follow-up) improvements to the unit tests 2013-10-09 03:51:55 +00:00
Circulation_Issuingrule.t Revert "Bug 12406: adding the column maxsuspensiondays in the tests" 2014-08-15 01:00:38 +00:00
Circulation_OfflineOperation.t Bug 10710: (follow-up) perltidy new code 2013-08-28 14:52:43 +00:00
Circulation_issue.t Bug 10694: (follow-up) remove truncate table from test case 2014-05-02 22:00:45 +00:00
Circulation_issuingrules.t Bug 11934: (follow-up) tidy up whitespace 2014-03-13 15:18:49 +00:00
Circulation_transfers.t Bug 12122: TransferSlip should accept both itemnumber and barcode 2015-04-23 00:32:50 +12:00
ClassSource.t Bug 10644: (follow-up) remove inadvertant dependence on Perl 5.14 2013-08-09 18:53:20 +00:00
Context.t Bug 11701: (follow-up) move unit tests to t/db_dependent 2014-03-25 14:41:07 +00:00
CourseReserves.t Bug 10332: further improvements to course reserves tests 2013-06-18 16:40:43 -07:00
Csv.t Bug 10853: (follow-up) expand unit tests for C4::Csv 2013-10-11 03:25:42 +00:00
External_BakerTaylor.t
…
Heading_MARC21.t
…
Holds.t Bug 9532: add regression test 2014-05-05 17:17:36 +00:00
HoldsQueue.t Bug 11258: fix another case where holds queue made transfer requests that contradict the library holds policy 2014-04-18 15:23:23 +00:00
Holidays.t Bug 11112: (follow-up) repair Koha::Calendar->add_holiday() 2013-12-10 18:19:15 +00:00
ILSDI_Services.t Bug 10667: (follow-up) fix reference to UT library in test case 2013-09-16 19:22:22 +00:00
Installer.t Bug 11541: (follow-up) move Installer.t to t/db_dependent 2014-01-14 21:43:56 +00:00
Items.t Bug 11518 [QA Followup] - Make unit tests pass 2015-01-19 16:23:00 +13:00
KitchenSinkPlugin.kpz Bug 7804 - Add Koha Plugin System - QA Followup 3 - Additional Unit Tests 2013-03-20 14:50:38 -04:00
Koha.t Bug 13453: Koha.t daily quote tests assume sample data 2015-01-23 19:58:25 +13:00
Koha_Authority.t Bug 5202: merge authorities from the authority file and reservoir 2013-10-10 21:32:27 +00:00
Koha_Database.t Bug 13645: Cache the DBIx connection 2015-05-29 17:53:40 +12:00
Koha_borrower_modifications.t Bug 7067 - QA Followup - Fix failing tests 2012-12-14 08:09:01 -05:00
Koha_template_plugin_Branches.t Bug 11779: (follow-up) improve GetLoggedInBranchcode() and add test cases 2014-02-19 16:40:06 +00:00
Koha_template_plugin_KohaDates.t Bug 12669: Centralize the timezone handle into Koha::DateUtils 2015-08-28 17:13:31 +12:00
Languages.t Bug 7841: add a direct regression test 2014-05-19 16:40:23 +00:00
Letters.t Bug 9016: Create a message for each transport type. 2014-05-02 20:29:16 +00:00
Linker_FirstMatch.t
…
Log.t
…
MarcModificationTemplates.t Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines 2013-10-31 22:50:11 +00:00
Members.t Revert "Bug 12868: Improving t/db_dependent/Member.t" 2015-01-23 20:59:30 +13:00
Members_Attributes.t Bug 12427: Allow execution of UTs on a DB with issues 2014-06-25 22:36:19 +00:00
Members_columns.t Bug 7785: (follow-up) standardize POD 2013-08-13 16:15:30 +00:00
MungeMarcPrice.t Bug 9593: (follow-up) don't make currency.isocode required 2014-05-04 22:21:17 +00:00
NewsChannels.t Bug 7567: (follow-up) make tests of get_opac_new more readable 2014-04-07 18:14:20 +00:00
Overdues.t Bug 11696: ensure that print overdue notices use the print template 2014-05-02 20:29:21 +00:00
PatronLists.t Bug 10565: (follow-up) don't assume borrowernumber 1 exists in unit test 2013-10-14 21:30:34 +00:00
Plugins.t Bug 9909: Don't install KitchenSink plugin if plugin dir isn't writable 2013-03-22 21:52:41 -04:00
Ratings.t
…
Record.t Bug 11066: (follow-up) add regression test 2014-01-03 15:54:45 +00:00
RecordProcessor_EmbedSeeFromHeadings.t Bug 7417: Include see from references in bibliographic searches 2012-09-13 14:19:28 +02:00
Reports.t
…
ReportsGuided.t Bug 9659 follow-up: correct syntax for older Perl 2013-04-26 21:32:49 -04:00
Reports_Guided.t Bug 12214: add regression test for reporting error when running report with SQL error 2014-05-09 14:39:54 +00:00
Reserves.t Bug 12876: (followup) remove useless diags 2014-10-01 21:44:45 +00:00
RotatingCollections.t Bug 10653: (follow-up) minor tweaks to RotatingCollections tests 2013-08-16 16:09:13 +00:00
SIP_ILS.t Bug 7904: (QA followup) fix tests 2015-05-27 13:16:13 +12:00
SQLHelper.t
…
Search.t Bug 12788: (followup) minor optimization with proper tests 2014-09-23 20:52:12 +00:00
Search_SearchHistory.t Bug 10807: (follow-up) remove comment about routine that is no longer present 2014-05-05 02:58:29 +00:00
Serials.t Bug 13746: Add tests (follow-up) 2015-04-23 16:25:16 +12:00
Serials_2.t Bug 12098: (follow-up) deal with FIXMEs in t/db_dependent/Serials_2.t 2014-04-18 20:46:00 +00:00
Service.t
…
ShelfBrowser.t Bug 10856: Improve the previous and next items on the shelf browser 2013-10-04 15:56:35 +00:00
SuggestionEngine_ExplodedTerms.t Bug 8846 conflict resolution: correct path 2012-11-01 08:41:30 -04:00
Suggestions.t Bug 12445 [QA Followup] - Clear issues table before clearing borrrowers table 2015-05-29 19:18:47 +12:00
Tags.t Bug 7642 - fix the lost display of tag sizes 2012-10-01 17:38:27 +02:00
UploadedFile.t
…
VirtualShelves.t Bug 9032: (follow-up) restore documented intepretation of virtualshelfshares.sharedate 2014-04-20 22:52:21 +00:00
VirtualShelves_Page.t
…
XISBN.t Bug 12782: (followup) skip tests that fail because of provider's error 2015-03-04 03:11:50 +13:00
check_sysprefs.t
…
rollingloans.t
…
sysprefs.t Bug 10325: (follow-up) add test for overriding system preferences 2013-09-08 02:28:45 +00:00
zebra_config.pl Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00