4ad5cbdb97
When using a direct link to a news (koha.url/cgi-bin/koha/opac-main.pl?news_id=XXX), the link is broken if the news is expired. Formerly, a using AdditionalContent->get( id => "my_news_id") on an expired news was returning a news, and calling get without id was returning all news but the expired ones. This patch adds tests to check this behaviour by adding one expired news and performing following new tests: 1 - It may not be returned by AdditionalContent.get() 2 - It must be returned by AdditionalContent.get() using its id This patch fixes the behaviour by addind the new behaviour or AdditionalContent.get: 1 - Any news must be returned by AdditionalContent.get() using its id; TEST PLAN: 1 - Apply patch 2 - Remove the changes made to Koha/AdditionalContents.pm 3 - Run tests -> one test must fail 4 - Create a news with a expired expiration date, notice the id of the news in the url of the modification panel 5 - Go to "opac.url/cgi-bin/koha/opac-main.pl?news_id=MY_ID" -> notice it does not work 6 - Reapply the whole patch 7 - Run test -> all test must pass 8 - Go to "opac.url/cgi-bin/koha/opac-main.pl?news_id=MY_ID" -> notice it does work now Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> |
||
|---|---|---|
| .. | ||
| Plugin | ||