Kyle M Hall 8a975f8d30 Bug 11258: fix another case where holds queue made transfer requests that contradict the library holds policy ... This patch fixes a problem where the holds queue generator was making requests where the pickup library is the same as the item's library but not the patron's branch, even if there is a "Default holds policy by item type" rule that states this item can only fill holds for patrons of the same library as the item. Test Plan: 1) Create a test record with 2 items with different itemtypes 2) Set the Default holds policy by item type for the first item to "From any library" 3) Set the Default holds policy by item type for the second item to "From home library" 4) Place a record level hold for a patron from another library, but for pickup at the same library as the item is from 5) Rebuild the holds queue 6) View the holds queue, note the item is listed, though this patron cannot place a hold on this item 7) Apply this patch 8) Repeat step 5, note the hold is no longer in the queue Signed-off-by: Liz Rea <liz@catalyst.net.nz> automated tests pass, functional tests pass. Bug replicated, eradicated by patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I finally managed to reproduce this, patch works as described. Passes tests and QA script, provided tests fail without patch, but succeed with the patch. Signed-off-by: Galen Charlton <gmc@esilibrary.com> (cherry picked from commit 7966037747) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>		2014-08-13 10:30:02 -04:00
..
Acquisition	Bug 5339: Unit tests for invoices related subroutines	2012-09-20 09:46:59 +02:00
Budgets	Bug 7304: More permissions for budgets	2012-06-27 16:25:44 +02:00
Koha/Plugin	Bug 7804 - Add Koha Plugin System - QA Followup 2	2013-03-20 14:50:19 -04:00
db_dependent	Bug 11258: fix another case where holds queue made transfer requests that contradict the library holds policy	2014-08-13 10:30:02 -04:00
lib	Bug 10298: Mock C4::Context->preference	2013-12-03 15:35:18 -03:00
searchengine	Bug 8233 : SearchEngine: Add a Koha::SearchEngine module	2012-07-06 16:51:58 +02:00
00-checkdatabase-version.t	Bug 9191 follow-up: remove example updatedatabase stanzas	2012-12-11 08:29:11 -05:00
00-deprecated.t	Bug 5105 Regression test for switch statement	2010-11-11 21:32:31 +13:00
00-load.t	Bug 10667: Follow up - prevent t/00-load from failing	2013-11-08 15:18:43 -03:00
00-merge-conflict-markers.t	Test suite: ignoring backups from vi (files ending with a ~)	2011-12-07 15:17:54 +01:00
00-testcritic.t	Bug 8216: Allow SIP modules to pass critic tests	2012-06-20 11:14:00 +02:00
00-valid-xml.t	bug 5393 [SIGNED-OFF]: add test case to check well-formedness of XML/XSLT files	2010-11-13 11:51:49 +13:00
AuthoritiesMarc_MARC21.t	Bug 5327 added unit tests for C4/AuthoritiesMarc/MARC21.pm	2012-01-31 17:21:47 +01:00
AuthoritiesMarc_UNIMARC.t	Added unit test for AuthoritiesMarc/UNIMARC.pm	2011-12-15 13:41:41 +01:00
Barcodes_EAN13.t	Bug 6448 [2/3] Barcodes::EAN13 autoBarcode	2012-08-02 18:41:44 +02:00
Barcodes_PrinterConfig.t	Bug 5327 added unit tests for C4/Barcodes_PrinterConfig.pm	2012-01-31 17:21:48 +01:00
Barcodes_ValueBuilder.t	Bug 8524 follow-up: fix broken test	2012-08-31 17:42:44 +02:00
Barcodes_annual.t	…
Barcodes_hbyymmincr.t	…
Barcodes_incremental.t	…
Bookseller.t	…
Boolean.t	Added missing reference case to Boolean.t and corrected count	2011-12-15 13:50:41 +01:00
Branch.t	…
Breeding.t	…
Budgets.t	…
Cache.t	Bug 9434 follow-up: fix number of tests skipped when cache is disabled	2013-03-20 15:50:37 -04:00
Calendar.t	Bug 9209: Skip tests for older DBD::Mock	2012-12-28 20:15:36 -05:00
Category.t	…
Charset.t	Bug 11540: (follow-up) add a couple of tests more	2014-02-07 12:48:11 -03:00
Circulation_barcodedecode.t	Bug 6448 [1/3] EAN-13/UPC-A itemBarcodeInputFilter	2012-08-02 18:41:40 +02:00
ClassSortRoutine.t	…
ClassSortRoutine_Dewey.t	Bug 9770: test case for sorting of Dewey call numbers that contain prefixes	2013-07-25 11:53:50 -03:00
ClassSortRoutine_Generic.t	Bug 5327 added unit tests for C4/ClassSortRoutine/Generic	2012-01-17 15:31:55 +01:00
ClassSortRoutine_LCC.t	bug 6281: introduce LC::CallNumber::LC for sorting LC call numbers	2013-06-28 11:06:17 -03:00
ClassSource.t	…
Contract.t	…
Creators.t	Bug 7952 - followup to fix t/Creators.t	2012-06-14 15:54:06 +02:00
DateUtils.t	Bug 9912: DateUtils.t must not access database	2013-03-23 09:13:16 -04:00
Dates.t	Fix for Bug 4473 - Recent comments view for the OPAC	2010-12-13 09:43:01 +13:00
Debug.t	Added extra unit tests to Debug.t	2011-01-18 11:59:07 +13:00
External_Syndetics.t	…
Form_MessagingPreferences.t	…
Heading.t	…
ILSDI_Utility.t	…
Images.t	Bug 5327: Testing c4 Images	2012-09-07 14:42:18 +02:00
ImportBatch.t	…
Input.t	…
Installer_PerlDependencies.t	…
Installer_PerlModules.t	Bug 9734 - String::Random is marked as optional, but C4::Members requires it	2013-03-11 07:33:30 -04:00
Installer_pm.t	…
ItemCirculationAlertPreference.t	…
ItemType.t	bug 8768 correct an error in ItemType.t	2012-09-15 07:20:08 +02:00
Koha.t	Bug 9659 - QA Follow up: Unit tests	2013-04-26 08:09:34 -04:00
Labels.t	Bug 11402: (follow-up) add one more unit test	2014-02-07 12:39:30 -03:00
Labels_split_ccn.t	…
Labels_split_ddcn.t	…
Labels_split_lccn.t	bug 9370: add invalid call number to LC splitting test cases	2013-06-28 11:20:13 -03:00
Languages.t	Bug 5327 added tests for C4/Languages.pm	2012-01-31 17:21:51 +01:00
Letters.t	Bug 10843: fix crash that can occur when confirming hold if ReservesMaxPickUpDelay is undefined	2013-12-03 15:42:12 -03:00
Log.t	…
Maintainance.t	…
Makefile	Bug 8519 - Make koha-index-daemon run on startup	2012-12-07 09:19:18 -05:00
Matcher.t	Bug 5327 Tests for C4::Matcher	2012-09-07 14:31:52 +02:00
Members_AttributeTypes.t	Bug 7919: Fix unit test (Members_AttributeTypes.t)	2012-12-07 18:26:37 -05:00
Members_Attributes.t	…
Members_Messaging.t	…
Message.t	…
NewsChannels.t	…
Output.t	Bug 10016: force zero browser-side caching of SCO pages	2013-11-20 10:57:39 -03:00
Output_JSONStream.t	Bug 5327 fixing missing number of tests	2011-01-21 11:28:58 +13:00
Overdues.t	…
Patroncards.t	…
Patroncards_Batch.t	…
Patroncards_Layout.t	…
Patroncards_Lib.t	…
Patroncards_Patroncard.t	…
Patroncards_Profile.t	…
Patroncards_Template.t	…
Print.t	…
QueryParser.t	Bug 9239: Introduce QueryParser driver for PQF	2013-03-16 21:32:32 -04:00
RecordProcessor.t	Bug 7417: Include see from references in bibliographic searches	2012-09-13 14:19:28 +02:00
Review.t	…
Ris.t	bug 5327 added unit tests for C4/Ris.pm	2012-01-31 17:21:49 +01:00
RotatingCollections.t	…
SIP_Sip.t	Added unit tests for Sip Checksum.pm	2011-12-15 13:41:37 +01:00
SMS.t	…
Scheduler.t	Bug 5327 added unit tests for C4/Scheduler.pm	2012-01-31 17:21:49 +01:00
Scrubber.t	Added unit tests for Scrubber	2011-12-15 13:41:43 +01:00
Search_PazPar2.t	Bug 5327 added unit tests for C4/Search_PazPar2.pm	2012-01-31 17:21:50 +01:00
SocialData.t	Bug 5327: Unit tests for C4 socialdata	2012-09-07 14:32:00 +02:00
Stats.t	…
SuggestionEngine.t	Bug 8726 follow-up: fix QA issues	2012-09-28 17:14:15 +02:00
SuggestionEngine_AuthorityFile.t	Merge remote-tracking branch 'origin/new/bug_8209'	2012-10-01 16:39:52 +02:00
Templates.t	Bug 10560: add regression test	2013-07-16 15:01:40 -03:00
TmplToken.t	Bug 5327 added unit tests for C4/TmplToken.pm	2012-01-31 17:21:50 +01:00
Utils.t	…
VirtualShelves_Merge.t	…
XSLT.t	bug 10292: improve fallback logic for picking XSLT	2013-06-04 12:40:21 -03:00
dummy.t	…
perlcriticrc	Updating perlcriticrc to allow Modern::Perl to suffice instead of use warnings; and use strict;	2012-01-27 11:33:15 +01:00
rewrite-config-test.PL	…
smolder_smoke_signal	…