Koha-clms/opac
Galen Charlton d4cad06ab2 do some validation of the KohaOpacRecentSearches cookie
Add validation of the value of the KohaOpacRecentSearches.  In
particular, this patch avoids the generation of an internal server
error when the OPAC is presented with an old cookie that uses the
old Storable-based serialization.

This patch also moves parsing of the cookie value into a
new routine in C4::Auth, ParseSearchHistoryCookie, and adds
a test case.

To test (in conjunction with the previous patch):

Exercise the OPAC search history functionality, after
turning on the EnableOpacSearchHistory syspref:

- As an anonymous user, conduct a variety of searches,
  including ones that include non-ASCII characters
- Check the search history and verify that all searches
  are listed
- Apply this patch and the previous one.
- Do *not* clear the KohaOpacRecentSearches cookie
- Check the search history and verify that no searches
  are listed any more
- As an anonymous user, conduct a variety of searches,
  including ones that include non-ASCII characters
- Check the search history and verify that all searches
  are listed
- Log into the OPAC
- Verify that current and past searches are listed in
  search history.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2013-07-28 03:16:57 +00:00
..
errors Bug 4330 Fixing FSF statements 2012-05-29 16:50:16 +12:00
rss adding file just for creating the rss directory 2007-08-02 08:50:43 +00:00
sco Bug 8518 - Self checkout does not display debt amount if syspref AllowFineOverride is set to allow 2012-08-02 11:55:55 +12:00
changelanguage.pl Bug 4330 Fixing FSF statements 2012-05-29 16:50:16 +12:00
ilsdi.pl Bug 6752: Be stricter with utf-8 encoding of output 2012-01-27 12:11:06 +01:00
maintenance.pl Bug 4330 Fixing FSF statements 2012-05-29 16:50:16 +12:00
oai.pl Bug 4330 Fixing FSF statements 2012-05-29 16:50:16 +12:00
opac-ISBDdetail.pl Bug 3652: close XSS vulnerabilities on biblionumber and authid 2012-10-22 17:01:44 +13:00
opac-MARCdetail.pl Bug 3652: close XSS vulnerabilities on biblionumber and authid 2012-10-22 17:01:44 +13:00
opac-account.pl Bug 4330 : Fixing FSF address and copyright statements 2012-05-29 16:50:05 +12:00
opac-addbybiblionumber.pl Bug 7788: [SIGNED-OFF] Followup: GetShelf call in addbybiblio script corrected 2012-05-23 16:20:42 +12:00
opac-alert-subscribe.pl Bug 4289: 'OpacPublic' feature 2011-01-19 14:30:34 +13:00
opac-authorities-home.pl Bug 5453 Move declarations out of conditionals in opac 2011-07-15 15:50:22 +12:00
opac-authoritiesdetail.pl Bug 8981 follow-up: case 2012-11-30 20:09:11 +13:00
opac-basket.pl Bug 4330 Fixing FSF statements 2012-05-29 16:50:16 +12:00
opac-browser.pl Bug 4289: 'OpacPublic' feature 2011-01-19 14:30:34 +13:00
opac-changelanguage.pl Bug 4330 Fixing FSF statements 2012-05-29 16:50:16 +12:00
opac-detail.pl Bug 7379: display of copy number description (AV) 2013-04-21 12:48:50 +12:00
opac-downloadcart.pl bug 5579 : Fixes several exports to embed items 2011-04-19 22:35:15 +12:00
opac-downloadshelf.pl Bug 7788: [SIGNED-OFF] Remove two unused calls to GetShelf 2012-05-23 16:19:34 +12:00
opac-export.pl Bug 3652: close XSS vulnerabilities in opac-export 2012-10-22 17:02:25 +13:00
opac-ics.pl Bug 5549 : GetPendingIssues now returns DateTime objects 2012-03-20 12:33:37 +13:00
opac-image.pl Bug 8255: allow local cover images to be cached 2012-06-26 13:37:25 +12:00
opac-imageviewer.pl Bug 1633: QA follow-up 2012-01-24 11:16:10 +01:00
opac-main.pl Bug 4330 Fixing FSF statements 2012-05-29 16:50:16 +12:00
opac-messaging.pl Fix FSF address in directory opac/ 2010-03-16 20:17:54 -04:00
opac-modrequest-suspend.pl Bug 7641: Suspend Reserves 2012-03-29 14:37:49 +02:00
opac-modrequest.pl Fix FSF address in directory opac/ 2010-03-16 20:17:54 -04:00
opac-mymessages.pl Bug 4330 : Fixing FSF address and copyright statements 2012-05-29 16:50:05 +12:00
opac-passwd.pl Bug 8515 - OPAC password change does not obey OpacPasswordChange 2012-11-26 20:56:02 +13:00
opac-patron-image.pl Bug 3516 [REVISED] Display picture of patrons in OPAC 2012-03-05 17:12:16 +01:00
opac-privacy.pl Bug 4330 Fixing FSF statements 2012-05-29 16:50:16 +12:00
opac-ratings-ajax.pl Bug 8315 - fix 'C4::Output 3.02' errors in Koha 2012-06-30 09:33:07 +12:00
opac-ratings.pl Bug 5668 - Star ratings in the opac 2012-04-10 14:40:49 +02:00
opac-readingrecord.pl Bug 8017 reduce manipulation of GetAllIssues return 2012-09-16 07:14:04 +12:00
opac-renew.pl Bug 7551 : Can only renew for the user you are logged in as now 2012-02-17 09:12:21 +01:00
opac-reserve.pl Bug 10166 [3.10.x] Can't place holds on multiple titles if one or more are un-holdable 2013-06-17 20:47:06 +12:00
opac-review.pl Bug 4289: 'OpacPublic' feature 2011-01-19 14:30:34 +13:00
opac-search-history.pl do some validation of the KohaOpacRecentSearches cookie 2013-07-28 03:16:57 +00:00
opac-search.pl do some validation of the KohaOpacRecentSearches cookie 2013-07-28 03:16:57 +00:00
opac-sendbasket.pl Bug 8626: Fix encoding in cart emails for use of quoted-printable 2012-08-30 10:09:32 +12:00
opac-sendshelf.pl Bug 3651 Follow-up, Require patron login to send shelves and baskets 2012-01-06 15:57:57 +01:00
opac-serial-issues.pl Bug 6195 : Opac user should not have serial manage tab 2011-04-19 13:29:01 +12:00
opac-shelves.pl Bug 7310: Code changes for Improving list permissions 2012-03-21 16:46:40 +01:00
opac-showmarc.pl Bug 8872: Changes for opac-showmarc 2012-11-09 10:09:45 +13:00
opac-showreviews.pl Bug 6679 :[SIGNED-OFF] Fixing some perlcritic violations in the opac 2012-04-10 13:45:00 +02:00
opac-suggestions.pl Bug 4330 Fixing FSF statements 2012-05-29 16:50:16 +12:00
opac-tags.pl Bug 7642 - [3.8.x] fix the lost display of tag sizes 2012-10-02 11:22:20 +13:00
opac-tags_subject.pl Bug 4289: 'OpacPublic' feature 2011-01-19 14:30:34 +13:00
opac-topissues.pl Bug 10590 - parameterise the limit option 2013-07-18 20:59:00 +12:00
opac-user.pl Bug 8079 - opac not showing fines - says 'no' 2013-02-21 18:35:48 +13:00
opac-userdetails.pl Fix FSF address in directory opac/ 2010-03-16 20:17:54 -04:00
opac-userupdate.pl Bug 8953 - opac-userupdate encoding issues 2012-10-25 09:15:02 +13:00
unapi Bug 6679 :[SIGNED-OFF] Fixing some perlcritic violations in the opac 2012-04-10 13:45:00 +02:00