Martin Renvoize dfea147183 Bug 42385: (QA follow-up) Test PickupLibrary fall-through to ItemHomeLibrary ... The original _GetCircControlBranch tests covered the case where CircControl is PickupLibrary but no userenv branch is available, in which case the resolution falls through to the ItemHomeLibrary behaviour. That coverage was lost when the tests moved to t/db_dependent/Koha/Policy/Circulation.t, since the PickupLibrary subtest always mocks a userenv. This restores coverage for the fall-through path: with CircControl set to PickupLibrary, no userenv, and no pickup_library_id, the controlling library is resolved from the item's home library. Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Policy/Circulation.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> (cherry picked from commit 6a13c6e5066384e59e52f0d48f5a430958671ef2) Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>		2026-09-21 11:11:33 +00:00
..
Acquisition	…
Biblio	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Budgets	…
C4/ClassSplitRoutine	Bug 30233: (follow-up) Add tests for _apply_substitution and combined modifiers	2026-08-11 12:39:30 +00:00
External	Bug 41479: Remove Baker & Taylor integration	2026-03-24 07:50:10 +01:00
Koha	Bug 10190: (QA follow-up) Add new permission to tests	2026-09-10 14:25:22 +00:00
Number	…
SIP	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Search	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
Serials	Bug 41330: Unit tests	2026-03-09 17:06:49 -06:00
Template	Bug 42136: Add tests	2026-04-28 15:48:21 -06:00
Test	Bug 41076: Adjust our perl tidiness for v20250105	2026-02-05 09:03:51 -07:00
cypress	Bug 10190: (follow-up): test: cypress tests update	2026-09-10 14:25:19 +00:00
data	Bug 41032: Fix Open Fifth missing in plugin repos config	2025-11-26 10:40:25 -07:00
db_dependent	Bug 42385: (QA follow-up) Test PickupLibrary fall-through to ItemHomeLibrary	2026-09-21 11:11:33 +00:00
edi_testfiles	Bug 30144: Add tests for EDIFACT servicing instruction handling	2026-08-28 16:36:24 +00:00
etc	…
lib	Bug 41648: Validate plugin date metadata	2026-08-21 14:31:48 +00:00
mock_templates	Bug 42684: Capitalization: No Barcode	2026-06-12 16:24:07 +00:00
00-check-atomic-updates.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
00-load.t	Bug 42714: RM follow-up: Fix tests	2026-08-13 11:28:40 +00:00
00-merge-conflict-markers.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
00-testcritic.t	…
00-valid-xml.t	Bug 41076: Adjust our perl tidiness for v20250105	2026-02-05 09:03:51 -07:00
Auth.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
AuthoritiesMarc_MARC21.t	Bug 41795: Fix failing test in UNIMARC instances	2026-05-01 11:04:33 -06:00
AuthoritiesMarc_UNIMARC.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
Barcodes_EAN13.t	…
Barcodes_annual.t	…
Barcodes_hbyymmincr.t	…
Barcodes_incremental.t	…
Biblio.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Biblio2.t	…
Breeding.t	Bug 40017: (follow-up) Update GNU license link	2025-10-22 07:42:53 -06:00
Budgets.t	…
Charset.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Circulation_barcodedecode.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
ClassSortRoutine.t	…
ClassSortRoutine_Dewey.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
ClassSortRoutine_Generic.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
ClassSortRoutine_LCC.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
ClassSource.t	…
Context.t	Bug 39337: Add is_opac_suppressed helper to C4::Context	2026-08-25 08:56:25 +00:00
Contract.t	…
CookieManager.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Creators.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
DateUtils.t	…
EdiInvoice.t	…
Edifact.t	Bug 40383: Add unit tests for Koha::Edifact to_json method	2026-03-26 14:21:18 +01:00
Ediorder.t	Bug 30144: (QA follow-up) Fix t/Ediorder.t for JSON servicing_instruction format	2026-09-09 12:07:21 +00:00
Ediordrsp.t	…
Form_MessagingPreferences.t	Bug 43117: Restore use Test::NoWarnings	2026-09-01 15:42:02 +00:00
HtmlTags.t	…
ImportBatch.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Installer_PerlModules.t	…
ItemCirculationAlertPreference.t	…
Koha_MetadataRecord.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Koha_SearchEngine_Elasticsearch_Browse.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Koha_Template_Plugin_HtmlId.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Koha_Template_Plugin_Koha.t	Bug 41107: (follow-up) Use Koha::Status in Koha::Template::Plugin::Koha	2026-03-23 09:33:54 +01:00
Koha_Util_FrameworkPlugin.t	…
Koha_Util_MARC.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Koha_XSLT_HTTPS.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Labels.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
Labels_split_Regex.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
Labels_split_ccn.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Labels_split_ddcn.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
Labels_split_lccn.t	Bug 40680: Fix t/Labels*	2025-12-01 08:34:00 -07:00
Languages.t	Bug 39745: Replace more occurrences in selenium tests	2026-02-09 12:57:59 -07:00
Logger.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Members_Messaging.t	…
OpenLibrarySearch.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Output.t	Bug 30261: Update unit tests	2026-03-20 11:54:32 +00:00
Output_JSONStream.t	…
Patroncards.t	…
Patroncards_Batch.t	…
Patroncards_Lib.t	…
Patroncards_Patroncard.t	…
Patroncards_Profile.t	…
Patroncards_Template.t	…
RecordProcessor.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Ris.t	…
SMS.t	Bug 40680: Fix t tests	2025-12-01 08:34:01 -07:00
Scheduler.t	…
Scrubber.t	Bug 40659: Change Scrubber profile name to opac_virtual_card	2026-04-23 16:04:11 -06:00
Search.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
Search_PazPar2.t	…
SimpleMARC.t	Bug 28915: Add control field support to Koha::SimpleMARC::update_field()	2026-06-15 15:24:05 +00:00
SuggestionEngine.t	…
SuggestionEngine_AuthorityFile.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
TmplToken.t	…
Token.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
template_filters.t	Bug 40163: (follow-up) Fix wrong GNU links and update test	2025-09-24 09:25:04 -06:00
timezones.t	…