Koha-clms/t/Koha
Jake Deery ed8aed912c
Bug 13888: 'Lists' permission should allow/disallow using the lists module in staff
This patch adds two new system preferences, use public lists, and create public
lists. Use public lists determines if a librarian is permitted to see public
lists, whilst create public lists determines if a librarian can create new public
lists.

It also fixes erroneously allowing staff to add items to existing lists, by
honouring the existing edit_public_list_contents

To test:
a)  notice the new my lists link on the account pulldown
    1)  ensure it goes to the lists module
b)  create new public list, add at least one item, make it editable by everyone
    1) note the name of the list
c)  create a new patron with full access to the staff client minus lists permissions
d)  log in as the newly created patron
e)  notice the lists button is missing from the staff client mainpage
f)  set any of the lists permissions except create public lists, use public lists, edit public list contents
g)  notice how the lists button is no longer missing from the staff client mainpage
h)  go to the lists module
    1) notice that public lists are now missing from the datatable
i)  click add list
    1)  notice that the public drop-down is now a fixed label set to private
j)  create list and confirm it is not public
k)  turn use public lists permission on
l)  return to the lists module
    1)  notice that the datatable now shows private and public lists tabs
m)  turn create public lists permission on
n)  repeat steps h-i
    1)  notice that the public drop-down is now visible again
o)  create list and confirm it is public
p)  go to the list you created in step b
q)  notice that add items button, and remove selected button, is missing
r)  turn edit public list contents permission on
s)  repeat steps p-q
    1) notice that add items button is now visible
t)  click add items
u)  enter an item barcode or biblio number, click save
    1) notice that the items are now added to the list

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2024-07-22 09:57:04 +01:00
..
Auth Bug 13888: 'Lists' permission should allow/disallow using the lists module in staff 2024-07-22 09:57:04 +01:00
Authority Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Database Bug 29695: Add new module Koha::Database::Columns 2022-04-12 11:40:16 +02:00
DateTime/Format Bug 36486: Fix file perms and tidiness 2024-05-10 16:45:49 +02:00
I18N/po/xx_XX/LC_MESSAGES Bug 29695: Add new module Koha::Database::Columns 2022-04-12 11:40:16 +02:00
Installer Bug 35681: Add Koha::Installer::Output 2024-05-02 16:47:40 +02:00
Middleware Bug 33967: Add unit test to ensure SetEnv doesn't compromise $env 2023-06-09 08:50:13 -03:00
Object Bug 29857: (follow-up) Fix t/Koha/Object/Message.t 2022-03-02 09:40:05 -10:00
Plugins Bug 29857: (follow-up) Fix t/Koha/Plugins/Tab.t 2022-03-02 09:40:05 -10:00
REST/Plugin Bug 30645: Add REST/Plugin/Query tests 2024-04-26 08:52:47 +02:00
Result Bug 29746: (it-doesn't-hurt follow-up) More tests 2022-01-05 13:33:46 -10:00
SearchEngine Bug 31652: Add geo-search 2024-04-29 15:19:34 +02:00
Util Bug 30678: (follow-up) Add oclc_number routine and friends 2022-07-22 14:58:11 -03:00
Config.t Bug 31393: Tidy 2023-10-30 09:02:18 -03:00
Email.t Bug 31627: (follow-up) Update -Id to -ID 2024-05-10 14:11:50 +02:00
Exceptions.t Bug 35248: Add test for Koha::Exceptions::Booking 2024-03-15 09:38:46 +01:00
I18N.t
…
ItemType.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Script.t Bug 24786: Fix Script_cron.t and t/Koha/Script.t 2020-11-06 17:04:31 +01:00
Script_cron.t Bug 24786: Fix Script_cron.t and t/Koha/Script.t 2020-11-06 17:04:31 +01:00
Z3950responder.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
sleep.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
wait.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00