52fe8c72b2
QA review noted that the new /api/v1/action_logs endpoint exposed only column data, so the log viewer ended up showing bare borrowernumbers in the Librarian and Object columns where the old server-side rendering showed firstname/surname (borrowernumber). Add the DBIC plumbing needed to support x-koha-embed for those relationships. Two belongs_to relationships are declared below the auto-generated marker on Koha::Schema::Result::ActionLog: * librarian -> borrowers.borrowernumber via action_logs.user * patron -> borrowers.borrowernumber via action_logs.object The patron relation is intentionally polymorphic; the action_logs.object column holds different identifiers per module (biblionumber for CATALOGUING, subscriptionid for SERIAL, ...) so callers must filter by module before trusting the joined patron - this is documented in both schema and Koha::ActionLog comments. Koha::ActionLog gains explicit librarian() and patron() accessor methods following the Koha::Hold pattern, returning Koha::Patron objects (or undef when the relation does not match). The accessors deliberately avoid `use Koha::Patrons` at compile time: Koha::ActionLog is loaded very early via C4::Log and Koha::Patron is not yet defined at that point - the accessors reach for it lazily at call time. koha_object_class / koha_objects_class overrides are also added to bring the result class in line with the rest of the codebase. Test plan: 1. prove t/db_dependent/api/v1/action_logs.t (still green) 2. perl -MKoha::ActionLog -e 'print "ok"' (no circular import) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jacob O'Mara <Jacob.omara@openfifth.co.uk> |
||
|---|---|---|
| .. | ||
| Loader | ||
| Result | ||