This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes
almost all perlcrictic violations according to this .perlcriticrc
The remaining violations are silenced out by appending a '## no critic'
to the offending lines. They can still be seen by using the --force
option of perlcritic
This patch also modify t/00-testcritic.t to check all Perl files using
the new .perlcriticrc.
I'm not sure if this test script is still useful as it is now equivalent
to `perlcritic --quiet .` and it looks like it is much slower
(approximatively 5 times slower on my machine)
Test plan:
1. Run `perlcritic --quiet .` from the root directory. It should output
nothing
2. Run `perlcritic --quiet --force .`. It should output 7 errors (6
StringyEval, 1 BarewordFileHandles)
3. Run `TEST_QA=1 prove t/00-testcritic.t`
4. Read the patch. Check that all changes make sense and do not
introduce undesired behaviour
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| UNIMARC_fix_collectiontitle.pl | ||
| UNIMARC_sync_date_created_with_marc_biblio.pl | ||
| auth_show_hidden_data.pl | ||
| borrowers-force-messaging-defaults.pl | ||
| check_sysprefs.sh | ||
| cmp_sysprefs.pl | ||
| compare_es_to_db.pl | ||
| fix_accountlines_date.pl | ||
| fix_accountlines_rmdupfines_bug8253.pl | ||
| fix_mysql_constraints.pl | ||
| fix_tags_weight.pl | ||
| generate_MARC21Languages.pl | ||
| make_zebra_dom_cfg_from_record_abs | ||
| process_record_through_filter.pl | ||
| remove_items_from_biblioitems.pl | ||
| sanitize_records.pl | ||
| search_for_data_inconsistencies.pl | ||
| touch_all_biblios.pl | ||
| touch_all_items.pl | ||
| update_authorities.pl | ||