gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
32,431 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Tomas Cohen Arazi 053eb7a4e7 Bug 22071: (follow-up) Simplify code 
In order to add features to this method, the current code would force us
to do it for each authentication method.

There's duplicated code that could be simplified. This patch makes the
authentication code just set $user on each block (oauth and cookie
authentication) and moves the final permissions check to the end of the
authenticate_api_request method.

Overall, the behaviour remains unchanged.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t \
          t/db_dependent/api/v1/oauth.t
=> SUCCESS: Tests pass! Nothing changed!
- Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 0d5058b7b2)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit a6dc145ce9)

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
 		2019-01-11 19:32:51 +00:00
C4 Bug 22052: Refactor DeleteExpiredOpacReigstrations 2019-01-11 19:11:25 +00:00
Koha Bug 22071: (follow-up) Simplify code 2019-01-11 19:32:51 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 21853: (follow-up) to solve printpdf error 2018-12-07 18:32:00 +00:00
admin Bug 22020: (bug 21777 follow-up) Fix columns visibility for circulation.pl 2019-01-11 19:21:46 +00:00
api/v1 Bug 20942: Split debit and credit lines 2018-08-02 18:03:36 +01:00
authorities Bug 21986: Do not escape quotation marks when cataloguing 2018-12-22 20:46:39 +00:00
basket Bug 21874: Fix encoding of cart and list email subjects 2018-12-18 13:47:47 +00:00
catalogue Bug 22034: Handle default framework for MARC view with framework 2019-01-09 12:42:31 +00:00
cataloguing Bug 21986: Do not escape quotation marks when cataloguing 2018-12-22 20:46:39 +00:00
circ Bug 21928: (bug 18789 follow-up) Fix CircAutoPrintQuickSlip=clear 2019-01-08 23:27:36 +00:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 21349: Instructors with special characters in cardnumber cannot be removed from course reserves 2018-11-08 15:45:30 +00:00
debian Bug 17111: Automatic debian/control updates (oldstable/18.05.x) 2018-12-21 13:06:04 +00:00
docs Bug 7143: Update about page for new dev Thatcher Leoonard 2018-11-23 16:11:38 +00:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 22073: Add to diacritics mappings for Ž and ž 2019-01-11 19:29:54 +00:00
ill Bug 21289: Fix "isa" bug during partner request 2018-10-05 13:10:31 +01:00
installer Bug 22030: DBRev 18.05.07.002 2019-01-11 19:07:16 +00:00
koha-tmpl Bug 22030: Use preference to determine username sent to overdrive 2019-01-11 18:54:41 +00:00
labels Bug 21719: Fix typos 2018-11-16 12:59:57 +00:00
members Bug 21986: Do not escape quotation marks when cataloguing 2018-12-22 20:46:39 +00:00
misc Bug 21908: (QA follow-up) Remove useless parentheses in query 2018-12-21 19:42:54 +00:00
offline_circ Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl 2018-09-17 14:27:25 +01:00
opac Bug 22030: Use preference to determine username sent to overdrive 2019-01-11 18:54:41 +00:00
patron_lists Bug 19837: Add error feedback for duplicated or unfound cardnumbers 2018-02-18 16:48:46 -03:00
patroncards Bug 21719: Fix typos 2018-11-16 12:59:57 +00:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 21984: Pass param_name in pagination URL 2018-12-27 21:58:51 +00:00
reserve Bug 21719: Fix typos 2018-11-16 12:59:57 +00:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-15 13:34:36 +01:00
serials Bug 21719: Fix typos 2018-11-16 12:59:57 +00:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-09 11:20:29 +01:00
svc Bug 21115: Add multi_param call and add divider in cache key in svc/report and opac counterpart 2018-10-17 11:55:53 +01:00
t Bug 22071: Regression tests 2019-01-11 19:32:17 +00:00
tags Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 22022: Correct ordering for authorised values 2018-12-28 03:35:07 +00:00
virtualshelves Bug 21874: (QA follow-up) Fix intranet sendshelf 2018-12-18 13:47:48 +00:00
xt Bug 18959: Skip xt/author/Text_CSV_Various.t if Text::CSV::Unicode missing 2018-11-05 14:56:38 +00:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.gitignore Bug 20267: Add basic .gitignore 2018-03-26 17:31:16 -03:00
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 22030: DBRev 18.05.07.002 2019-01-11 19:07:16 +00:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 21719: Fix typos 2018-11-16 12:59:57 +00:00
README
…
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 20428: Display warning if the entry is empty 2018-05-14 11:14:40 -03:00
changelanguage.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
edithelp.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 20489: Remove warnings from the interface 2018-04-20 12:24:00 -03:00
rewrite-config.PL Bug 18342: Enable memcached by default for new installs 2018-05-03 12:47:07 -03:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo